From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68C592EEE88 for ; Sun, 14 Jun 2026 16:56:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781456204; cv=none; b=iDIJV/sOZSSCtY7AX8Zh2+ICNnFiRiuAHcZhkMp+xSAKSEph6zHYlpiHUJn/URKHQ4JdT/C0EEyqmQC5uHzTRM7SJ3RUfZwIbnxCoRb7G4eTRwiRZhp+RCktepcbtDQN3eXJuMEANiCCBrxcT34a5zY8zaZBwKHJL6jcc3ijfAI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781456204; c=relaxed/simple; bh=dkJJ9uzMZ/+Wvof2subdudp1ueZI9/fdtBdT0y07Tlg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HLm8asjdAwXzSG49WjlKQuHH32sL9HMuI3JIYSPuiOjJsdBDAscEE7rQb56MTIDrFQRkprYm4r/CUkBwH3uqDQrNyTLBJEdIpWxRvODVvQIUlp4VOwuI1k9kFyVsA4wLv3tW1Jl1mEXC5+VsQVHYt6tnU87+IFZLVwkOsmxY8s4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k5GvkAf0; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k5GvkAf0" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2c2da7fa321so10731235ad.1 for ; Sun, 14 Jun 2026 09:56:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781456203; x=1782061003; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5AVHj6ed8VwyCttBF9dIP58qYaaDmNXZpDaeTXKj2YM=; b=k5GvkAf0qqcJ1YZ9xjIfVYOV4udIWIm1UqnTjKpYPjguP580Xu6LL/E6NvG9ezVHUr vE2FOitnXLYfpAahrXXktc7054hpAE0YhfPLCUNzWlhjlPEfHrNXQxFss7Ssvjj3z9F6 PiDjQZucTwnbfrKEoxAeV+L/HeSD7EKWpo9XqTLpMkYR7gQV5R0kGR6heQ/DdauGBvxz ZpaYUgvcTwRgtE1wF6hvpGGtLmovvtI+n0o3TEi/SLkOZZIBLObhi7ljV+wChx7YfokZ p7cQIDk/J6k82O3cZwwQ9lPw34yZD/Id0IxUjH6QP+5+wFSyjDYJ0HobeKzVAAlLP4YI wZzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781456203; x=1782061003; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5AVHj6ed8VwyCttBF9dIP58qYaaDmNXZpDaeTXKj2YM=; b=aRe8Hmf5uJIdQf0WSjVJ4HwuNWwLC9P7IiD27El40ZXFCbdpl1mnWZ2toviAYpkFbW uaO299OX8c+r3/yhG44ULgUuPv8JddTGK2NwE6EJh8dxvl3C7kwn7EnGvYzTGeqQqktA LOM+I+6NMhOzOGFLnfX5wSTsFAFWQaCM5H9h51tanwh4j9WvEutg/xPucOtKj0ez+/Jc Y2IB0k0/mY2ziVhMI0h/jVDBBNBHbfwB4oTsFeGS7FsVwZ5LXGsJ4iU1rCAm6qo2ZRsH BqPMGwRRB/8U6qsf4WiUQVFqga5Kbh8Eu6qaQIjeETCLAh/Om7gE6ve7jwoLRjYnR25S z7HA== X-Forwarded-Encrypted: i=1; AFNElJ91seJBsMGNAfeHu4wQ9FDMwgEcDNeqsQJASBecKaW8qekrytMmjy9qi8HU6jYxz0HVKwlBUY2rejh3r0M=@vger.kernel.org X-Gm-Message-State: AOJu0YzrJLV9nPwDmlB0sImUI1SGA9qoophBQZim6PgPt86/bCdIrF9y CgXXGQvtEke7KiLzSVdvXK3O/xD+pVts2CQ/SQ/pp0uDQ66tc4elNHy8 X-Gm-Gg: Acq92OFQJIfjccN5shSwsDaPIxQga3jopRCv8TaONnj1z3oOyw6nj2RkysgZe4sZAsB d7o+1aac/5u2YsaI5SUKbpNU6/LW/a7tl9q7QjIclXN5DTIOdkivQcE/akD9WKd3fiQ3WWejRMB cb/FDubdb7QxUAVycPTS5qq5HorHK/7JMFirxMwWwD1+SyvLL4vnaHp/ttX9YLeOPSe8CdTlwWY aFOYpyNThg3IssvUses+SFPo+bOWByxmbMw9uCvhjet1dwxZy2dXQ3fbudJ7v11XUZrMq0LfGyw 3fuWZVlYdB+/fLBO6B+2QvKcmJ1SY/IvKZHcLr2+eZIDFTxRAao4Uz40rRmfDOaTNfEcniPvKt7 fxapFVYw6I4RenB69jttEZJg5JL52XlaRirHSYbwmSujvw7y6n9C0FTGd3za5l152hplRafdK12 pPE1YEeM/MI8RVOmUEMx00OPrNPDSH6StLSrDR3agL5e2HASEAzUkb X-Received: by 2002:a17:902:da2d:b0:2c4:d55:eb88 with SMTP id d9443c01a7336-2c410cd169dmr115009285ad.4.1781456202748; Sun, 14 Jun 2026 09:56:42 -0700 (PDT) Received: from localhost.localdomain ([49.207.217.37]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42f2e5590sm85284025ad.14.2026.06.14.09.56.40 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 14 Jun 2026 09:56:42 -0700 (PDT) From: Biren Pandya To: linux-media@vger.kernel.org, mchehab@kernel.org Cc: Biren Pandya , Hans Verkuil , Bradford Love , linux-kernel@vger.kernel.org Subject: [PATCH 01/22] media: i2c: cx25840-core: Add missing media_entity_cleanup() Date: Sun, 14 Jun 2026 22:25:38 +0530 Message-ID: <20260614165630.3896-2-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260614165630.3896-1-birenpandya@gmail.com> References: <20260614165630.3896-1-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The media_entity_pads_init() function initializes the media entity, but the driver forgets to call media_entity_cleanup() in the error paths and remove function. Add the missing calls to fix the API violation and prevent potential future memory leaks. Signed-off-by: Biren Pandya --- drivers/media/i2c/cx25840/cx25840-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/i2c/cx25840/cx25840-core.c b/drivers/media/i2c/cx25840/cx25840-core.c index 69d5cc648c0f..a3d7473854a3 100644 --- a/drivers/media/i2c/cx25840/cx25840-core.c +++ b/drivers/media/i2c/cx25840/cx25840-core.c @@ -3962,6 +3962,7 @@ static int cx25840_probe(struct i2c_client *client) int err = state->hdl.error; v4l2_ctrl_handler_free(&state->hdl); + media_entity_cleanup(&sd->entity); return err; } if (!is_cx2583x(state)) @@ -3986,6 +3987,7 @@ static void cx25840_remove(struct i2c_client *client) cx25840_ir_remove(sd); v4l2_device_unregister_subdev(sd); v4l2_ctrl_handler_free(&state->hdl); + media_entity_cleanup(&sd->entity); } static const struct i2c_device_id cx25840_id[] = { -- 2.50.1 (Apple Git-155)