From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 938473A1D02 for ; Sun, 14 Jun 2026 16:58:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781456307; cv=none; b=Wv6iwVv5FC96VemhFnkty1wE2dR+oo7PPPWY+FNQ83am1x+pdvWKkaU9H+4IL4qa9m3SSkFMRfx+Mc3n5/A5SlueSnQqfdagRYpBzNdWUmffhvj22+Nm2eIwg60/4O9K5vnZQnPWia8m0rchnUAxkLQuDHxNJrRJw4fTqbRzwzc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781456307; c=relaxed/simple; bh=1eMFal86YAen0vVh9LNK/i8PVVHxlGEY2RnZMp67kpY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P1FnL9d1iwz+QFiOY7pIGgm+VIXN6/yA+4O1gn7z0IPqtuZJjh6xrWr+ZpcvGy4WX7hBOsV3kFNabriJ/+zzdm00yKXxgBos2EuJSKgAOcVGGXHtGvdQKxlkOu5QiTmqR4WCgIph5sAl+mVGPW2We3DvKsiiFHCCJNRgNFZXpz8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bakx94vq; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bakx94vq" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2c0aa420401so18317235ad.3 for ; Sun, 14 Jun 2026 09:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781456306; x=1782061106; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1s1vse+Ln4RMdyUiTjXy+JLi3K4i9YZx/oe5qm3b5zQ=; b=bakx94vqkteXGynW3t0nitYgwewd9sOF8kLGGe+uPapkFrcOGK2F6qAx45mqSyupWG b1KhuZLzcNN7T1qh0cmQeMUQkrySKL8W72CaOrI5U4PRKA1skRmNg1uOq2nHfcqr7l3p pg8HYGvNBMBTPR3kFXAqjoy6uiJAYRtIF/qK9SgQIHSXvXLoPDmguKzHQHEARwrUfudv 58xXAOZAHIoeMomnbZdw4HAVbvkQApe6dfEPD8dbGjp1XlIz/JbY5SDJrUx7yBFr/ESw p11bGOJJM7v3bVbh3cnGnTyGn7k3uUAL8rDOlOgHS20uNDfkVnGKlItAKVkqw6l0AW1Z K2UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781456306; x=1782061106; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1s1vse+Ln4RMdyUiTjXy+JLi3K4i9YZx/oe5qm3b5zQ=; b=QIX9ZmEw/iOhEOEmWP87dz/HT+fPWaX9C3+kUUTyUGUOhLeHwKxPKcI88snItBtX+R s51ngKYYEm6BOXP47fCDMDyg3/fOFQ4OTnvSRpEZKJTR3V8Nc29aRhS55n09Gmrmnw8f 9bgZvYZKfbZu82+Ps3eBDVsCxVieGUTJJ2y7pSpkgALL+EjDy1nth2e9K3foG8ZwJ0qA uWIeMr7YLBSGGaxGkWVi5/CKRxiEBHqlHiVOxg/ZJBhj6Ay4aRxRc2LTGK+Vw1pki5Km dBMD7+gky3RNHs5sA+jj9BFwxFiSRULllZ4nQ9C0oiRBJsGxMkxOPROeH4XqXSK94m4L saBw== X-Forwarded-Encrypted: i=1; AFNElJ/O4c+kdlGZEGIu3gRUqegEpNr5ITdIDhYlnSQb9tAFs/nJWAcQ0pwNdfqZssLkyOGbSpr8mObKEjXMk5U=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8TlKbs8sl5XknEPi28Kcj9ewdc7d/9NtqW6JtCP2YBVy81UuQ g2twKzoHQSSKl6TXu07qOJw03LKLbXpZYMWR+8KofsXaAP+xvnUDaEQ+ X-Gm-Gg: Acq92OGnJEYRhUQPgZUUWc5qyugrLZf+sv0aplK36J8Sbixlok9JLND4kkeqdOv8YJl bKm9L52CBF6pIFsmc51SfuyPWTIZlsIf1DsOMzynHoaSCSuvA3Duo/93jMAhL/3SYQ5IXcrYTg8 XJFu4vKoeAZ42+Lc8F9be65gLJffBZ942hA7O1MFbx12DbXukWsirHfWTN+BqqbsWAcoO7dF10W mfbckiw1HhiM999J4mB4p9gPXZ6fymr1VK5ejZ1dYr3o9deTs3V6ZIdC20NqPt583FlKl+J+gPO kEvFLY5xMWVpCCj7bEYpqhb7ytybZ6J4Lj/0Y/jdZSR2pJ0Lw4bQON+oIpZLAEBwbeIX2kmBsoT hswZ9xak0EwpPlqleDBHcL8vp20VKGp87JtAoPl4wbpKbU6/9+lkfKuJDDjllUhxvGvnSwKx2qH a0+upLu672TCoeZny7L89EX1nJCtMdYfFpPExQ5SdHlOrfRR4GRdND X-Received: by 2002:a17:903:2352:b0:2c2:27be:39a3 with SMTP id d9443c01a7336-2c41300f817mr109828205ad.29.1781456306087; Sun, 14 Jun 2026 09:58:26 -0700 (PDT) Received: from localhost.localdomain ([49.207.217.37]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42f2e5590sm85284025ad.14.2026.06.14.09.58.23 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 14 Jun 2026 09:58:25 -0700 (PDT) From: Biren Pandya To: linux-media@vger.kernel.org, mchehab@kernel.org Cc: Biren Pandya , Hans Verkuil , Bradford Love , Chen Ni , linux-kernel@vger.kernel.org Subject: [PATCH 20/22] media: usb: au0828: Add missing media_entity_cleanup() Date: Sun, 14 Jun 2026 22:25:57 +0530 Message-ID: <20260614165630.3896-21-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260614165630.3896-1-birenpandya@gmail.com> References: <20260614165630.3896-1-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The media_entity_pads_init() (or media_entity_init()) function initializes the media entity, but the driver forgets to call media_entity_cleanup() in the error paths and remove function. Add the missing calls to fix the API violation and prevent potential future memory leaks. Signed-off-by: Biren Pandya --- drivers/media/usb/au0828/au0828-video.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c index 3c53105f3d2b..fec4eafd6e30 100644 --- a/drivers/media/usb/au0828/au0828-video.c +++ b/drivers/media/usb/au0828/au0828-video.c @@ -628,6 +628,7 @@ void au0828_usb_v4l2_media_release(struct au0828_dev *dev) if (AUVI_INPUT(i).type == AU0828_VMUX_UNDEFINED) return; media_device_unregister_entity(&dev->input_ent[i]); + media_entity_cleanup(&dev->input_ent[i]); } #endif } @@ -934,7 +935,9 @@ int au0828_analog_unregister(struct au0828_dev *dev) mutex_lock(&au0828_sysfs_lock); vb2_video_unregister_device(&dev->vdev); + media_entity_cleanup(&dev->vdev.entity); vb2_video_unregister_device(&dev->vbi_dev); + media_entity_cleanup(&dev->vbi_dev.entity); mutex_unlock(&au0828_sysfs_lock); v4l2_device_disconnect(&dev->v4l2_dev); @@ -1907,8 +1910,10 @@ static void au0828_analog_create_entities(struct au0828_dev *dev) pr_err("failed to initialize input pad[%d]!\n", i); ret = media_device_register_entity(dev->media_dev, ent); - if (ret < 0) + if (ret < 0) { pr_err("failed to register input entity %d!\n", i); + media_entity_cleanup(ent); + } } #endif } @@ -2026,6 +2031,7 @@ int au0828_analog_register(struct au0828_dev *dev, if (retval != 0) { dprintk(1, "unable to register video device (error = %d).\n", retval); + media_entity_cleanup(&dev->vdev.entity); return -ENODEV; } @@ -2055,6 +2061,8 @@ int au0828_analog_register(struct au0828_dev *dev, err_reg_vbi_dev: vb2_video_unregister_device(&dev->vdev); + media_entity_cleanup(&dev->vdev.entity); + media_entity_cleanup(&dev->vbi_dev.entity); return ret; } -- 2.50.1 (Apple Git-155)