From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2865C3CAE81 for ; Sun, 14 Jun 2026 16:58:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781456311; cv=none; b=EXeXZ2mM9q4O/OrSzQQdguzIcCCER6V8TmBGkgGPrtzUQQoageAqNUUIYbbM7tZtUAOo0lxboo+umAa68jRPIBw9HkvnhILvK5zwDYzFW0XvdMcbJ6WMoVlvmkm+eyQklV8Wfqe7ucDfLayAGhBi0VxuRm+fqK0KEdFKthsXtVQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781456311; c=relaxed/simple; bh=UhzMGcfP/gZtI09aVzg4sADjY3x6y1g7GpnBnXdm0X0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pLbpw6rfrNJzhCDxplUHEc9NCJ5fUmjqdBCxwtXyIcPuHofOGHQ80aqYP8W9IEH/+0t7CnWxpSTsmazI+dTyOnuWmlDRK5A+amBGPnr90qMhJqNr2Bn+hyUxuFLiLpW2y4tlhqPjpU7ruYeGVuD0Qu4uU+azObbm+0civL0mUcQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c+3CpEvj; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c+3CpEvj" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2c68190ade4so2432995ad.0 for ; Sun, 14 Jun 2026 09:58:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781456309; x=1782061109; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/kxd+Jkz/lYkMw/6qslaxPl3QML1gIEx/AcRIwkgS3I=; b=c+3CpEvjioX8/kpSgCHIAlAOsiUsz/hGDNlqUh2SlcvuAEg8fiK8mSGwOjM44npdR5 Me76LOt5twhGE32LsmV4LwYtVC+URd2M1L7VpbfAnucr+/zKz/xKZlubz8ek5Nj5EH/0 n72MuDu8phBD21h94qi181OV+sClTFWthRcpVe/9qU0tsq1K9XPCIR3fHWUOAe98xvvs mBgmbcZtTlDIG5W7DKBPB3wyMFykjGo8y3n8FJCKNj6W+D1khZ6rJEYpvn+AjR7Gz0Ug /v9CkJWPIIQbf7w5WdY8RVTcQz8Je5Y1zWEzhLftCi+JBL7bhxoax+VGx+VDQ1FLyJ64 K+8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781456309; x=1782061109; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/kxd+Jkz/lYkMw/6qslaxPl3QML1gIEx/AcRIwkgS3I=; b=Raiq1KLP91CzOMSmge0qJGGqzrmZkBUzpJoqV98qyKUniFpv3ws8f7AJ940SLr4owp A6U9ClgRrazY5UZeDX/LCx13rt/OreZVKUfiH3RxBp+PWJVSWAdsh2Q+6nViDrJz5xLh 1sUBS7qb0YjQTmwSrCM9zjAUtsAxoz8LXiPEhzvc2LSoQwvC4s67OWKk7ov2hl3fXzA8 UQP6u/vblIQeJBjQeDz5+UqrHBOfe77RilM5eb5Cc1xsnvYhfdUWRMJtTQXyjFRJxrr8 6dNZhbBEBL3shWs7WK61vOvjlKKoxu3bxLKLXZ4zlpYow0/mg3ScojkSmuy+gta/rXuJ eKWg== X-Forwarded-Encrypted: i=1; AFNElJ9mnei+pIUkeDwiRkiSw+WnDQtLKyftsHdB/9IgIYOt7czjyRPffvh77gylFYEu/4+mLI8DSY5gyBbSH50=@vger.kernel.org X-Gm-Message-State: AOJu0Yyk2w6Xt7IOTwgyCyP94IApQ/M4SR3KfHpgoVW470/Y8gB3RRPV 823YxilRUIjy8lrDtKa5secZYElyYNPhfp9emmpkH/UZHNl8ZLqHj/4T X-Gm-Gg: Acq92OGT4ysIh7qBQds8vQNilXS7TAz+1JiASvC7ceRqVjOfQQ4Hp5YQE/zmGQ/VXdI U56K9nq7DMW/cXy2/hxzJVjebsxfvoM2dh+mmQguhkoqeU1+l9fOKm5uV2nv1DLd7m90jZxEici C9c3RWn5mvyTwf0RZKZJ5Keu42Whq+0ko3HgptKPT4S0/psv+wxEsYnOFYzgGWfdbjq7a3dwFz6 LdHlETJejPlgkTPdvjxu8Hnz4+EJmkCJQgiaya07zKc/HRjhH8N37sBFx3ifF05dff6jNK6ULvp PWxzct3sDJqId7qEsYVOp226xdeCH+SFNKvUXdLs6bEnLo2vI66+HuPoZ7LF/+VNI1SBvMpzkGP PkhcZQYFfTLFF0NHu/ZPni/+0PHUCGlC2xpCqYhbE1kISywzIzDf10AQZ5qbWaAoyWrjjHOrh1N AUR5WuazALNkFiMY6IxaDiThlSFyE2yITYOOfroMbPqvhMmCrta5Ub X-Received: by 2002:a17:903:17cf:b0:2c0:b801:d9ad with SMTP id d9443c01a7336-2c3fb003c63mr97037375ad.3.1781456309499; Sun, 14 Jun 2026 09:58:29 -0700 (PDT) Received: from localhost.localdomain ([49.207.217.37]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42f2e5590sm85284025ad.14.2026.06.14.09.58.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 14 Jun 2026 09:58:29 -0700 (PDT) From: Biren Pandya To: linux-media@vger.kernel.org, mchehab@kernel.org Cc: Biren Pandya , Michael Krufky , linux-kernel@vger.kernel.org Subject: [PATCH 21/22] media: usb: dvb-usb-v2: Add missing media_entity_cleanup() Date: Sun, 14 Jun 2026 22:25:58 +0530 Message-ID: <20260614165630.3896-22-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260614165630.3896-1-birenpandya@gmail.com> References: <20260614165630.3896-1-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Biren Pandya --- drivers/media/usb/dvb-usb-v2/mxl111sf.c | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb-v2/mxl111sf.c b/drivers/media/usb/dvb-usb-v2/mxl111sf.c index 870ac3c8b085..0524685e220e 100644 --- a/drivers/media/usb/dvb-usb-v2/mxl111sf.c +++ b/drivers/media/usb/dvb-usb-v2/mxl111sf.c @@ -900,8 +900,21 @@ static int mxl111sf_attach_tuner(struct dvb_usb_adapter *adap) return ret; ret = media_device_register_entity(mdev, &state->tuner); - if (ret) + if (ret) { + media_entity_cleanup(&state->tuner); return ret; + } +#endif + return 0; +} + +static int mxl111sf_detach_tuner(struct dvb_usb_adapter *adap) +{ + struct mxl111sf_state *state = adap_to_priv(adap); + +#ifdef CONFIG_MEDIA_CONTROLLER_DVB + media_device_unregister_entity(&state->tuner); + media_entity_cleanup(&state->tuner); #endif return 0; } @@ -1093,6 +1106,7 @@ static struct dvb_usb_device_properties mxl111sf_props_dvbt = { .i2c_algo = &mxl111sf_i2c_algo, .frontend_attach = mxl111sf_frontend_attach_dvbt, .tuner_attach = mxl111sf_attach_tuner, + .tuner_detach = mxl111sf_detach_tuner, .init = mxl111sf_init, .streaming_ctrl = mxl111sf_ep4_streaming_ctrl, .get_stream_config = mxl111sf_get_stream_config_dvbt, @@ -1135,6 +1149,7 @@ static struct dvb_usb_device_properties mxl111sf_props_atsc = { .i2c_algo = &mxl111sf_i2c_algo, .frontend_attach = mxl111sf_frontend_attach_atsc, .tuner_attach = mxl111sf_attach_tuner, + .tuner_detach = mxl111sf_detach_tuner, .init = mxl111sf_init, .streaming_ctrl = mxl111sf_ep6_streaming_ctrl, .get_stream_config = mxl111sf_get_stream_config_atsc, @@ -1177,6 +1192,7 @@ static struct dvb_usb_device_properties mxl111sf_props_mh = { .i2c_algo = &mxl111sf_i2c_algo, .frontend_attach = mxl111sf_frontend_attach_mh, .tuner_attach = mxl111sf_attach_tuner, + .tuner_detach = mxl111sf_detach_tuner, .init = mxl111sf_init, .streaming_ctrl = mxl111sf_ep5_streaming_ctrl, .get_stream_config = mxl111sf_get_stream_config_mh, @@ -1246,6 +1262,7 @@ static struct dvb_usb_device_properties mxl111sf_props_atsc_mh = { .i2c_algo = &mxl111sf_i2c_algo, .frontend_attach = mxl111sf_frontend_attach_atsc_mh, .tuner_attach = mxl111sf_attach_tuner, + .tuner_detach = mxl111sf_detach_tuner, .init = mxl111sf_init, .streaming_ctrl = mxl111sf_streaming_ctrl_atsc_mh, .get_stream_config = mxl111sf_get_stream_config_atsc_mh, @@ -1325,6 +1342,7 @@ static struct dvb_usb_device_properties mxl111sf_props_mercury = { .i2c_algo = &mxl111sf_i2c_algo, .frontend_attach = mxl111sf_frontend_attach_mercury, .tuner_attach = mxl111sf_attach_tuner, + .tuner_detach = mxl111sf_detach_tuner, .init = mxl111sf_init, .streaming_ctrl = mxl111sf_streaming_ctrl_mercury, .get_stream_config = mxl111sf_get_stream_config_mercury, @@ -1396,6 +1414,7 @@ static struct dvb_usb_device_properties mxl111sf_props_mercury_mh = { .i2c_algo = &mxl111sf_i2c_algo, .frontend_attach = mxl111sf_frontend_attach_mercury_mh, .tuner_attach = mxl111sf_attach_tuner, + .tuner_detach = mxl111sf_detach_tuner, .init = mxl111sf_init, .streaming_ctrl = mxl111sf_streaming_ctrl_mercury_mh, .get_stream_config = mxl111sf_get_stream_config_mercury_mh, -- 2.50.1 (Apple Git-155)