From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D2F03C65FD for ; Sun, 14 Jun 2026 16:58:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781456318; cv=none; b=LaozWku77NUb6SRbzsPphzK0yoRoliSrJYn82CqykSE+oEmZ68XnyxQ+OlG5lqDpyzyB5at9i5DlcGpDQjPGMOXkvvy+4KAqAfyzG4yKLKWT65FXt7yoD2GBxh8heV6fwW9pE8uukGKbAlDpTR4NKnMswK4zCk2YvN3N0OepyE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781456318; c=relaxed/simple; bh=pS9dj5hZWj+sq0xOxJ1yFaqbU1BUk5WejyxEfxd5tEQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=f0a+ctz0jXckTMhGmB+kdhHyTLkLZZ/jdZC1QQ62Mb3nwY6UWdxUfa8eqIfFe34SnC/3hIQESIEQPaenHb8e6+YTVZ4y4+UqtiKXX9tEGc6SfWyyuKWNiQ5MTp7tn9enLf/YZuQ67j0u47bU6WFIzH1qb4kGBWaz7Zm+/G8ud94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nDKr02sr; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nDKr02sr" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2c0c35980fdso26428305ad.2 for ; Sun, 14 Jun 2026 09:58:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781456316; x=1782061116; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YjNYRCBlo4UVyQJ3qh9HAQ451p2iR7Z90Yo8VcpsvLc=; b=nDKr02srQ97CT/nB+lnIA4RLsBghZFok84kA8o6sZveQFQs58jgnGbaw1gS3ZYiSzC TnLSNxWy3HEhvEBUt1spGklLetOGA7SAGXMpnLHy5pvSPeN9AUh2JnDXx3Ef+X4VK8vn HE81bqNzVKbE5MOFEI/CcKJ3RdBjoAn0RoQRMreGY6u352wLcPwr98e57bSNsGPwQHi5 EtmxNqTbHoDlLBl85q/1l3ViC1aHxvI+3LpOp5P6fe6p3k+PrMNnHKylPzKUASR1P+Fz PQu1mrFaa9JNi5WnNMvEcOP9WCZQjAffl1Pw/AMo5G5BYrV1g1My25YkCMjTcvoHFKoX tZeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781456316; x=1782061116; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YjNYRCBlo4UVyQJ3qh9HAQ451p2iR7Z90Yo8VcpsvLc=; b=f6cze/McQ8gbd0OImi+Qn5hINAYTcy54J47goYQoWeRxrf5ifPXeNq74lvj8tde9mW aGWpEL25349ywHKmmVhxmiKIdFm5LEnPMTA+1Es2FhPWVWYUJu4Iw6c0c7tWyuNXo+6U B2RiUxEhQo9cJPQMXc77jNXj5s28IE6VjJ7V1FKYPtBLkDO4VIZxRu0xjl4yuKNadiLt Cv9JwSw2Nq/oKjBjNr2JzjpO/NSl/MtXg8StB6AEyDZ8Gv4EjB9hfmqZMz4SxBz9vaFU Ci/FOkjudpbTjQwdF2zyJOQpyhbq+X8jY4L9oUoS9Ot5EopKTw/y8pZ49smReyaAUWeX x2wg== X-Forwarded-Encrypted: i=1; AFNElJ8hQhnj2Az+mVdfNK3YvR8hiEBJ2tR42YqdW4Cdyvc/9k+Az6qt9DATbRKZuuW+lRkI4/LRRNeXfSMUT/I=@vger.kernel.org X-Gm-Message-State: AOJu0YxFogVpVLGOYS21pNKKM+maKQPt8VS58IId/I1hJmlbKY7D0JPb H7YsSan8jzC5GRZZxNoVj4rNwR1b0Fn4WEGBKwz0zpaXqcUKYULBDewJ8fD/VLSA X-Gm-Gg: Acq92OEJDM+IKks9o8/9szYElfE/YmtbYkau7ITg9Y/2o72WOHYM/bdOwz6lTeazMfo MuykPE8Djg0SZCAs8/QzyvKGwKzc/H8gs/0+3XZM4AZarL0yTrG/cShsnjtVPRvR+kE6mwWh0Sa yk5wpf8gyrfTUZPkwe3UGYnC2tHUZONrxQ4qsNcowKMd8dlxnZKKkDjEVaaMVpGgONrSVKIBrX/ 5H1zgvf0VY6w40x8y0p1CqJbGBT04G3ELwPM96LSSxnV7HbdfY+P1rpTRGep/huBVPIjDHj6s0R RkLMcrZdMfmd275cz5qAqZUedLv4GC+yUupI51NpA8ES1M7WzhJe/lkj/9gAcNzRprGKnXGPwU1 K3VPEwn2F6z+gQM77fNxRRIeEBagDLbh99o+MtotIu6DjFqG+kDTPlJhIVrfAzg5q7fZU+XEG5J /v7a7xpeW/jtv0SsfzciDnA6FdZ5x7fLnkObNouo8kpefOKQ9qCAlL X-Received: by 2002:a17:903:b0e:b0:2c3:5683:9acb with SMTP id d9443c01a7336-2c412e2203emr116783605ad.32.1781456316580; Sun, 14 Jun 2026 09:58:36 -0700 (PDT) Received: from localhost.localdomain ([49.207.217.37]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42f2e5590sm85284025ad.14.2026.06.14.09.58.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 14 Jun 2026 09:58:36 -0700 (PDT) From: Biren Pandya To: linux-media@vger.kernel.org, mchehab@kernel.org Cc: Biren Pandya , Hans Verkuil , Bradford Love , linux-kernel@vger.kernel.org Subject: [PATCH 22/22] media: dvb-frontends: au8522_decoder: Add missing media_entity_cleanup() Date: Sun, 14 Jun 2026 22:25:59 +0530 Message-ID: <20260614165630.3896-23-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260614165630.3896-1-birenpandya@gmail.com> References: <20260614165630.3896-1-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The media_entity_pads_init() (or media_entity_init()) function initializes the media entity, but the driver forgets to call media_entity_cleanup() in the error paths and remove function. Add the missing calls to fix the API violation and prevent potential future memory leaks. Signed-off-by: Biren Pandya --- drivers/media/dvb-frontends/au8522_decoder.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/dvb-frontends/au8522_decoder.c b/drivers/media/dvb-frontends/au8522_decoder.c index 58b959b272c6..9df590603152 100644 --- a/drivers/media/dvb-frontends/au8522_decoder.c +++ b/drivers/media/dvb-frontends/au8522_decoder.c @@ -741,6 +741,7 @@ static int au8522_probe(struct i2c_client *client) if (hdl->error) { int err = hdl->error; + media_entity_cleanup(&sd->entity); v4l2_ctrl_handler_free(hdl); au8522_release_state(state); return err; @@ -764,6 +765,7 @@ static void au8522_remove(struct i2c_client *client) struct v4l2_subdev *sd = i2c_get_clientdata(client); v4l2_device_unregister_subdev(sd); v4l2_ctrl_handler_free(sd->ctrl_handler); + media_entity_cleanup(&sd->entity); au8522_release_state(to_state(sd)); } -- 2.50.1 (Apple Git-155)