From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD45E2EEE88 for ; Sun, 14 Jun 2026 16:56:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781456209; cv=none; b=Ma+5ngc2il0n2gnaPFoBp0Mlm9+a0VEkl6m9be9TE3bLOpu4Z0PoU6O87m/8e7gSec5ZSlu1fsdKOVSelKjrwegTmgVh6jGkRcip78U52hLyUxTly7mr2jpd8JNF+1uD1FFoBkcR7u9kx/5oZGg+7B5e2jkiYAQDqp5GkWJypGM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781456209; c=relaxed/simple; bh=DybZqMDvfeC0vf4wJRSP5Idx3cOjlKYAUoaViXsxfVM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Vph2Fo2D09cl3ChUgbDvnN5KFMmr3sF3KR85SqPdkUDSbyIli5aq1DMQuBk3MW1OE3i/+5tlE/MESWKPs6ILrkV0AdfnmYuekIlaZojIdJZ7kU7j8r1sain1EgFwaTSkPiAzH39FdcBEDmpGpVbbv7LBfuT9vCT+ACbb5map8Ik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IJhReToZ; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IJhReToZ" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2c31212104cso10172255ad.2 for ; Sun, 14 Jun 2026 09:56:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781456207; x=1782061007; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5xdBq7bfFoFs3H0cN+tvWvWnlbMmAQfwJXofXSw1uL8=; b=IJhReToZ6rjOF7AsmVuoHZf50cEbLIrG4PP87krKUTuaff6ejD+zfZwJE3JrpOZ096 NJQMXzhp73pUUA8vD/7Gvf2dNk8oCH06gYdQERrEAKw15nqCf/VZUqO6sLLAUyRiPNzA uKOwvmLoqetP8T2Exu3LvFNAEv2VfdKa7m66WSFq+ehTk57WGwzOnqI1bZQPYy2R9Dkb MfJhEzq6MYzAjruWUb004gBKiM7PfM7IjE2viNJX7iL1axYZN9CWeTtN8+V49SKH88GO 3twfkgB+HFaCMCYFFQGzNxAhqrCC3A44pmoOdHOBW+s/yO/qnUiP5Bb6ISWOMV0lyvVB kbGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781456207; x=1782061007; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5xdBq7bfFoFs3H0cN+tvWvWnlbMmAQfwJXofXSw1uL8=; b=fxv/BdKbVKHTENF2qPQAH7HHHTN/RR7CT/PPuYQNw1kzW1teqLI/uz+4hAcuKcqAIl xGQyAs68bPgpmSJSFF3jK53iJMLCLPoAr/gamV/Ztytb/LQ2I00pSiGCqnSdWOcwdOmq ORtQmxbeDLJkdvdIXB+mUZIkpc9gs8VZSXP1UqQwA++XtVQeYBxF1E+hLAKxqQDwI3GF ZtJYIU4oVqhZ+eyoL17dx7pJa+Qfi/Lb+Zh9gtDhl7ve5zrw8CYfhbVpYFmiXfXxAyZd k8ybrOxRsRbkiHjr9aLdmySRfe8NWGVXbwm/zMMg3XJC5hEdob2y3xQ0PRFucO6DotWi 1a+A== X-Forwarded-Encrypted: i=1; AFNElJ9IJFzPfkWQLaFWYX+7/1xCOx/ASN/bq/o6+Atr97adQHdwdlGPhfa9g9geuCnVwqSHbkPkiCgn2DcKNuc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw985nAHhaU18dlyusAk/KAX1K87AanVwqAaKMfdG4jT5atS9qQ vDHwCUvovSDUvjlKLflbyiaKL7AI9C6XaDBJNcUFS7+spQ48c+ixE+cr X-Gm-Gg: Acq92OFoYvRaxZxt1BKka2Mf68R2AwwRM7yY2FicTbUCsX0XgDPjW0RFwnkgZY8Y6PT Jdns5tSmyz4KEiz1J6NOc4GdrvEbzc3G6LdwlehgAW38VBSVzCnJiZ9noW190HBbLAfax08sx5p rNdr4MStFFzpA/u/iy2j1nLKNJviPg0PZo+C4Z3ZBbt7Hb4l7hTqRbueA1gsUDXObvea8bI8r+Z LNGTFRfD/egpcEW2aA+Dot27QcCCacD51xXXiHq4t6bOEu3UGijz448djOFjpEa0veNVfI7qFM0 MMCn49HpGa/71yXL+kImQBdAbQ++KJ0tt1Ix+6n1nKdKhFqtrNHdO3LLGwU+28qOq59VIvMuvlr 7VWsoMw7seEyttGtY34jUAUy9jHdK/EGdHh0ZLzbh1HEagFIaaYwkejn278BssYjCbPjWG8NxZG SHDcnyTfHlDyEVrEascs67hN7cEPlVpSkoAy8W4cMbrvqhJK+92yWJ X-Received: by 2002:a17:903:32c3:b0:2c4:397:b77f with SMTP id d9443c01a7336-2c664271a10mr86213895ad.18.1781456207188; Sun, 14 Jun 2026 09:56:47 -0700 (PDT) Received: from localhost.localdomain ([49.207.217.37]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42f2e5590sm85284025ad.14.2026.06.14.09.56.43 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 14 Jun 2026 09:56:46 -0700 (PDT) From: Biren Pandya To: linux-media@vger.kernel.org, mchehab@kernel.org Cc: Biren Pandya , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Sakari Ailus , linux-kernel@vger.kernel.org Subject: [PATCH 02/22] media: i2c: max9286: Add missing media_entity_cleanup() Date: Sun, 14 Jun 2026 22:25:39 +0530 Message-ID: <20260614165630.3896-3-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260614165630.3896-1-birenpandya@gmail.com> References: <20260614165630.3896-1-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The media_entity_pads_init() function initializes the media entity, but the driver forgets to call media_entity_cleanup() in the error paths and remove function. Add the missing calls to fix the API violation and prevent potential future memory leaks. Fixes: 66d8c9d2422d ("media: i2c: Add MAX9286 driver") Signed-off-by: Biren Pandya --- drivers/media/i2c/max9286.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index ac0712ce1e65..31598fa34c6c 100644 --- a/drivers/media/i2c/max9286.c +++ b/drivers/media/i2c/max9286.c @@ -1062,7 +1062,7 @@ static int max9286_v4l2_register(struct max9286_priv *priv) priv->sd.state_lock = priv->ctrls.lock; ret = v4l2_subdev_init_finalize(&priv->sd); if (ret) - goto err_async; + goto err_entity; ret = v4l2_async_register_subdev(&priv->sd); if (ret < 0) { @@ -1074,6 +1074,8 @@ static int max9286_v4l2_register(struct max9286_priv *priv) err_subdev: v4l2_subdev_cleanup(&priv->sd); +err_entity: + media_entity_cleanup(&priv->sd.entity); err_async: v4l2_ctrl_handler_free(&priv->ctrls); max9286_v4l2_notifier_unregister(priv); @@ -1087,6 +1089,7 @@ static void max9286_v4l2_unregister(struct max9286_priv *priv) v4l2_ctrl_handler_free(&priv->ctrls); v4l2_async_unregister_subdev(&priv->sd); max9286_v4l2_notifier_unregister(priv); + media_entity_cleanup(&priv->sd.entity); } /* ----------------------------------------------------------------------------- -- 2.50.1 (Apple Git-155)