From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 005AB32F748 for ; Sun, 14 Jun 2026 16:57:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781456223; cv=none; b=tB9At+tzdy0tdDiZey7vFj/A1lhdv4IgNAMLn2oVGDtIMDMG613cnV9dHjV52bLeJAU7tfp1dDLdAHPqgi2fEYti4RR1VpJ7ItEYxu++lOY58wFdgLtlCgF1YNQB0krP7P1TUkIAU9bcOxUWRJw2WPQpPRH05xXxRzXuzmj+B7E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781456223; c=relaxed/simple; bh=UWqmPBb9lYmUHte5jzGL4bwmzok/E1L2sfK+HjXsU80=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YqPa0xpXvFEqDCdsJKZIVfPQK2FCFuSV6UKESIfdSEUWotXYoeXmkP5GnA/56mRzqebq+3wYIC79D6P0HvGnb7qnP3Hnmk6z4JzwWLuKD3gVlYRec0nGNrmV++9pvJPopJlf7CLQR0KFsPKpLBWn51L8qUMwf1g2IuGcaID3ik0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rDdPM4PE; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rDdPM4PE" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2bf237e1433so30948665ad.1 for ; Sun, 14 Jun 2026 09:57:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781456221; x=1782061021; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ywqQuCxykmaaSjgy3GzHJjbLWrbgi091EGla2oDbBMo=; b=rDdPM4PEJF2nVcp3NLE+98PBP6hkKfd8d/kmeZfiBZePc/ToBN8WbHczLQKNccX7UE cyDK5mb6XUnvFU1eImR95Z5/SQjF4KtlaMt+A0sb2OQHrqC9ZJXzCAujXQbAIfHy7+zf 9KIWE1SptK/unCZZ/p8c4YZPztFXdIa1BSmlEFKTblaQkP40mavjp5JkM6EJ78ATDGxm BKpIEPT8emsMtbs7nYhuz9KMZ9Sk+1vw/BRWZWBHTDxcw+B0SRTB49KL3g9fPu6p/ZVZ qSsHe0WnKlsp1c0EMakYaTtgamu9Bu8C7tITyH/r6EEg0miriFq2fGasATM5pOtAGSmO DTtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781456221; x=1782061021; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ywqQuCxykmaaSjgy3GzHJjbLWrbgi091EGla2oDbBMo=; b=pHegrz7zuVhobpic1p3JL0kaJga39i8umhLDxZRvy7vGFuILeFf7gPqcJmUqMvALk5 nkhqV/KU/PFL/ubQE5XEcVTFVJDteaLCynjpvlDbybg3lB/hFF5vSfg3wZT+kQppXTS5 e8M178FMK47GgGBj7SJxmmndL5qodkbnd0E32kVe5Xp799W/t9k5f3q1w8BxaUFuZdfH mhIEF1RvCw1Y+5oig7bLpyOalxqHDCCWvPqrrTkPa1AFE2aupkdRkPiOXwqSH/lyO/lz e4aBjctlldtIXAIjudX2XRuvkvbtbtnIq1KOk0Qtr/Mn+vQebNolPltSjtYCMAGAWF5+ EnWw== X-Forwarded-Encrypted: i=1; AFNElJ+mpDhhala/+tdu5Z8FSzFNput1fuz6q5hBofSoM5q34SN0jCulDI6ew3ldFnkuNnNcsHXZG9pc782mqCI=@vger.kernel.org X-Gm-Message-State: AOJu0YxwolFg3ULgbBAPzWYw3mMCgGIcWZUsSwqpkgsyssWjnZoIiGb9 UJVz+uQ5SghKNPuvKmR+kBCJu8twOa1EQXQRBF9AE4nQDNdO4NIK5jqj X-Gm-Gg: Acq92OFJmNTjn0pbMPoqeXGl3sC7dgK9++OyEfELireqw6cljUvlStZMKP6NpBMHmMY b5s6FaCxte55zJ/4aQ+78ZhWVPLLF7gNMQkCH/BUi+1RXVS2fwTsqF2pM4HT+iZu096+aIFK8+g ivz2MgiyGMnUDj6fysJZXks64NWTuxmVDElmILbLSC8CvKaXA4h4mLd5QZfJlgI35lnk17U0N0H c5wQ6VCZHYTjgFNIEJtI5Lae5WyQWWtv1OM8fKHOo6iQzWDAZUMeMH21HMQtKNVl/kISg/e1+pl 4pBRCXGKGIgYhKGKbWMB6XGgmh1kt9Usp7kVqu0QUg7i76EEgBk/YZb90zAOaI2FdZKXnxmR+CD Q1BZZLM5FYJWha2lVDQiNnbUSZ8e70oDnkeB+FeP04/83w0hZi9TztKmZ4YTbdctTBi2wgEGtR0 j57JNb+HrZPY3RHuWiPAa2RqrimmkQG0apGjzdS+/Ucnq+oo1zRF35 X-Received: by 2002:a17:902:ea07:b0:2c0:d91d:c3e8 with SMTP id d9443c01a7336-2c41050b2aamr127165705ad.4.1781456221413; Sun, 14 Jun 2026 09:57:01 -0700 (PDT) Received: from localhost.localdomain ([49.207.217.37]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42f2e5590sm85284025ad.14.2026.06.14.09.56.58 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 14 Jun 2026 09:57:01 -0700 (PDT) From: Biren Pandya To: linux-media@vger.kernel.org, mchehab@kernel.org Cc: Biren Pandya , Hans Verkuil , Yu-Chun Lin , Kuan-Wei Chiu , linux-kernel@vger.kernel.org Subject: [PATCH 05/22] media: i2c: saa7115: Add missing media_entity_cleanup() Date: Sun, 14 Jun 2026 22:25:42 +0530 Message-ID: <20260614165630.3896-6-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260614165630.3896-1-birenpandya@gmail.com> References: <20260614165630.3896-1-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The media_entity_pads_init() function initializes the media entity, but the driver forgets to call media_entity_cleanup() in the error paths and remove function. Add the missing calls to fix the API violation and prevent potential future memory leaks. Signed-off-by: Biren Pandya --- drivers/media/i2c/saa7115.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/i2c/saa7115.c b/drivers/media/i2c/saa7115.c index 48d6730d9271..64adfff3001b 100644 --- a/drivers/media/i2c/saa7115.c +++ b/drivers/media/i2c/saa7115.c @@ -1867,6 +1867,7 @@ static int saa711x_probe(struct i2c_client *client) int err = hdl->error; v4l2_ctrl_handler_free(hdl); + media_entity_cleanup(&sd->entity); return err; } v4l2_ctrl_auto_cluster(2, &state->agc, 0, true); @@ -1925,6 +1926,7 @@ static void saa711x_remove(struct i2c_client *client) v4l2_device_unregister_subdev(sd); v4l2_ctrl_handler_free(sd->ctrl_handler); + media_entity_cleanup(&sd->entity); } static const struct i2c_device_id saa711x_id[] = { -- 2.50.1 (Apple Git-155)