From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C562037C0EB for ; Sun, 14 Jun 2026 16:57:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781456232; cv=none; b=Hizg2CXXvV/FTa4hWbJw+SDPaNz3sBro/Dv2lDbpAV20lWqHkiiRR/pr+/61I9JW/0rRSfP9xd8xWWKg/krtbqjtvOfYcL6qjnlZxU3X7qkqYU4bh27QgVR/NoS2ub+QTjP9hOfUBS2mkZkeG51rlPAzBJER8LyO32Ays1jrcLk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781456232; c=relaxed/simple; bh=7Zhy1mQVW1t/ztSSKPcZqS28xrO83pxbCfwKTPiB0+Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=h/4O8HTa5NNpEMZbNgHH05FsSjKg9QUx67KTZsY4VDp4LSQESLG0LZhLPpbZXr441zr1ELjJzrrW//OzXFR+jgMl7kSr3Z+cuaMj+UFaoFTUmpNThlrLUUNt9lqD+1s2voUNZuOfBbASqzzRdx/NdqGaE5YwLMZnybi47JWkxvg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mk+I8DM6; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mk+I8DM6" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2c0c32f6ce1so16998445ad.2 for ; Sun, 14 Jun 2026 09:57:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781456231; x=1782061031; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QY5Ip+P8KRx1IM1Wpd7OwQvhD0XfR0winv2zlXLefIQ=; b=mk+I8DM6N2IKFe4xk65j87NGJ0QYZWbuXvR7BuxsFG+ZSmpm7Dy59JeecLyRn7PQu4 LKzIi3LFNnUHNrmtiJY28PB1fdd77n54GGkhr/geu9Y0/6hvJi036PkatP+mKy+rI9o1 1m44ml0p0UR3PTSp2bLwasworeuauvMJoxGNK9Oi+tRh2rWspg3oN1+vcqdvp3X/UZA8 wO1c0Sh43djia9e6c5IbjYFVYBP3vUX9XRbiogsKzTYYm6z9MEXIEZKYcap5otQHs9y0 1BFqaesx/fey6LQo5vTFGA4ZzRBDq3kmIGQfIwfrP1nt9mpvnydQZXRY7HpH5H1H0ufG nkGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781456231; x=1782061031; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QY5Ip+P8KRx1IM1Wpd7OwQvhD0XfR0winv2zlXLefIQ=; b=NtUeV0d9bQVQ3eSEB20CDYYU2SIytkDB8heJllUK86d77wfA4tOOuxSRFB0PvafjZ/ i6dzcc1amwu20lYnlNEy+0Qs3a1rTsfshh7gB+kQfDgtt4nSC2o7MAT6xEtmYRg7V/nU bn/qiDY9FMh+rvDd8Ok0Q4AT5VwNF1mr2V2sJCOYEwYl4L/k/dDrdnggP80N3MG9vrFM nuGHRQCLvQWttsu43ywjHFvqqclxXKOoAFy9XWjmrBSRcuBzRvRLe6QEF0NRnRU7Rx0Z 6vOdEuryP9o8Sn/1Juby3HaaiHZwOEh+oz2+qaxM9Eh0K1ihbcZFOkpJFAzd8U/5xBux fa8w== X-Forwarded-Encrypted: i=1; AFNElJ8stmy2beiSY+tXRaa8gJ45u/MwdrZi5bFlcpcjG9tS0ZZZA84Dvpu4+7kum9ZijUORlZ/C1oKktUMZNos=@vger.kernel.org X-Gm-Message-State: AOJu0YwxdVWqTi4pph6ZGuIEW0QzUiAt68nx8j5yT5kZaMhruWhu+W4A sDxiH1giebdnJwc5p3VKGl092L27LLS02FJQ99yy4qgxhsQ1+5f3mOMU X-Gm-Gg: Acq92OEgMVOj7SgysHxMuLbQjB1KwnqcfQp47PbBXrpwuku4kNYj7PEhrH8oapxxEGG Sil/vjl+tVEuzxgOtVvf1aes6e9eDZoww8/fUbOcoRXhhkJAtc8SZRhJMUjgdCOljpzay0sC3kU jS+BHSnhJqW3wh8qtuH/HCQzUyIZdEf08yIChw5OuKNGRu0XQi2msMEhgwaxARNar3zPq06JieX +9iNeHtBxLzZDA2wGc5JjLbL2ZsUUjtZKXOvEgLCq47dzA3mccCzAEP4z/aGkFhHNBj9eFJXBSn w7bOtrg0TxmhFkPhs8cP5+qEUrlOJCRXvX9qUF1BwOTQZGXN+kAhtJzPALC9lR4hi89gvVv2yXW DrQ6sVno2TZMQsZI1626zzkXk7rKHH6Mk74N9FMXXkbIGPeZ9xnsGOnUIX6T/v7AJJYh6SPSXVr L8gVGEIgqZ0E6G6LU0wkiWYC9qnw3Z2cdAEWq83XSN4SdPh4ELufWxYn5ty8z+U1c= X-Received: by 2002:a17:902:d48f:b0:2c2:1982:5270 with SMTP id d9443c01a7336-2c6641e28f9mr86805045ad.21.1781456231128; Sun, 14 Jun 2026 09:57:11 -0700 (PDT) Received: from localhost.localdomain ([49.207.217.37]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42f2e5590sm85284025ad.14.2026.06.14.09.57.06 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 14 Jun 2026 09:57:10 -0700 (PDT) From: Biren Pandya To: linux-media@vger.kernel.org, mchehab@kernel.org Cc: Biren Pandya , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 07/22] media: platform: sun4i_csi: Add missing media_entity_cleanup() Date: Sun, 14 Jun 2026 22:25:44 +0530 Message-ID: <20260614165630.3896-8-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260614165630.3896-1-birenpandya@gmail.com> References: <20260614165630.3896-1-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fixes: 577bbf23b758 ("media: sunxi: Add A10 CSI driver") Signed-off-by: Biren Pandya --- drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c b/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c index e53a07b770b7..f50d97ca795f 100644 --- a/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c +++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c @@ -242,11 +242,11 @@ static int sun4i_csi_probe(struct platform_device *pdev) vdev->entity.ops = &sun4i_csi_video_entity_ops; ret = media_entity_pads_init(&vdev->entity, 1, &csi->vdev_pad); if (ret < 0) - return ret; + goto err_clean_subdev_entity; ret = sun4i_csi_dma_register(csi, irq); if (ret) - goto err_clean_pad; + goto err_clean_vdev_entity; ret = sun4i_csi_notifier_init(csi); if (ret) @@ -266,6 +266,10 @@ static int sun4i_csi_probe(struct platform_device *pdev) media_device_unregister(&csi->mdev); sun4i_csi_dma_unregister(csi); +err_clean_vdev_entity: + media_entity_cleanup(&vdev->entity); +err_clean_subdev_entity: + media_entity_cleanup(&subdev->entity); err_clean_pad: media_device_cleanup(&csi->mdev); @@ -282,6 +286,8 @@ static void sun4i_csi_remove(struct platform_device *pdev) vb2_video_unregister_device(&csi->vdev); media_device_unregister(&csi->mdev); sun4i_csi_dma_unregister(csi); + media_entity_cleanup(&csi->subdev.entity); + media_entity_cleanup(&csi->vdev.entity); media_device_cleanup(&csi->mdev); } -- 2.50.1 (Apple Git-155)