From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBE862EEE88 for ; Sun, 14 Jun 2026 16:57:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781456236; cv=none; b=Lp3s7KlkIRuDaJDWpMzp4x8QopvhuUBay3bCObGjnUkMjI2T5lvDaiSA4nds1HHDxpGpqj5WkxPhym/UlpAhqNPvLMgl6H2u35Uk0a+CRk1+h8DKL2XUe40sKmRLJcRdzqJa+ZAQqy8u97ENH5m2NjjgiJ65l7FvxIOkb+AY3O0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781456236; c=relaxed/simple; bh=aMgBCX8axpR/xGo2NX1aRg3kBHTbAUgdP8AE16JCLng=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uk3scAA1LMFwAuMFrKnHWRlicE/h1a3C15rQ8R9xA4DzfEd4Vn5ggKe6Xj9JgqK6L3MULC2Q4Fzkfcn4iSUw3YTFB39OmwrwBMi/7PutpCOLTHUJfbWTaBmAKyVeOq6wITcXdrofL4tb9rlxEsQKpuzV0+VniQxoTNht5PJqHZ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=muskLpMg; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="muskLpMg" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2bf0ddaf50fso14425335ad.1 for ; Sun, 14 Jun 2026 09:57:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781456235; x=1782061035; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F116xATG0sy6t8QTRcaXDWApsr128oHT/pRvAL50PTs=; b=muskLpMgRo+iMp1TX5O/vGTtyRsyyR6k8Xrhe6LjXsJLypXqJDfMWzAnhlS3cf+jAW 4hiKWCvsmxlpSk3ElmG2kwOYp4k7irvtbuAxRQQQxA5L9wm0DeAig+5zpfkGoUJFoags tiVEt/y/ZaaQGTyETWtDRuY6RE+rpJGrMzVJOLJchLM85PUUxwAfYkZ7SHhIwekSHWTf ZSwYYMroEL+nrW6zWjazehY0owYt8tFS+inwPBx4JWS8uudlPiQZfItRQe2Z70Q5tXaJ UBFzk5PJ8SZkN8R/eXXgLY/tjt1kLzkDnIm3MRqlX6YlX+E4vbjbPMgYrlFOEunmIlzo 7Ohw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781456235; x=1782061035; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=F116xATG0sy6t8QTRcaXDWApsr128oHT/pRvAL50PTs=; b=bQBfJQgHPmsnmRxwjOPsV21iUo1efJTq7asNywq0LWJ2AzMZCO3yaO3YDwHo0OS7Bp HXF5xCjrPsyqR1P95+rcC6Mfa6j/ntaf8tR4ei1oFdG5XnOX6mXAJkG/OeRm92OIOpIH nwPUBNxQxRCnwVlzbzPs+dA4TABCjummn4u62wT1l2H15PWYo0xYOQZn8WriHdJBSYLu 6q7Lq5v52pDvdwkamjO8x16zrr7cGLoB8gCGpwE2MgPxmzIBywdqn/s+T2MRYyRRDgVL ttkhRGQQZWWtMUtyuN21HUUQlAXXk7Ur23Z9qn+LTlz9LME85gtJ0cURzJxiJDExFbf2 H91w== X-Forwarded-Encrypted: i=1; AFNElJ+A0XaSWpQ7r480TGHjDFqQ/l9GDRUqdWAGYagrlKSPpy+W+PdHEC19wHenXkqbQe+1v0ruSj+VA5bwGyw=@vger.kernel.org X-Gm-Message-State: AOJu0YwAsYiTz7o4gvJZ8YVpQpPAOT02KqDjU96hQI3lsBVXe5scMI8W bgrFRKrbTK/cZLli5xD/BsO3PaQZiJkMAF8NcNaJ0KJAI8eXEFbseWr1VfDc9KAk X-Gm-Gg: Acq92OG6CXuqT3RP1ZyUwuSZuyJ0sz8IZ8tixpAdCZWzjcDeezZG8fPcc+W0MEtn2g9 6iin+VCDitt7VhYlJB/DVpjgrfT5XsLxkuIRx+mNwinzjXgvnScR2PxeeagMN72kGul0rhpksfB nx4V7FdItNjRiKq6UNf+xa+dI/Sov//AcCAwWYdJtWYiD0VspCJBeDHq4vgtqdrWJjA7AFUXPga J7oVyDzhCmX77qroGdO/M+XStJ+J86dYKJJIoz9PJPvS7MdFlRmMCxKuFCA9Ex5I5OYdKhzNpJB 0S6/9s7XAOQKj/WpdiSl7w6FF0FWf/ZxQcGNvRjDLhgE2TS9sB0+AK2/lgNxmYfN2U5jWP/lhvf 2vaIDtb70gFZahdn4g7ZdL5fWC+sTm64CmBKCyCnOPb0ZrVEIewPy6wSp8WeVMAZG74aH0xQXUH aHejLiZG6uKR5kx56SwQCnCi5GiQn4TXCk8esae6DUPGDFuk67tu4Z X-Received: by 2002:a17:902:ea04:b0:2c2:8659:da44 with SMTP id d9443c01a7336-2c6642355a3mr83616405ad.36.1781456235067; Sun, 14 Jun 2026 09:57:15 -0700 (PDT) Received: from localhost.localdomain ([49.207.217.37]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42f2e5590sm85284025ad.14.2026.06.14.09.57.11 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 14 Jun 2026 09:57:14 -0700 (PDT) From: Biren Pandya To: linux-media@vger.kernel.org, mchehab@kernel.org Cc: Biren Pandya , Eugen Hristev , Hans Verkuil , Jacopo Mondi , linux-kernel@vger.kernel.org Subject: [PATCH 08/22] media: platform: microchip-isc-scaler: Add missing media_entity_cleanup() Date: Sun, 14 Jun 2026 22:25:45 +0530 Message-ID: <20260614165630.3896-9-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260614165630.3896-1-birenpandya@gmail.com> References: <20260614165630.3896-1-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fixes: 920b2665f392 ("media: microchip: microchip-isc: prepare for media controller support") Signed-off-by: Biren Pandya --- drivers/media/platform/microchip/microchip-isc-scaler.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/platform/microchip/microchip-isc-scaler.c b/drivers/media/platform/microchip/microchip-isc-scaler.c index e83463543e21..c368c66d9c8b 100644 --- a/drivers/media/platform/microchip/microchip-isc-scaler.c +++ b/drivers/media/platform/microchip/microchip-isc-scaler.c @@ -222,6 +222,7 @@ int isc_scaler_init(struct isc_device *isc) ret = v4l2_device_register_subdev(&isc->v4l2_dev, &isc->scaler_sd); if (ret < 0) { dev_err(isc->dev, "scaler sd failed to register subdev\n"); + media_entity_cleanup(&isc->scaler_sd.entity); return ret; } @@ -229,6 +230,12 @@ int isc_scaler_init(struct isc_device *isc) } EXPORT_SYMBOL_GPL(isc_scaler_init); +void isc_scaler_unregister(struct isc_device *isc) +{ + media_entity_cleanup(&isc->scaler_sd.entity); +} +EXPORT_SYMBOL_GPL(isc_scaler_unregister); + int isc_scaler_link(struct isc_device *isc) { int ret; -- 2.50.1 (Apple Git-155) drivers/media/platform/microchip/microchip-isc-base.c | 1 + drivers/media/platform/microchip/microchip-isc.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/media/platform/microchip/microchip-isc-base.c b/drivers/media/platform/microchip/microchip-isc-base.c index a7cdc743fda7..27e180aff9a2 100644 --- a/drivers/media/platform/microchip/microchip-isc-base.c +++ b/drivers/media/platform/microchip/microchip-isc-base.c @@ -1949,6 +1949,7 @@ EXPORT_SYMBOL_GPL(isc_mc_init); void isc_mc_cleanup(struct isc_device *isc) { + isc_scaler_unregister(isc); media_entity_cleanup(&isc->video_dev.entity); media_device_cleanup(&isc->mdev); } diff --git a/drivers/media/platform/microchip/microchip-isc.h b/drivers/media/platform/microchip/microchip-isc.h index ad4e98a1dd8f..40a54d7d7e10 100644 --- a/drivers/media/platform/microchip/microchip-isc.h +++ b/drivers/media/platform/microchip/microchip-isc.h @@ -392,6 +392,7 @@ void microchip_isc_clk_cleanup(struct isc_device *isc); int isc_scaler_link(struct isc_device *isc); int isc_scaler_init(struct isc_device *isc); +void isc_scaler_unregister(struct isc_device *isc); int isc_mc_init(struct isc_device *isc, u32 ver); void isc_mc_cleanup(struct isc_device *isc); -- 2.50.1 (Apple Git-155)