From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f67.google.com (mail-dl1-f67.google.com [74.125.82.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F52A3A16AE for ; Sun, 14 Jun 2026 18:23:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781461406; cv=none; b=hHdpNkDbLQRmp6oXs1kE+Hk69UE0byLChKCrn2eIuQlMf3M3HWXNnOeaHboM+dvT8/RsSY6QR58WXRnuLgCqFyq6ioeYAmPFuDQ0P36blAgTdnNdF2Tw2wNponk/BvHMHJqzt4k1WaDbAXazIuJTRtn4DmFYfnOyH0VBKXu8EuU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781461406; c=relaxed/simple; bh=cQn4PXZvm0puKI16yFkqmjN3UyGMyADSB2yG8uSRgXU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sgpQ3cMvHZle69vY0kljQoc444JHI52oBZPErFoNIxg4/7fugnLMYUcyYseEtoh3tuTBxqLqkWYVMmvM8PHx5dceJNZd1ePlsXAjWqw2r2S9wnujEutmcMiBKkldV1XmaJaaojCykVJRnihuHeKoSAbRLDxJVdaJt2JfRvP/pZ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rockUD2V; arc=none smtp.client-ip=74.125.82.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rockUD2V" Received: by mail-dl1-f67.google.com with SMTP id a92af1059eb24-138501f8c04so954889c88.1 for ; Sun, 14 Jun 2026 11:23:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781461405; x=1782066205; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ynbuYtZbl2tj5aCq3jJaHb3txV79wERnqMqRqWhD+bo=; b=rockUD2VmcW/AnGttEa2q7sqXPP7aam8oM+4hmUgBgk9OxZxQ0VvZcOHo048NKmDW0 b7LVHDGqiA43XHL4VCGYQXuGb4gflBc5UumoH5ThAdvM/emtR/IFOzwzObJ9LLpe9g9v FOia2Zf2ci4LcjtzLILiNUKIF0yg0DBTcoWR+Mw+Y8kHrgvGIcNGAJBfkdd8tmyu985V BpumcJGmXV2upVd3bAwHqNmH21cuAfEtZe2SiruHZOwNI8ttXxRuOCxPif0HYjhCunQ7 WtZpuMxTmYEbR/HZ8yYu87Ok+/m+32mnTGgNAfaOvqKkF7RU2eTqPcLs/j/9sp1O/Bi7 IEYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781461405; x=1782066205; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ynbuYtZbl2tj5aCq3jJaHb3txV79wERnqMqRqWhD+bo=; b=k3SHSEttNcPXK19KvYA3PhLR2rF6PViu23GARr8XPSvS6HZ/Ye9qvYn4P7LASj+qEp ynOZ1/7imCB1SczQpmBYLOq9a1j9p1GCKofKqOnF4yEjm6dpvlhWDslsbvLDvKxKgcQz O4hLhShEG6hBU2zf/DxUcMNBNVnilcQuHNHuEkyqBYaB5jGD1GCdEyb+4Olt+rl2MxCU iIAj8qMlI5qlWtr2v6rvKbeRec84e6jYhHq2IOwRnAi3GMjFh1tMjy81nqLJ4mz/TCM0 bUGq4HOR2tb6oB2H7i/z1paog6nC1LHtIWoXZRElOBoOErUOC6dDeXokX116dAo+6NCv bsVg== X-Forwarded-Encrypted: i=1; AFNElJ916W3esPPheah/eAChf8N+ugNxOlFyxyD9hxg3OCECnHwAYqTUZwpukK/E4FbIFr0w8gHv4EHh6qVpHpY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0CM2pNGq9h/WQYEJ7ML517mkhGB8qNxSSfliBKTtW2m/Hq5yd lvh/TNnkSfoLbuYGZTflZxBwyPSQzEwXdOsNi2QwnMGlySszSNqPK5YD X-Gm-Gg: Acq92OGYGf0zYdBWCIhAdP0NBf6tm8As3pzHOWKzTaIXhcHbQBIYjDs8+Qz9qJOppqk E11woJU7s8qKNtS8UrsfVWedoFTQbEXDyCBRe3ufzbdUfhBD5kx+yYnty1YOAystWGn+kDdWBIN 3obk0mOtHfcDtFrz9ULMbJKh5lPPeJoSw7V2hAflUilTnpecy0hf+3FpSBJehqklaYE9regpWoC /FrhWkrOYuOiv0JuBKbhJk2GmGo257WTE+dg4ahiKRlrqLaYw5uuLnvAnMjOkKF6BvlMj3tfQzT pLxof39A+3IWJlv9aqDjF1eBli0EZhEIEbs32aVfdcIiCAEI5t28rp1tk0OFVMfqN9k59hhiEJU g7KDRvRuV+zvmur3hzMHkbmiqo1FUL3Nu+v2u3zAFUrJCEhjI9O8b4ndCMA57tdDN9SniZXHXkN eZKe6fR5Mat2rkO0PBDfimu+GmAkMFUQsHvUS2VfFVtdzWkIb9m8OV/LY= X-Received: by 2002:a05:7022:4593:b0:136:da48:5edd with SMTP id a92af1059eb24-1386f24085dmr3757907c88.4.1781461404512; Sun, 14 Jun 2026 11:23:24 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1384b975e55sm8435022c88.13.2026.06.14.11.23.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jun 2026 11:23:24 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: error27@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 3/4] staging: rtl8723bs: convert update_attrib_sec_info to return errno Date: Sun, 14 Jun 2026 18:23:08 +0000 Message-Id: <20260614182309.96110-4-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260614182309.96110-1-dennylin0707@gmail.com> References: <20260614182309.96110-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert update_attrib_sec_info() to return 0 on success and a negative errno on failure. Update update_attrib() to propagate the returned error code. No functional change intended. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 7d10caf8cbfe..b6d9332958f5 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -519,7 +519,7 @@ static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *p pattrib->encrypt = 0; if ((pattrib->ether_type != 0x888e) && !check_fwstate(pmlmepriv, WIFI_MP_STATE)) - return _FAIL; + return -EINVAL; } else { GET_ENCRY_ALGO(psecuritypriv, psta, pattrib->encrypt, bmcast); @@ -558,7 +558,7 @@ static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *p pattrib->icv_len = 4; if (psecuritypriv->busetkipkey == _FAIL) - return _FAIL; + return -EINVAL; if (bmcast) TKIP_IV(pattrib->iv, psta->dot11txpn, pattrib->key_idx); @@ -596,7 +596,7 @@ static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *p else pattrib->bswenc = false; - return _SUCCESS; + return 0; } u8 qos_acm(u8 acm_mask, u8 priority) @@ -754,9 +754,10 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p return _FAIL; spin_lock_bh(&psta->lock); - if (update_attrib_sec_info(padapter, pattrib, psta) == _FAIL) { + ret = update_attrib_sec_info(padapter, pattrib, psta); + if (ret) { spin_unlock_bh(&psta->lock); - return _FAIL; + return ret; } update_attrib_phy_info(padapter, pattrib, psta); -- 2.34.1