From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f68.google.com (mail-dl1-f68.google.com [74.125.82.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C77AD3C4B99 for ; Sun, 14 Jun 2026 18:23:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781461407; cv=none; b=KLTQLMEeIT3iqlo+4IFFWnTK1BXz+PehKKfsqZnpKlqbs0+c4cVBShKKyARXVGfGVSLMuxCVEYbes56DbcDaFjlcwlo1Ml/S+kWXN1ma1bAqiBY2bjPGamkAv0tLMu9tXnpyGH3wKTE9nTuH0UrVISgsDEvY63lC50eJOQDKXuY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781461407; c=relaxed/simple; bh=UCLz7dINh1lgMYFDoeDTmd+Nq3hyT974aet2XBucKj8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DvaLH1W5hkK+7WhIQOEvGjtW66U6p2lzGDybJxX6BGEhJMrtqMao7wKiFwx5nZWhVAamISf/Died5Jjxct42FTaDZORg60yv6NMkpr9Fd68Lcl/oKCKruy5LDXJq1Vbknmw1VTvuAVikE9pKCcc9y1N/km8bInwmAQ+ogE6K0jk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U8S7NRON; arc=none smtp.client-ip=74.125.82.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U8S7NRON" Received: by mail-dl1-f68.google.com with SMTP id a92af1059eb24-137d464c47eso2024356c88.1 for ; Sun, 14 Jun 2026 11:23:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781461406; x=1782066206; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ufi8jS0Gv9HR4sYoAY6vKqLESkvd7ZmAPRv56V3pxB8=; b=U8S7NRONw86KHHl71BAN0IhvYSknsAzbQvzE/0E/nx+vKvBdRvkK76Y3MWByUiLwj6 y5qNKUx6PQsHjW/k+ZSSIAtOUoWU3AMp4H3FYfHywfLRud+s5jl4ObdrYDYYA1IDeff0 BmSclvwiqgbaMvorkLx0lgOEBnEVOsf4TKsiiRISBvXGDQSBDXL6t1Y0mJnNdRCz3f10 zmH6nHiDeF6I+7eDsfAAQFM+Nll9hlTzlW64Jnc6xaDfsKQwrFz2gkVmg0xIxpr7AlvM B5jlLbykpFglQuhxXXQ6vpg4fq5tiXyJfboCxk99LYB3jN7J/JNj47B5Ybk4PccX8ebm ubHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781461406; x=1782066206; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ufi8jS0Gv9HR4sYoAY6vKqLESkvd7ZmAPRv56V3pxB8=; b=iturW/XQUTIGvRUOgU8TicKFihK6Hb8opn99uVc0KToYjfJjmQgNQ7E+rRaBM1q4yb E/mOxOOlkaOYJr+uRXegf8GLW9DDSlhDrK1TuL6BLmiuhCzbzYTuZRS/xM+/FQbS0PKp C1c2JeJFC1ahXiAA3TsR2jHFyFkJCMQrz93XOSe2JpUfP2x13BY7+4e4s4tP88+p1c7T wvZSPCIi47R64J26ERS4fL2hkkLHvjjs2/h9nr5D/GbGiplpSz83VfjCoYyMv6MwvhO+ OYJJfW5mzZdpfmXxLgekf5bIQkKsGaWTvXH6HRZ3Eil5wLp5+fOO3KrwTrVicOiX+w28 1gZQ== X-Forwarded-Encrypted: i=1; AFNElJ/JmxowZnpMgkfQr742zMiEn0W6hLdc5Oao053H6E/lM8PDoS7DJz1IN/ffk9bayDhiv1/biHnRJSAaRy4=@vger.kernel.org X-Gm-Message-State: AOJu0YyXxISQEV7terE6EF+E07fyUUzA9ffp5Ahadm6je67/uFXrHxPq Nh1F3PzO3++Y18+Pvon7FEDC1zM/0QF1wQmwl6BBImPvzLDAaTuYpjo1 X-Gm-Gg: Acq92OGjREZ5RjxhGtVq+7w24B+6SNdiEDXv/sfaJ+ldkA1ntIOKHldepQBytAk0PeW /3/UFEhHE1utitoXXWjwmNgL7iyl/ye4m1ylBcnKFaS3IsgCeKwYRu8vDiejeOotRAKkd1bmhlM yDWToSDG/hezF/4mcNU7anNdAFP/HBqc7P4wQXNCkGQMkq2MOTWiKxUy/BEichLnSXVD5t4MZ7R iiWwaTMRNXKzRnG1FqSDpU7f2d47ar9fExtymq5hI3i7jsZt0iGf5xV3q8ez2QU+Zm+WtqCgIMU uSJYJ3FW35875Y+6Oh5Um2m6j120puwI1wqrzNbr/IuAshKOTLVv3jeOCoNYPVxp/jT4GIlEfI0 fMSy4WdmSrF1Tp8opmUjrYmym9yVMeWyR/lTYF6HVdc7QTqQAzvuqSMqnceDojwCgo5iATji+o9 X2wR+XcpDBRsrAzwtHMOT/dsa+BqAOpnwaYuYqDml7OdxXOnJhwpuMucfEVyiSRj0RPQ== X-Received: by 2002:a05:7022:f309:b0:133:39b9:9720 with SMTP id a92af1059eb24-1384c14cd8dmr2097495c88.16.1781461405456; Sun, 14 Jun 2026 11:23:25 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1384b975e55sm8435022c88.13.2026.06.14.11.23.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jun 2026 11:23:24 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: error27@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 4/4] staging: rtl8723bs: convert update_attrib to return errno Date: Sun, 14 Jun 2026 18:23:09 +0000 Message-Id: <20260614182309.96110-5-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260614182309.96110-1-dennylin0707@gmail.com> References: <20260614182309.96110-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert update_attrib() to return 0 on success and a negative errno on failure. Update rtw_xmit() to handle the returned error code. No functional change intended. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index b6d9332958f5..fb2fd3f5de77 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -741,17 +741,17 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p } else { psta = rtw_get_stainfo(pstapriv, pattrib->ra); if (!psta) /* if we cannot get psta => drop the pkt */ - return _FAIL; + return -EINVAL; else if (check_fwstate(pmlmepriv, WIFI_AP_STATE) && !(psta->state & _FW_LINKED)) - return _FAIL; + return -EINVAL; } if (!psta) /* if we cannot get psta => drop the pkt */ - return _FAIL; + return -EINVAL; if (!(psta->state & _FW_LINKED)) - return _FAIL; + return -EINVAL; spin_lock_bh(&psta->lock); ret = update_attrib_sec_info(padapter, pattrib, psta); @@ -793,7 +793,7 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p } /* pattrib->priority = 5; force to used VI queue, for testing */ - return _SUCCESS; + return 0; } static s32 xmitframe_addmic(struct adapter *padapter, struct xmit_frame *pxmitframe) @@ -1954,7 +1954,7 @@ s32 rtw_xmit(struct adapter *padapter, struct sk_buff **ppkt) struct xmit_priv *pxmitpriv = &padapter->xmitpriv; struct xmit_frame *pxmitframe = NULL; - s32 res; + int ret; if (start == 0) start = jiffies; @@ -1967,9 +1967,8 @@ s32 rtw_xmit(struct adapter *padapter, struct sk_buff **ppkt) if (!pxmitframe) return -1; - res = update_attrib(padapter, *ppkt, &pxmitframe->attrib); - - if (res != _SUCCESS) { + ret = update_attrib(padapter, *ppkt, &pxmitframe->attrib); + if (ret) { rtw_free_xmitframe(pxmitpriv, pxmitframe); return -1; } -- 2.34.1