From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E649122D4D3; Sun, 14 Jun 2026 19:02:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781463780; cv=none; b=GbFL+AC70JV2PuFv08LOx3CxLBxp8QJW8+PYOFHvDOvhOUX5XbuWQQV6DTnlTNAR0QHk4eKjYO2iKHmHIu13cAmwBXgi16btFeLfH1sP5N4oJbfd6PcMihO3U8thWDFEov6S7ORsVJ0KflPpfQlgL0ymXFzbOjdeaRp19RhV4ow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781463780; c=relaxed/simple; bh=cR0bQ/fQAn1YmlBeX2cniHr+ILp1JeeuSM2XY7vZYKo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=urMpzcjJKqACOVnq9iiWQkp+59Yj+Fkrd2Oj/LWimTVEtfSqcLmg7lY9QrA/5gxvWLnrBtM6F8P0vvJ8RCaOvhUfMW6DYy4jn+1O9QHE0O7xxqQW/netuHuAy7SGZFPVOOcxHHKTxMh7/Out8Ue+Cdn9km60Ed/kBa/4xVdxrhM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kG4fdTFi; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kG4fdTFi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84BC01F000E9; Sun, 14 Jun 2026 19:02:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781463779; bh=gq2R1f9PKvG4GeQx4qtnQ+1U1ShL/Y2qGYC1zfTULbk=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=kG4fdTFi9mSBILAaHp/pxZI8mfYYmRk5YosafQlNkf2qrtpb1bDqwUjABftaMAZ8/ WwqXRAiI3Rok9jrHNQqF+UKQvnkgJDuyab6d96wymtswRZWi3XxbT2qj9vDpwvQsrD GkLl7bxeC93CXgjj2Uh8OhpRrsz78s0BAxZJZ6ycjXsyhu8gsXNZ3Km2wtvERXOchJ ujZuXBu8GBmhcbO9qXC+F4KUsgpTOMyC6Uj1VxNFBMO25cF5RouBcgTy6ib1XI2epe uOEN4maBciWZksNPX3tWrFJ22cTxtitiZLwtZNr9EKGu6QHNLR2rMF8VBm1EGnNqap 7jDtzXpsdnqrA== Date: Sun, 14 Jun 2026 20:02:47 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Jishnu Prakash , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Kamal Wadhwa , David Collins , Anjelique Melendez , Neil Armstrong , Stephan Gerhold Subject: Re: [PATCH v2 1/2] iio: adc: qcom-spmi-adc5-gen3: Share SDAM0 IRQ with ADC_TM auxiliary driver Message-ID: <20260614200247.6a90021f@jic23-huawei> In-Reply-To: References: <20260526-gen3_adc_tm-v2-0-702fbac919ac@oss.qualcomm.com> <20260526-gen3_adc_tm-v2-1-702fbac919ac@oss.qualcomm.com> <20260604114630.23ca427a@jic23-huawei> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 11 Jun 2026 21:53:33 +0300 Andy Shevchenko wrote: > On Thu, Jun 11, 2026 at 04:13:07PM +0530, Jishnu Prakash wrote: > > On 6/4/2026 8:14 PM, Andy Shevchenko wrote: > > > On Thu, Jun 04, 2026 at 11:46:30AM +0100, Jonathan Cameron wrote: > > >> On Wed, 3 Jun 2026 02:35:20 +0300 > > >> Andy Shevchenko wrote: > > >>> On Tue, May 26, 2026 at 04:26:09PM +0530, Jishnu Prakash wrote: > > ... > > > >>>> + ret = devm_request_threaded_irq(dev, adc->dev_data.base[ADC5_GEN3_VADC_SDAM].irq, > > >>>> + NULL, adc5_gen3_isr, IRQF_ONESHOT | IRQF_SHARED, > > >>>> + adc->dev_data.base[ADC5_GEN3_VADC_SDAM].irq_name, > > >>>> + adc); > > >>>> if (ret) > > >>>> return dev_err_probe(dev, ret, > > >>>> "Failed to request SDAM%d irq\n", > > >>> > > >>> Also add a patch to drop this duplicate message. > > >> > > >> There is another thread going on this. It might not be duplicate > > >> if -EPROBE_DEFER is returned. The message won't be printed but it > > >> will be logged for helping debug deferred probe reasons. > > > > > > Yes, and I explained that it is duplicated as long as I understand current > > > code base. > > > > After I checked for Andy's first comment, my understanding was that > > devm_request_threaded_irq would internally call dev_err_probe in case > > of an error, so this dev_err_probe print above would not be needed. > > Correct. Ah. I'd missed that wrapper devm_request_result() Thanks! > > > Please let me know if it's better to keep or remove this print. > > You already know my position here :-) > > > And if I make the change, shall I add it in a separate patch > > before or after this patch in the next series? > > The rule of thumb is to make sure your series won't do ping-pong type of > changes: when one patch introduces (or moves) some code that is removed or > modified in different way by another patch in the same series. > > > >> So maybe we have been a little too energetic in removing these. > > > > > > Or maybe sashiko consumed a bit of LSD :-) >