From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E5814071D3 for ; Mon, 15 Jun 2026 15:50:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781538618; cv=none; b=Ej4IuBTpEOFZVF8KiXcz7WEhUNf3niqkUqRsvEerIAhrG874SkueCLfbggXj8abEiOlTwPCjrGCTU8E12fRTdweedu9cJZR7YjsbLgqxwr2sLR07pY9DweA5N2p35GJ7VjC8KHKSvC01ygLzF1zlkyAsdh5fi4dkT6l0poKJyBg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781538618; c=relaxed/simple; bh=ISiRgivrUNgXOhGrRFrPfm9qU6CKJwmw7F3QXOx8h3Q=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=eU89LJwYBj4BUdc6FCP7m5BxGd6VLTj2RNZ73RhqhMmwSCEkIvXJxGgWKetPTSxYqhKalKm8PbKPmb2fEUNc8v/34tz1DOz4slm2Zs0RoVRnxufdgIHLrEutb6tSwQzgJ7BoUK9QJEX2Tj0c2X2lvMbtY9YZy8HmgV1nzzWvlE4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kxl4yGpH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Opj+o78+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kxl4yGpH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Opj+o78+" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FFhRNr3139433 for ; Mon, 15 Jun 2026 15:50:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=hgBdpyflpofnvhZU51hgad KfJjYrEnSPY4mzVt1yhrU=; b=kxl4yGpHFV3A7/QIyIfrXxy2i66HFpv7NnoiuD QuSP5tJZvg7a8eYfZYBRG3rvM58XzUqs774jovj0HjsS6FTsEtTXD9tZqoazUWPu 9Lyt6Wq7mIG5DDpVSEzA760mv6Ws3eHfnnURYYE/mta68O1DP872ko1ad56yWThv nEsgkJNr0ZfXWzu1YmdJlZSV6Ch+d5JttM4KVP9uvbFDDpMxIy6FOLFrsrBv0NdX R5jKn+310f7sTwov3Z+PvHvCvq4WRnVBtHRLNZM+OsZqXw4X834+7KHzXPNxGpnQ +11ElaOcJiDKbrOez3gJeJilCNT7yEkst7ocSGXcWGfXTK+w== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ete981q03-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 15:50:16 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-91576c147a4so907724185a.3 for ; Mon, 15 Jun 2026 08:50:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781538616; x=1782143416; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=hgBdpyflpofnvhZU51hgadKfJjYrEnSPY4mzVt1yhrU=; b=Opj+o78+v0wOppterPAvaqr/GUm1+k+c6H3G+ThDGHKB9CXcG4cp5sroSlI8MPZWaQ LzlszCNqesP2BCp1GLVS87oRoZuKCCyVF9dg+Bybuoa6mJ4khBRHgvULsIdrPHwm7ppQ bDuKc5JGBtShtbB6MQjw1FqFvEOvV0ALH35ijJVCN4GC07KJ+YB8T4mC6pLmvdGtstrr eUZX/mE0g1BGfgm/4drUQLTnTJnSP4tVn4Vrkwsl2ah9q0Hoc/uOUP9qWiTomUJkCT9G +6fE3D/nOXGg/8rt0KWg1L/UH4AlU3NLs0gjKMfT463bwmbMcKJlULkrC8ugGj83A1wf hF9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781538616; x=1782143416; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hgBdpyflpofnvhZU51hgadKfJjYrEnSPY4mzVt1yhrU=; b=kKVJWyX9/VafIk+QOiMtGwinyg4MQWGYtPmRbEvKEN4SLHI1sU9Gqsmjs/XafH44+w fIQZNsAKDz/QyWOyQzjjBM49ZCPQEAPMADmXr+v2PuzGs/A0rUfVLQMifHTrlMs8wMnn QazMgcQ1bERpu+66kelAphi4Y10iAzNdHUzQzoIxnpIlc2uPYlDDZmQeBhBsszjgjkUv 7gcX9cGuiUnUwjFtVMMSzj+n+HqSYzJIZpsA16PJH50ZNtKhNIR7GtJB+KNT+eKwwZXt kzkjsyRy1gc5yDb8qQV4MqVH9wuUS+WSFKBXQnANubWvMREcsYV4HFinEEAZZDQILboo 78eg== X-Forwarded-Encrypted: i=1; AFNElJ/F0EdTA7GS2mk2u4sNio/eLy3/1snYM9vqurt0MURQT0VHKv2rPaT0pzJrxktH1VYEPx5YeE/dSa2cjqk=@vger.kernel.org X-Gm-Message-State: AOJu0YxFGA2RuM0vUFWNnqERRDA8dE0vVQnewLsHIJo+0GW1lnVQXAr6 1mwSqIHd9bUSOX7KXSVJM+VhaVZziXvoFmCJPcD08JfZJcfsSRySyHBau13qL83qr5Tkd3hnRq7 RQ9W3/byj+VyMpQLd6ihIAuQoFbSI9aAjzYZwIyNqD8nQgAb//AohhimLii9n9mqJjqQ= X-Gm-Gg: Acq92OGB/AzrTO9eC8NhFzCnsw2/X3LyypBrxcbKA/1CQLP/5SnNAAiIQMTG2SuzjXP DDncjTQ+8tTK5qcbvyYhNAlPKrKsXjz3W3Dy4dWP2uNe+QOJl4/IUrNvHZTAGkAqdzzh/j9UGna xIqDyBv/bWHtvfrHztDyYeXt8PcLl33MH4Fg/XvuUfkWyKlwViQmgVsjUKPuBIAl7iAjY2x33gp Zao8vg8Rwj7jDukjhwwKhNKyGHGZ2G1hF2xtTEOqhtnaU5c4pT9xDETzDFcLJ7Lm2bAC7dSUzrd U20rv93ECE5ID4EaB+e8Yk61CfMVqCihKVZtlT2/39+bQt/dA2bMBCFRulyU3DzsQNxZLjRE+Vp wSOx2FkaCHthg75eztPzzO1T8ldIPr3cXLPgnp/ETRr4On5FPPRc= X-Received: by 2002:a05:620a:1a1a:b0:915:1359:fc5f with SMTP id af79cd13be357-917f03a447dmr1728336985a.14.1781538615880; Mon, 15 Jun 2026 08:50:15 -0700 (PDT) X-Received: by 2002:a05:620a:1a1a:b0:915:1359:fc5f with SMTP id af79cd13be357-917f03a447dmr1728332385a.14.1781538615498; Mon, 15 Jun 2026 08:50:15 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:7fe3:eaf0:5a0b:2610]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f26f450sm38643032f8f.10.2026.06.15.08.50.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 08:50:14 -0700 (PDT) From: Bartosz Golaszewski Subject: [PATCH v2 0/8] crypto: qce - Fix crypto self-test failures Date: Mon, 15 Jun 2026 17:49:51 +0200 Message-Id: <20260615-qce-fix-self-tests-v2-0-dc911f1aad42@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAB8fMGoC/x2M0QpGUBAGX0V7bevYULyKXIhv2RL/f1ZS8u5OL qdm5iZHNDi12U0Rp7ntWwLJMxqXYZvBNiUmCVKHugj8H8FqFztW5QN+OJeNqE4CbaqKUviLSMY 37frneQHlyoYGZAAAAA== X-Change-ID: 20260610-qce-fix-self-tests-492ffd2ef955 To: Thara Gopinath , Herbert Xu , "David S. Miller" , Stanimir Varbanov , Eneas U de Queiroz , Kuldeep Singh , Eric Biggers Cc: linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, brgl@kernel.org, Bartosz Golaszewski , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2299; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=ISiRgivrUNgXOhGrRFrPfm9qU6CKJwmw7F3QXOx8h3Q=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqMB8knXSBoChoC0KUGmOGyvXEwxpwsKvxGgwjs H1GtGd1/YOJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCajAfJAAKCRAFnS7L/zaE w/kRD/9lMC0E/LMqNvFfT5gMTbuEpqOs5YKPBoDR60vOhptFBhbGfYbVuIdpYUG3i/wPM6Jvazu uHmnXklFdYCGMd9T6VLMzcKpZTbzG5BTayxpX7xfpYRStZUQEKBLNQ/tq4t8iko8E6pdkmM9cgj 0nYI7iEdwrNxLUo6pbVEpb8Ue+KeboMzJLxS89aEJTeorNvPu2d9myOpbzczDrJ61NVR61Z+dUb uo7IvcabJD7tDUD1giN1cJH2DFDi5XURUMiik8RZgntAcx9vN8V/Y3jMxVkz30hsfftzGhovMsI pxzVggkw/UDPvFSI+lelg7SxXM5f0zb5jMRCq0H9hEyh60/hXIdhzJSvcjaQ3tOl9I3uSwzDGNU h2b5zOhLz3HoxvuXFiUSLELATwmMKrQozztF62rYTHUCJGUmag3jMDskNNYvEH59UNhIK8F/19e 7g8fODVGqjo31LC0GcxOEUITbLt7D0habQEJv1VVX9tA66Mu2kdCwIfqY7K0+/Xcd0sA/bXQnqd QfyrHtA7zcE4ovAjOrnsrS56qJpKE5DfNGt/itMskdn0NZHLYmP3zNUDFaVimgfAcZa0Hpw073p KF4SyisQ+cvU7TzpIDSHhyunnzi90nJr3w86n5BrMI5n0bDifGryfJCIa+qahB1CKPKHrg3lLsH I8yluytD8zAmIWQ== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Authority-Analysis: v=2.4 cv=V5tNF+ni c=1 sm=1 tr=0 ts=6a301f38 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=bC-a23v3AAAA:8 a=EUspDBNiAAAA:8 a=5rERACauPDyaBIpbJ_EA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-GUID: r034xQ6Nfh-kSDF5CQ0rNIaLMAl1lC_V X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDE2NyBTYWx0ZWRfX+QqaQDmf+EsL 3Xtd/h0atJjql5ZMstgchPG3j2LzoQjFon9Na0re8hX/MrkIP5u7yVCss31OWqGpmAvui9AihQ6 Q9cGNx0c+QBbUeC3YaDEao0nC4+SGi0= X-Proofpoint-ORIG-GUID: r034xQ6Nfh-kSDF5CQ0rNIaLMAl1lC_V X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDE2NyBTYWx0ZWRfX+wrG5fDizpNg 8iWzrgxjsWYyMkeA0fhbbkl+GcHHBNdL6AJfJz8TQSF0txD+93S0eSYlcc6697DNIzA8shN9l1B XIS8KUIrlDq1sTQh/OoMAt2VMXtTq4twaQrtoKULhCtHtEEo35iVxKSLo2B/g6kP1MUdvPbRvYa fxN23HyZkPF09aU9kSRiu36SECHqmvAggq6CgUyA7KytuSEF1OY05y3vKv0cn2iD2OS9gXhAuuw RoX8O7zLxhc4Sag+K5k9pyrwvW0lCuLL169KehTjSCsv7WkU5TGhU4fVQVwiZeoFVRogGNKv+Gy IX0Cx3iJf1vwrwqdLY+oiSj4KXr210XnD8fsUqUOg6o/P/1VygFGShefXTOTzMSMez6iwqYu0t3 n78JBo8Vv/MVs3M/j0yrTQ/ZwMLlE6a6niJe1pqRa2JiibEG+8H9KhQcyqVLVMlT1i5FwnVMFay Onww+zwiyqB959xA0+A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_04,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 phishscore=0 malwarescore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150167 This extends the initial submission from Kuldeep. The QCE hardware crypto engine has several limitations that cause it to produce incorrect results or stall on certain inputs. This series fixes several bugs and adds workaround allowing the deiver to pass crypto self-tests. The failures addressed are: - HMAC self-test failures for empty messages - AES-XTS returning success on zero-length input (should be -EINVAL) - AES-CTR: partial final block causes the engine to stall, output IV derivation was incorrect - AES-XTS with key1 == key2 is not supported by the CE - AES-CCM: partial final block and fragmented payload both stall the engine All fixes were tested on an SM8650 QRD board with CONFIG_CRYPTO_SELFTESTS=y and CONFIG_CRYPTO_SELFTESTS_FULL=y. Signed-off-by: Bartosz Golaszewski --- Changes in v2: - Add fixes for the full suite of crypto self-tests - Add Fixes and Cc tags - Link to v1: https://patch.msgid.link/20260610-qce_selftest_fix-v1-0-1b0504783a46@oss.qualcomm.com/ --- Bartosz Golaszewski (6): crypto: qce - Remove unsafe/deprecated algorithms crypto: qce - Fix HMAC self-test failures for empty messages crypto: qce - Reject empty messages for AES-XTS crypto: qce - Use a fallback for AES-CTR with a partial final block crypto: qce - Use a fallback for CCM with a partial final block crypto: qce - Use fallback for CCM with a fragmented payload Kuldeep Singh (2): crypto: qce - Fix CTR-AES for partial block requests crypto: qce - Fix xts-aes-qce for weak keys drivers/crypto/qce/aead.c | 72 +++++++++++--------------- drivers/crypto/qce/cipher.h | 1 + drivers/crypto/qce/common.c | 27 +++------- drivers/crypto/qce/common.h | 7 +-- drivers/crypto/qce/regs-v5.h | 1 - drivers/crypto/qce/sha.c | 93 +++++++++++++++++++++++++++++---- drivers/crypto/qce/sha.h | 1 + drivers/crypto/qce/skcipher.c | 116 ++++++++++++++---------------------------- 8 files changed, 162 insertions(+), 156 deletions(-) --- base-commit: 7f5e2941e7dccc9dfaaa23d0548a40039772a284 change-id: 20260610-qce-fix-self-tests-492ffd2ef955 Best regards, -- Bartosz Golaszewski