From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABACC409E0B for ; Mon, 15 Jun 2026 15:50:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781538628; cv=none; b=aJEJdFEOJoBMJlpKZAa0Bgk/QumnJ3/0qe4vbc/NpHtv1TfY78yWnTo2GzJn+KfPMp836S74rYybKCVQ35oXxMAEGXNipeKttsmLOSSrxypJ8PEKd9pwgMFLvD6g1QaeQIqlzhZXE92hMbZGOZB5V8kv32/MK7PCB66FniRTVtI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781538628; c=relaxed/simple; bh=i2fU3H0f8RtrifvWpGUX+rYKiakFm1ijQ2hsGbX86gs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=igCGxntQ2C/JZWxqxda8ryZrGKX5A1MKKBaiEpwcbs+Yec+aQ+ItUSielo+3SihaX0Y7IeWhSj84VXe2w+tFKnWTozKzCQUllJB1k0/Ywt35dQbivzJJQRGnfepXDBZPdW8xZWl8c3gkXGQ3hODqd6Mqqp8YBlKx7eC0FpmSrh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZtuaOlcH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ja73Rj/E; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZtuaOlcH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ja73Rj/E" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FFiF4E349592 for ; Mon, 15 Jun 2026 15:50:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GvVf4ywBOXek3VYmfQJ/BRHKjKyA+5DXdSFDv3cDrFQ=; b=ZtuaOlcH4py7MOKT JJT26dIfoOSO2/9mj4T77e+w9mg79tPF8r55+pdZelqg6m0F12gH7hd3ff+tCGug 20+ZdV5+TqzP1s0Ukz5OrR0Eb/YRHB15qSqGsNn3lQtAoh6rylq4ptZYAHH8C7A9 8d0Lae/dVNSoNzAOEb38nrZrBf0ix+ZwMuayvDl3cD4i2/ibTH8PfE9SWljQz8tR uaMjT9JF6wCjZyxLXLtdS2EcytKQf0mKvmHff+4c0h8FoFqiSK08GNpY27EZ+9zT r2L0SFFNWNxFOV69rwiHLP2qTLooO9qPUQXmij6t45C2ocsu2/xzBf+uMGOIUWS6 ZRbl8A== Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4etetjsk21-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 15:50:25 +0000 (GMT) Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-966a617821aso286140241.3 for ; Mon, 15 Jun 2026 08:50:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781538625; x=1782143425; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GvVf4ywBOXek3VYmfQJ/BRHKjKyA+5DXdSFDv3cDrFQ=; b=Ja73Rj/EYpg/W2kO+W3pWLPWfNm8MYU2PrXOtFrk7O0vpZpcTyOI8UgQ3/8+T8I8gB 2Rel3Q6RPDIcIddrlmua/mEK3F8zLUXwnvPu/UHng0HorTTefP7TWzRdzy74xdA7wxa2 KFnYiU15m3odFJi/PeJcP1VzVKclisHPHtf5fMHBvolTn/a081ocyi5ZUU/mMOdagrjI 3B+6arjV5kVKF60LYiX9G7qHZ6xeJ0eSgCGeSq9SD+iUOkRXGe3FPeBOYvgmiB51XTj/ YLTjNRLWfQV4+GaZfRzdPe3xmjzdKki3BZBY9Xyl3AcGsEGG/hBek9szEjkUDkf83dFE 7mDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781538625; x=1782143425; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GvVf4ywBOXek3VYmfQJ/BRHKjKyA+5DXdSFDv3cDrFQ=; b=gf3cIX5jA/PO4e/opJtQB4SOQM1mSt4g0GVaFuzmPky0W74nD8szQPS6THIHojT4e6 3j19rfYZ9qiiyXNY9nHJOhoOVL0oaBFo+n6ThbSKLTJxa1OGlU9EbY5y5ORD5Fkz79mE HjxuyLOCa0bgH9vs6h8+qVfK8Y50GflW3UYrl6Lr4a4rMfUmdtKTKq94RtHwh1dAwWOi mPwECcktwid8jtvVjPMk3ttD/9RqxkJlEibO5TqbsTXB4zU1/EUbHwfU3rdq8OhJRCSz z8qPWmFbu52bURQQu9hsAPwi0KaTBz2q0w8tt4ILKNn2wKSHCbcLf+o2GYcjorfhCVu9 uWiw== X-Forwarded-Encrypted: i=1; AFNElJ8KYrXX4lu7oN+CHgoDyLOL91MvfThXTf5AafkfObLYCIvQU7sDYjG9GZBDSzbeeqF+ZvCEKyERFqx9MoA=@vger.kernel.org X-Gm-Message-State: AOJu0YxjGWNrLdgu6V1UyFqlWTrJyrhEwkmGbyT6bS6yfRLyvvgUcHVP wnt/az+CdtrqBXJVIEZvWM/IjVx9Kv0YHm5wS+5kPuW9HT6CnEp3NTTr7t7EObS8QCyDekBsHRf W+E3Sc/dM6zrGoNsU3y+JJWI4Yz62kiEGnHiWPli+ddjExVBdsCL2x879+VuDccw8Y/A= X-Gm-Gg: Acq92OFrSy+9BtKpSe7jlg/4hyv2GkFN2FsABig7Nkc1X6NZpo4s1kauPk4Vif1TJPS RWWErPNez5xjJHEYnv9eS5Q1JlLOgJQrGn+da+vqjlypZLqNawYAzav6+BUc5CudKnLyLpeW9VR a/rE2m5bp40vPTzjdW18p509fGIMU8YxJp/nVYH+acwqEj/unuD7RPI3nAvyFuL0oD30pmW/Vtc lQBOsqhfU7RUO3773tEgNxm8z6RRx63T70DI9Vz1Tnkcna33bvnLCoyYMKyq5ADsCe43ih9fMNA avHy4cCLkaFdZxk+CYLFFW75inJx3cX56go8JaPmjxyYSN/uUGMXbc8it7CoW3IG/98oGNUMMWP 0Alnw4Rtz7L//gKmeSzYBuWNjQ5YTX552ssUJ1hSUkTaCYeGbTho= X-Received: by 2002:a05:6102:801d:b0:6a2:b2a1:f16a with SMTP id ada2fe7eead31-71e88acea75mr7814521137.2.1781538624948; Mon, 15 Jun 2026 08:50:24 -0700 (PDT) X-Received: by 2002:a05:6102:801d:b0:6a2:b2a1:f16a with SMTP id ada2fe7eead31-71e88acea75mr7814498137.2.1781538624459; Mon, 15 Jun 2026 08:50:24 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:7fe3:eaf0:5a0b:2610]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f26f450sm38643032f8f.10.2026.06.15.08.50.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 08:50:23 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 15 Jun 2026 17:49:54 +0200 Subject: [PATCH v2 3/8] crypto: qce - Reject empty messages for AES-XTS Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260615-qce-fix-self-tests-v2-3-dc911f1aad42@oss.qualcomm.com> References: <20260615-qce-fix-self-tests-v2-0-dc911f1aad42@oss.qualcomm.com> In-Reply-To: <20260615-qce-fix-self-tests-v2-0-dc911f1aad42@oss.qualcomm.com> To: Thara Gopinath , Herbert Xu , "David S. Miller" , Stanimir Varbanov , Eneas U de Queiroz , Kuldeep Singh , Eric Biggers Cc: linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, brgl@kernel.org, Bartosz Golaszewski , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1432; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=i2fU3H0f8RtrifvWpGUX+rYKiakFm1ijQ2hsGbX86gs=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqMB8uiTVzUq6zsXGI17YitgotwtvpOvjWs4SVp zEJ8U2hxWCJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCajAfLgAKCRAFnS7L/zaE w0cJEACzsfUnjbY5uXwNOwJqpfqt0kdS+dtI9SbD12awmoINPES9jW748rjjS0DgzlcO+jQhlsk BjYjjh5MokdL4NXga0Tvju1ZAShPYm8rLBvzv0kHrppuv2xXy88ZAxFVVyOM3NXmf8kr89XYHDz XJYjWvK3EnTnB2do3rKalb2ofF1jQ2owvmkh0zr7lvWot0GgBoU4qoy+AzKApEyq+YSrd25uXR0 czh/fzoUUXmiSkLVQnT4uwmHQPewevsnHUbp4Y5FZR+toXYqYmyFA4I+oXAOxyjV3DubSsK46Q7 2wIkikvjcics51UKy5yn1AkeygsAaRjDwbKH+e5Q61cclVDlUDka8t1HaMHVOFaqb57KcrVyIZC H0s+UGusV2Xoj0VssWKg6ft+mwI7RTPPrPZR2HACdsuD/MulK0F0PhSdMRiGdBJZrPt97y81rpa 844B07hs9+MxM5dFZ886bTbtxTXVVRl3tAfFKtQcTSNTkAdrm6FGvRlJHs3g8Gb5fC/m119subT g8Dz5TCo+HraFFDmM5pEf8ZwYteVE6++3hNRv9lNiD3OVWMIGCiDNsOtV+f2ke6d8yL4JZkubSB s+Ow2+T5Ohe9sripLlPTF9b9bgg6YV6B51JTs/1zfNqI7lf1DMHPKX5KQle1cTODt2Dk+h0FYLW 5Ap4scN78RZmSkA== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDE2NyBTYWx0ZWRfX6FonRGBNlaJ5 py/RipbD7XF6himvsNf7QVq5y3bquP9M0bs6kXqHfmb63r1R581NsB3uAfNI/+8HLE8NA6Kc4rI GxdajXM0Q4CxrPEFu53h+TQvEkGJsnSCemjJl+hDZYdnT+Bo9qMvW0h3aawGXTivCe6W1s6pymK cgLAkScSDq28Nsid9qYj/3yM+nln/gtJiVtmxF7ds0e1XEtNS+xABtUko31cEvIrqm+yvsC46hy J/rDSWIAJ7BQZmfINIjXYb7OhJo9ixm8puXDUdSQq8Tz2xDs8ZAlbgkP9EO5zsna+pWSn4EAaE2 248nQBhsG3E4ejB04d1qoOz3oZ77vJQ85cjoEtHYfg2mtsGUDj3YqdnlvrQWBY7LVhAQphzcAK6 nyADhjznNQPOYbjcNVjwe1R2PajzH7Y6XQdgKKMRcPFLGXPjUBhb3IfqvQr3muvzw1rYLD5QZ0m HMS95PUpLfm8kFslQKg== X-Proofpoint-ORIG-GUID: 024ehaouR876rWCf2ButVxBubweGJd0w X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDE2NyBTYWx0ZWRfX45GLoHQxU56q 0gVuIi8MJNH201N9Cyzjk3LW4x9WGCXTYQQ4KVwadnQtMMY50Vka2WAVEwt5fP8/9M687GnsXW6 gOVgNd0KyV8HC2+gPc5ZHKDcBGI30iI= X-Authority-Analysis: v=2.4 cv=HttG3UTS c=1 sm=1 tr=0 ts=6a301f41 cx=c_pps a=ULNsgckmlI/WJG3HAyAuOQ==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=kiYxeA6Iecqc4QeK3QQA:9 a=QEXdDO2ut3YA:10 a=1WsBpfsz9X-RYQiigVTh:22 X-Proofpoint-GUID: 024ehaouR876rWCf2ButVxBubweGJd0w X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_04,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 suspectscore=0 clxscore=1015 impostorscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150167 XTS is not defined for an empty plaintext: it requires at least one full block of data. The driver treated a zero-length request as a successful no-op, so the crypto self-tests "unexpectedly succeeded" when -EINVAL was expected. Return -EINVAL for empty XTS requests while keeping the no-op behavior for the other ciphers, which the crypto engine simply cannot process due to its DMA not supporting zero-length transfers. Cc: stable@vger.kernel.org Fixes: f08789462255 ("crypto: qce - Return error for zero length messages") Signed-off-by: Bartosz Golaszewski --- drivers/crypto/qce/skcipher.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/qce/skcipher.c b/drivers/crypto/qce/skcipher.c index eff80ad5cb943c5b2e1e293c723bb1b31102b006..68b83e3ae088ae42a7fb2a2f0c2e132acf62e849 100644 --- a/drivers/crypto/qce/skcipher.c +++ b/drivers/crypto/qce/skcipher.c @@ -239,8 +239,12 @@ static int qce_skcipher_crypt(struct skcipher_request *req, int encrypt) keylen = IS_XTS(rctx->flags) ? ctx->enc_keylen >> 1 : ctx->enc_keylen; /* CE does not handle 0 length messages */ - if (!req->cryptlen) + if (!req->cryptlen) { + /* XTS requires at least one full block of data */ + if (IS_XTS(rctx->flags)) + return -EINVAL; return 0; + } /* * ECB and CBC algorithms require message lengths to be -- 2.47.3