From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f202.google.com (mail-dy1-f202.google.com [74.125.82.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F3CA3AFB1A for ; Mon, 15 Jun 2026 06:16:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781504205; cv=none; b=WCv0Yz5QcTAkvvnpBlVeBw98mdyS9hfnz9QDMrZMkbEl2HaW82qWFs/nVvu6RAQwDWN5oN+tRzensWPho7F0aB3YzGYTMy5oLVSV72n5/n38cw8Z9YK+XV01x3gkj2cOr0DuhFWZEdtiNI06HDwPM7UYu/c701glcVg5spBrcjU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781504205; c=relaxed/simple; bh=JSfVdaFgVT+16BkkuKzKlIjgGUMwUVUUeSc4uGtnw10=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=SzUieA5JCol5yBKSUapI7PS+eozpJ0iG4utRiXUgp/dmSTUSYVGC1gBMwmjpPi2fc4H819q0/mgOckis8haDBCrNFIhaqi0Ni/tiy32Pjc4jrUb8hFX0F5MPKE6Pt2/ZM+lJE9/7rU1TAH/Tz1g1hzjMVsL1OJK7OvyptFKl+BE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=QRBJVzMT; arc=none smtp.client-ip=74.125.82.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QRBJVzMT" Received: by mail-dy1-f202.google.com with SMTP id 5a478bee46e88-304ea42b025so1655411eec.0 for ; Sun, 14 Jun 2026 23:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781504203; x=1782109003; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=lq0ALMVaEZfhSbzg5O+HM/S6tJqN1Cgs4e0hJ55fARY=; b=QRBJVzMTioOtZR9vZOMmUieFhFmL/iVpcGlBEyg1Vcj/qYhNndL224G9Hkdem3qHh/ 3UZLwLJACaAnkERL/SieG0LJeNArRg/zYURj5LD9TuuOrIrVQySJio61SPBYVqCipBQ8 LEcD7IV/2fO0VXECBUUgoFVtLa2+F5H5iWlaYhrju2TtoSr6rDWj5pQ1bsCZPH+vftJG jkaUubBvz1BphfU/pDEA98RZMvfu/R4/SFSJB0jYM35qa7N3keHK91JZtgy2KppfO0ks 0qoEJQK4hv6cE/E1/yPObNtyKDOQV7pulIUj/DxuJcBq2/yfJbGYpO1VcXGFKLIDtZkT l8/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781504203; x=1782109003; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lq0ALMVaEZfhSbzg5O+HM/S6tJqN1Cgs4e0hJ55fARY=; b=n3UNvohEtHBCmBn5SftcNfjH1tyocYtA2RkbMhL9BMfaV/EwrIwhNx3ZWPB0XjPSIE K4VTx9ryKjQ59Ue7K3mBcqCoIRT8p0SVFJPctzq+SojTEqmMfjDz+8CmUwIgvDBiY/l+ j/lxkkPv5ruZeWEDuANmLrInqo/NPZzKhsEisMpuR1QRFGlaQUWVoUDJtLBkJeYyuWTC HsI3ki2TgbG/EHRNkNv8BLn9kwJbrie6fpkFedDVqEtQG/mxrWfyRMH6qx0ACHJIVT3H XqVwlM8ALDW0I+SHBM38xOGN9anQU4qTVg2l7a9FWCoqK6P/AKyNXVeW9HQ4cN9tS+/u 5K1Q== X-Forwarded-Encrypted: i=1; AFNElJ8kbBqRV8pxiN7J7XXkrnNefY69g46AA4Hn+qN3RnjvDXsfLWe5aQxtnJIWjkSna94EW/p9j+J3HW6p4hE=@vger.kernel.org X-Gm-Message-State: AOJu0Yyc6gfC21oqewbY3vuckncGSfRz+FgukDeVIOiveoQ4gX+/W2Mv sI4p7mcb41Pe0FJE9Sj5ehAGV1egSzwjh3UatCp+Mx424UwuP426MGpZUvIYByxwfZe6ggBQ7y0 cwXQmVM/Rmg== X-Received: from dybbs28.prod.google.com ([2002:a05:7300:a21c:b0:307:bbdd:4346]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:693c:65c8:b0:30a:e52f:9b99 with SMTP id 5a478bee46e88-30ae52f9d34mr2329654eec.0.1781504203036; Sun, 14 Jun 2026 23:16:43 -0700 (PDT) Date: Sun, 14 Jun 2026 23:16:13 -0700 In-Reply-To: <20260615061631.2382079-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260615002812.2234795-1-irogers@google.com> <20260615061631.2382079-1-irogers@google.com> X-Mailer: git-send-email 2.54.0.1136.gdb2ca164c4-goog Message-ID: <20260615061631.2382079-4-irogers@google.com> Subject: [PATCH v19 03/20] perf evsel/evlist: Avoid unnecessary #includes From: Ian Rogers To: irogers@google.com, acme@kernel.org, namhyung@kernel.org Cc: adrian.hunter@intel.com, alice.mei.rogers@gmail.com, dapeng1.mi@linux.intel.com, james.clark@linaro.org, leo.yan@linux.dev, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, tmricht@linux.ibm.com Content-Type: text/plain; charset="UTF-8" Use forward declarations and remove unnecessary #includes in evsel.h. Sort the forward declarations in evsel.h and evlist.h. Move some PMU code into evsel.c. Signed-off-by: Ian Rogers Acked-by: Namhyung Kim --- tools/perf/util/evlist.h | 15 +++++++++------ tools/perf/util/evsel.c | 5 +++++ tools/perf/util/evsel.h | 25 ++++++++++++------------- 3 files changed, 26 insertions(+), 19 deletions(-) diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h index e507f5f20ef6..e54761c670b6 100644 --- a/tools/perf/util/evlist.h +++ b/tools/perf/util/evlist.h @@ -2,29 +2,32 @@ #ifndef __PERF_EVLIST_H #define __PERF_EVLIST_H 1 +#include + #include #include -#include #include +#include +#include +#include + #include #include #include #include + #include "affinity.h" #include "events_stats.h" #include "evsel.h" #include "rblist.h" -#include -#include -#include -struct pollfd; -struct thread_map; struct perf_cpu_map; struct perf_stat_config; +struct pollfd; struct record_opts; struct strbuf; struct target; +struct thread_map; /* * State machine of bkw_mmap_state: diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 34c03f47a913..19e48b9260e9 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -370,6 +370,11 @@ void evsel__set_sample_id(struct evsel *evsel, evsel->core.attr.read_format |= PERF_FORMAT_ID; } +bool evsel__is_non_perf_event_open_pmu(const struct evsel *evsel) +{ + return evsel->pmu && evsel->pmu->type > PERF_PMU_TYPE_PE_END; +} + /** * evsel__is_function_event - Return whether given evsel is a function * trace event diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h index 8178858d168a..6b28cd754a18 100644 --- a/tools/perf/util/evsel.h +++ b/tools/perf/util/evsel.h @@ -2,28 +2,30 @@ #ifndef __PERF_EVSEL_H #define __PERF_EVSEL_H 1 -#include #include -#include + +#include #include #include +#include + #include #include + #include "symbol_conf.h" -#include "pmus.h" -#include "pmu.h" +struct bperf_follower_bpf; +struct bperf_leader_bpf; +struct bpf_counter_ops; struct bpf_object; struct cgroup; +struct hashmap; struct perf_counts; +struct perf_pmu; struct perf_stat_config; struct perf_stat_evsel; -union perf_event; -struct bpf_counter_ops; struct target; -struct hashmap; -struct bperf_leader_bpf; -struct bperf_follower_bpf; +union perf_event; typedef int (evsel__sb_cb_t)(union perf_event *event, void *data); @@ -356,10 +358,6 @@ void arch_evsel__apply_ratio_to_prev(struct evsel *evsel, struct perf_event_attr int evsel__set_filter(struct evsel *evsel, const char *filter); int evsel__append_tp_filter(struct evsel *evsel, const char *filter); int evsel__append_addr_filter(struct evsel *evsel, const char *filter); -static inline bool evsel__is_non_perf_event_open_pmu(const struct evsel *evsel) -{ - return evsel->pmu && evsel->pmu->type > PERF_PMU_TYPE_PE_END; -} int evsel__enable_cpu(struct evsel *evsel, int cpu_map_idx); int evsel__enable(struct evsel *evsel); @@ -478,6 +476,7 @@ static inline bool evsel__is_group_event(struct evsel *evsel) return evsel__is_group_leader(evsel) && evsel->core.nr_members > 1; } +bool evsel__is_non_perf_event_open_pmu(const struct evsel *evsel); bool evsel__is_function_event(struct evsel *evsel); static inline bool evsel__is_bpf_output(struct evsel *evsel) -- 2.54.0.1136.gdb2ca164c4-goog