From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7AE23E3153 for ; Mon, 15 Jun 2026 11:12:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781521956; cv=none; b=sHFEFWuwRlfAXhMW9z3ctuiKJ4QI9myBod5RgiuCkk8QGmlMrH9TEygKoN5pKi8SEWWOQNsW8+51wIa9X9qmh1Bzdjz1s8+ObTcaZmWe2Q0QK5mKWBfv+od2EsJnAmkRUOr29HtAPr/Z29IVNj+80n2p6sN9lhCLgbvOh8s0/nA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781521956; c=relaxed/simple; bh=57jj2ELD/+bBbReTVLazCQ/T05lRPdlwkIwnR/LjmCA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mMATSVKdYUxSaQM225/aRLTOtlnY4Vqc7lsVE9gLSxiKika+oG2PU2szM73YpedXZz22iHICoJEKmNlTfaOG/HR0j6DjzQSPu1ArcqhAmHjBCy8BaEkLgg7nSgGvKxe2K3+Cps7DhU4ve5lixv/m+ljuBXNQQMJzasWsa0Lxapg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iCkm+SQ2; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iCkm+SQ2" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-372b4330deeso2020177a91.0 for ; Mon, 15 Jun 2026 04:12:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781521953; x=1782126753; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WsGLYIEljbmkgcXWOoiQ4CfE404Nv9JQoEZ+rL5nh7I=; b=iCkm+SQ22i/pPnnVY9RlB+7y9t7a/+BPEO1nHX+dunrbGOC26HIiJ2y85UWKTAdx76 Z4Hk2mNE0+J3YmNczGqiz5TYUbnut5vc22OOc50CUlO4KYa4a2FwPzo2AP14+0+7AA6+ /KS32YD3AaIiRHuxQmwfNlorjNuNqJAGildYXyuJH61MKit+buPF87NaPs/y8yvnqKxZ 1I4051a5wbshNA6qpmu+Xb5MFj1uybT9fZ+igDNimiRpMAkGHuUfL8ZduzsSvhc5DIQn jluTF4rlNihlzGkdPDMeH3vCwH6cvtxT0UHYXiIpq9BptQCMnE0qIIxkVjasnTSiMZUt woaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781521953; x=1782126753; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WsGLYIEljbmkgcXWOoiQ4CfE404Nv9JQoEZ+rL5nh7I=; b=YdPTgAeyhTNKCUugO29iEWJYQLRaHecn1h+27gGvBjx2bQeVBCCYKuJqIBotxY96q0 aFD+nf7l2TH+gCi/6ApdT9Ul7zZiJKAZI3Lrkd3gt5ZHDzuBnN5ZB2dU9lNxZTsWQ/hM jvrRbIxYMmoM0kJXq/DZ/XieGY/ax1q2Knl6lCeJOfk5FNoNCwDBxsMN2rnWgFHLYXQT NMTLrKoi8zUUco8H4QKwJgS7ZIAnjMBm9d4dPNEF5wq73zveQEY6fwauqOxLbc7aHm+7 heUucszC/aMLDM/luxo1mys4/dWBMEDiRJMH2zGAkzbRnjZ+0dFX8lES6B898oDRc8Wc u52A== X-Forwarded-Encrypted: i=1; AFNElJ8aowfgzXG7gywkAtLNmgun5AZj0Qhd+6qusNriAHjGC9d8ilhM0KoI+G8ayxmJO+uRA6hBQiZmwBt4Eo0=@vger.kernel.org X-Gm-Message-State: AOJu0YwYkiozQynki34hzRydeGvg0zsHZOmEd3oKjU2ZEBFVpR4sPqDe WiZ/X3lGMr/e0aJMqQUvIznO80VyDF0i4QQeKtwSIYsUeB9gWPW8HUrQ X-Gm-Gg: Acq92OGrC0Q6mTFMVTvg6z5HZEPfRm/NuBFyoo++ziNe2CiY4ljW0z0AJoDm7Tn40z+ VbZqqPG3TwkfVsQKeoR7opY4uWawI99lBDTzksVXxMAMxxr2pKer+afgobZvkis7TCOFClZNojR gjiu/HWP0ZdwMLgmxnQvCJYGizy9k7f85pEtMCddvxICSzX4igN6H3zknODtW+CUALby3xXz4v8 3gpLqhbA9bg+QZTWx6gcsnOZyw7LRGOJ1CmGkO366LVweLa+RolfICzRANi2icQcR34IUjclibi +N5z1yUX8ElVTVJ1VcVA3h7SkM0+cpO2V6CtX3Ny5DrcBCOAQL0dlX/t4IvecYV3GvshEZ15YQw TmlCvo2Z5B97uGsKAfUmvg+h/DNVqbLaSEiekGJ4pnNQcJJ4MeU2C5OIk0k9KVqz6Q6qLV2IZ2M 7rpWo+hrpoEl6fv94kMRM744iGAvF0UDo3N1MY4cWnSi5sFmltQIv/l840EKYebTxIf7JHA5kyB G/XnoopQZAjk/757yo= X-Received: by 2002:a17:90b:1fc3:b0:36a:7da3:266b with SMTP id 98e67ed59e1d1-37c2bd58218mr11637903a91.21.1781521953198; Mon, 15 Jun 2026 04:12:33 -0700 (PDT) Received: from thorfinn ([2401:4900:8834:3eb8:287d:f61a:3d8a:67ee]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37a2668cce5sm16969534a91.16.2026.06.15.04.12.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 04:12:32 -0700 (PDT) From: Prashant Rahul To: Jonathan Cameron , linux-iio@vger.kernel.org Cc: Shuah Khan , Prashant Rahul , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Petr Mladek , Krzysztof Kozlowski , John Ogness , Oleg Nesterov , linux-kernel@vger.kernel.org Subject: [PATCH] iio: adc: ti-adc12138: fail init on calibration timeout Date: Mon, 15 Jun 2026 16:39:13 +0530 Message-ID: <20260615111156.199906-1-prashantrahul23@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit adc12138_init() starts device calibration and waits for the EOC interrupt before checking the calibration status. The wait helper returns -ETIMEDOUT if the interrupt does not arrive in time, but the init path ignores the error and continues probing the device. This could lead to registering the device even tho it may not be properly initialized. Return the wait error so probe fails cleanly when calibration does not complete. Signed-off-by: Prashant Rahul --- drivers/iio/adc/ti-adc12138.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/ti-adc12138.c b/drivers/iio/adc/ti-adc12138.c index e5ec4b073daa..1f5f4b7794c1 100644 --- a/drivers/iio/adc/ti-adc12138.c +++ b/drivers/iio/adc/ti-adc12138.c @@ -300,7 +300,11 @@ static int adc12138_init(struct adc12138 *adc) if (status < 0) return status; - adc12138_wait_eoc(adc, msecs_to_jiffies(100)); + ret = adc12138_wait_eoc(adc, msecs_to_jiffies(100)); + if (ret) { + dev_warn(&adc->spi->dev, "wait eoc timeout\n"); + return ret; + } status = adc12138_read_status(adc); if (status & ADC12138_STATUS_CAL) { -- 2.54.0