mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: jaegeuk@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, Chao Yu <chao@kernel.org>
Subject: [PATCH 4/6] f2fs: avoid unnecessary fscrypt_finalize_bounce_page()
Date: Mon, 15 Jun 2026 21:08:20 +0800	[thread overview]
Message-ID: <20260615130822.2576088-4-chao@kernel.org> (raw)
In-Reply-To: <20260615130822.2576088-1-chao@kernel.org>

fscrypt_finalize_bounce_page() should be called only if we use fs layer
crypto, let's avoid unnecessary fscrypt_finalize_bounce_page() in error
path of f2fs_write_compressed_pages().

BTW, fscrypt_finalize_bounce_page() will check mapping of bounced page
before retrieving original page, so, previously it won't cause any issue
w/ fscrypt_finalize_bounce_page(), but still we'd better avoid coupling
w/ any logic inside fscrypt_finalize_bounce_page().

Signed-off-by: Chao Yu <chao@kernel.org>
---
 fs/f2fs/compress.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index caf522d667d6..aaa0813eabcd 100644
--- a/fs/f2fs/compress.c
+++ b/fs/f2fs/compress.c
@@ -1455,10 +1455,12 @@ static int f2fs_write_compressed_pages(struct compress_ctx *cc,
 out_destroy_crypt:
 	page_array_free(sbi, cic->rpages, cc->cluster_size);
 
-	for (--i; i >= 0; i--) {
-		if (!cc->cpages[i])
-			continue;
-		fscrypt_finalize_bounce_page(&cc->cpages[i]);
+	if (fio.encrypted) {
+		for (--i; i >= 0; i--) {
+			if (!cc->cpages[i])
+				continue;
+			fscrypt_finalize_bounce_page(&cc->cpages[i]);
+		}
 	}
 out_put_cic:
 	kmem_cache_free(cic_entry_slab, cic);
-- 
2.49.0


  parent reply	other threads:[~2026-06-15 13:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-15 13:08 [PATCH 1/6] f2fs: fix wrong description in printed log Chao Yu
2026-06-15 13:08 ` [PATCH 2/6] f2fs: misc cleanup in f2fs_record_stop_reason() Chao Yu
2026-06-15 13:08 ` [PATCH 3/6] f2fs: avoid unnecessary sanity check on ckpt_valid_blocks Chao Yu
2026-06-15 13:08 ` Chao Yu [this message]
2026-06-15 22:14   ` [f2fs-dev] [PATCH 4/6] f2fs: avoid unnecessary fscrypt_finalize_bounce_page() Jaegeuk Kim
2026-06-16  3:12     ` Chao Yu
2026-06-15 13:08 ` [PATCH 5/6] f2fs: use fscrypt_finalize_bounce_page() for cleanup Chao Yu
2026-06-15 13:11   ` Matthew Wilcox
2026-06-16  7:40     ` Chao Yu
2026-06-15 13:08 ` [PATCH 6/6] f2fs: remove unneeded f2fs_is_compressed_page() Chao Yu
2026-06-16  2:50 ` [f2fs-dev] [PATCH 1/6] f2fs: fix wrong description in printed log patchwork-bot+f2fs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260615130822.2576088-4-chao@kernel.org \
    --to=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome