From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFD0F3FA5F2 for ; Mon, 15 Jun 2026 14:21:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781533291; cv=none; b=S0pu8Ca8aY9wo9g/Q18wGvtTHWUVYO7axhS0JJZzmzxv3LVyTza/1HxzHCiImAOu/Q94EKOjwYsynZ4rmEf2taW2EBqhv9ohj/ShhYrAken0Z37gDB2yF88pxSozfTYs5AAB3DmN2MN2MkfRXqfVNlNXBaoH7BpJdtZ9vyIEDPM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781533291; c=relaxed/simple; bh=L4IGNbM7y1d+TqDRCJgF9JoD/da1bj3QcNTtav1CsvA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=p8TEDls7sk3gdUyblZAF3DqyhO9h7F2uPixEYjNQd0dtqr4fegOBO7ABwAo2jxnGwAeIXz+ziFaoKDRei9whrfOiL4zilRplWDVVEpha+cW5+Q9EaUuTsCCbXExdGqbhnXSCgwHE7teIDt27KmlVf8oc3nMSMhk+TzMu0XgszDk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ruPXGjEI; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ruPXGjEI" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-36b903567fdso3917850a91.1 for ; Mon, 15 Jun 2026 07:21:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781533284; x=1782138084; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xutruK5RfR43rmAYdiUjHl9bnTWIPbtUF5GMeFFCbOs=; b=ruPXGjEIbXyqSTqYMYJJpMA2xui/eu4d8fuPoG/5NX5JB6BIXyoDl34Uam91x3JJ0k DDa76ebc6FNkNlOZsqfDJrm/eE7M2+Sku/jm1xAQ66MAUxrwEECh4xmfFDpMkuDBMCH8 Qif5lwZCvpLhweg7i2z6/TJXT6AoTB/DZyUvQiZMNvAD2FkE6y9eKR8RmBATiZQgPQQr HJst6+TZRx6sYcSDyk4+AkO/2lOpMA3S4Pge17x4BMfbwQ1I+u/hPFJzw79tHIVKT/VD 3U40JZjfodnMzujU4WK7d70SjOEdWxeUnVLZsqinXGAlGYXFbzDssLYM/wxDm6qMSI/j p33A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781533284; x=1782138084; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xutruK5RfR43rmAYdiUjHl9bnTWIPbtUF5GMeFFCbOs=; b=UkyTRij4M5IRkb3N9F+2vSGnNXadZkDjvUgwW6fJoZwQLW2Jl52vQXVhWENJ+C1qXL gEely3ck8fe6qLfyU2DCfKIuNCC8IWp9p9wnXj7lQW+9UyXOUmCJAN2QeZOL+IeEVR74 rAPUd8G4lj1eYBactn5LRtu3Z2DZLUl5XunIen3whSDavJNVjprapmXYLLFBKeRNLLY1 0FIUiE4q4SQJ8d2Uqr5sxEETGL+xrTwE6H/8B7L+2hMEzy7Z7bHwEkjZVaAP2fWuY8Ho c3sEyMSDNxBHBSsfSbdjYY+Yk21kMTtLmPp1EVkX7V4u650GzqcVG4H/zjcnkdib6nN+ C+dA== X-Forwarded-Encrypted: i=1; AFNElJ/rJS52emDopY2+74FVvLIkRaTvKUdN0LBZuDvdTJupLvSf/PZpZGpZG0brV/4B5m6oEdFMHYLSmZOyEHQ=@vger.kernel.org X-Gm-Message-State: AOJu0Ywmp6IroWRNS4xGF8l58dGyN/zdRJHyCtwBxB/qxLBQWnscslR9 y5hAEMZHaI6x9ZcqVaoULrO8qOacjOuNXSgem6IS9mXpiMQtidCCv/tm X-Gm-Gg: Acq92OGAWgtD+9l/dXWt0W2DVIUkJY891fT7p0iRKY9FUPqnm3IateH9cDt4py10OFP mf0eClldoPJmUJ2GmyajpB2lXaaInIWNXCHF1uJDt6PJtvxBvlB+o9Y01VjBe4jgBzSOJKAMEyZ ilO+dywJD3DoZo+02Uorlvjj7FtQEdrpGt2We0pz+ftymk4QIKN6llbC0rl4FSioETIQEVpXrOM HxAsk62KG9bo5lfWxSKPYbgec6GF7798e8HlCceAFEqpsw82y2kDToi2/OpRT9uoG707DQme7aq P6+/olA3f5o4962U1aPrGGP6QyIKVqDgkP+3A2EWetcgNXrU5wR8u/y04Cq35w8+FCQycG6EN+/ TS6G8liajkfBxWaYOuBrFhb3OXtrDkjjZ0gMLWOdMrWT4ZagtnbzTtiJ8VEB11hbuQecyroXOoA CDZY2gdUtRhP5CaoxQ5xOj X-Received: by 2002:a17:90b:4ace:b0:377:4a58:fe0b with SMTP id 98e67ed59e1d1-37a01f335ddmr15548652a91.7.1781533284059; Mon, 15 Jun 2026 07:21:24 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a52:c491::1002]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-379e8cc467csm7178233a91.2.2026.06.15.07.21.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 07:21:23 -0700 (PDT) From: Jun Yan To: Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Jun Yan , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 01/10] Input: cap11xx - clean up duplicate log and add probe error logs Date: Mon, 15 Jun 2026 22:20:27 +0800 Message-ID: <20260615142103.352163-2-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260615142103.352163-1-jerrysteve1101@gmail.com> References: <20260615142103.352163-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Duplicated device detection log exists at line 537 and line 542, which brings redundant kernel print messages. Drop one redundant log entry to clean up dmesg output. Meanwhile add missing error logs when I2C communication fails during driver probe(), helping debug. Signed-off-by: Jun Yan --- drivers/input/keyboard/cap11xx.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/input/keyboard/cap11xx.c b/drivers/input/keyboard/cap11xx.c index 2447c1ae2166..485d8ba97723 100644 --- a/drivers/input/keyboard/cap11xx.c +++ b/drivers/input/keyboard/cap11xx.c @@ -512,7 +512,7 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client) error = regmap_read(priv->regmap, CAP11XX_REG_PRODUCT_ID, &val); if (error) - return error; + return dev_err_probe(dev, error, "Failed to read product ID\n"); if (val != cap->product_id) { dev_err(dev, "Product ID: Got 0x%02x, expected 0x%02x\n", @@ -522,7 +522,7 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client) error = regmap_read(priv->regmap, CAP11XX_REG_MANUFACTURER_ID, &val); if (error) - return error; + return dev_err_probe(dev, error, "Failed to read manufacturer ID\n"); if (val != CAP11XX_MANUFACTURER_ID) { dev_err(dev, "Manufacturer ID: Got 0x%02x, expected 0x%02x\n", @@ -531,11 +531,8 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client) } error = regmap_read(priv->regmap, CAP11XX_REG_REVISION, &rev); - if (error < 0) - return error; - - dev_info(dev, "CAP11XX detected, model %s, revision 0x%02x\n", - id->name, rev); + if (error) + return dev_err_probe(dev, error, "Failed to read revision\n"); priv->model = cap; -- 2.54.0