From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F17EB3845C4 for ; Mon, 15 Jun 2026 15:11:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781536281; cv=none; b=Z8ymthZQmYvXNtOR3zOoJ/hWH7yNRRymlwKw204Vv2Vxsq6MIksMIMRFtXFBSe3gwR2l5cvyAzMXshaJgu4zju6SVkuRclcboDF5no19BD9t7bQ3uewLbvEiUwSwwatMFjVlbbTIM4g0EagOA3wARZDphxXpTGxI6Oy54izwYXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781536281; c=relaxed/simple; bh=VL9zQWD8H1SjF2MkfF9+3rSYoioI+goB1u7B8YNFWgE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KDUM0tC0FZX1ZgWsmo70r8Kmx72yC5PYrfGmrsYuIdgMjn0+HkXenu44w6tEw4f092nlQFxkVrL/1056fqspa/NRy9DtObsuESylN/rop9PLrhF70HepNYlBqy1wRt+EOiEoQsYbuYhNekP89YKtWKuq0rINgpAxBzLDwjX1/20= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eihaTJ1Q; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eihaTJ1Q" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-45f3cf907ceso1798227f8f.2 for ; Mon, 15 Jun 2026 08:11:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781536278; x=1782141078; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=atumCYZH4kfixZGFrkvd6pjJYdqMUcUkjREboEVQyOE=; b=eihaTJ1Q7B/IJFzop2El7pLlsfO/+gXNCDOFQd819YFo48LLzMurThImyc2SgMfife OBoLtiuuOm7zTYXtpzu9BUkIY7C66qIanpOtkAeaOif7c8T4T1P5WBCxxKvyhVb2jRqE mMUBjTTeYePvx1PsmGDYqn+V9mQc+s6k+hemgx93C6R1+eDRajzuIpW8zqcs5ZBMCSNC qYMAkVi2P3IN6o6XXnydCYRW1BrJRWRYEQFfdk9qH7o/TX28riOAz0/WkuNSQeHMn2lp 7PBudttq9n+kxQu3eYqGFYXKfz/Mf0OT2wj7K0GY/kKjbxVtX1IwwXhZVHZnqYyvbPHo lWRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781536278; x=1782141078; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=atumCYZH4kfixZGFrkvd6pjJYdqMUcUkjREboEVQyOE=; b=jeT2c9rsp/Bh4hQKAX9VUVL35/bfb8JHLOlpf6hkBuZKXdiBlnlcA3kkCDO7rr3LZX B04vDC8RPFsLZ67RqD6XrehpfQYJ6wUW1UbV+TpWepA8lMJ/I+kLV/HOZFp+70KWnZnB KJHLjkXFkMNRZmuj4qzri7Hf3Lc9AoymdoN5HikgZfyn4TPD2TcpD1gTf7fvJ+vOHNnu cbqgdzAQt/n9e5iiAw3BxqVawAbPTILjq96VhDrS7OdYQjsLr56Ni0kNqtxF1YqI2zgS N0vyAlm/Uf9wEmWWfhUMrnENEPH2RWZxDS5Nl2IsRUfRouCcVfyyJKEsFtsssDpSTwFt PvmQ== X-Forwarded-Encrypted: i=1; AFNElJ/MgNbSNtdvZOGvgwYc4HCMFnda0Wflr9GDBRPNRXXE3JBRERx5FEkwgvD8vJsZTdn8I1ApT4f+RQGUXTw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+qkwD5t5aB9DrophQw/Sos2tF83irzNfJMSScOeyEiQ/zPEAf FlQkKfs/oSOSav9XZaefu/5uP1/+i/GEiFAz/StY5r+3NAbmNF4ic/r9kPcwmg== X-Gm-Gg: Acq92OFpLIBC4Rm+JGR+RnaZpyNHmUh2S+pgaRLSQDZvtLSP9SBh1wl5V+2aSDxTYrO DE0fUO4N1RdpRKN/kAZucybuNnNzfqxMrexgfp76mfndKAkIWtOIzdWPFk2rspiy/MTAhtMRSF4 QLzAuGgkYb8RkIgxB+s+wHK2nwM8Cr8fLO21mm2D0j3PBvQQqvncsbxMIkzJ6HM2C36aOUwMtuQ RFfz0R8kecOsPhMfoYdvDV2mpy5Q3ReZ9oxYxFvSB/PufBMmzOtxJ+EZs+iW8r4GihtXQ/wJJx8 8/xupM12Epr/o3Al/5YaXBmSiVlAkNodpj/VC2ogFhOy1fLegpCQ39gb6kqMAw2WqixSDFkDZU2 ctqUAcl56OwYIPzsKPcqxOS/PlFUWXluvJLowMH7xVnr1cu4lMKQYAzQeKLTwMkWLxA/uk2zaas +bzM7aq/u5vOfOh4whG1xtzViarsY8vFFFz3Z9ysMiv9JiAEZFDJZ1sUk= X-Received: by 2002:a05:600c:3b02:b0:492:2f3c:d0ed with SMTP id 5b1f17b1804b1-4922f3cd1a2mr6544955e9.30.1781536278038; Mon, 15 Jun 2026 08:11:18 -0700 (PDT) Received: from Ansuel-XPS24 (93-34-88-103.ip49.fastwebnet.it. [93.34.88.103]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-492203d08bcsm260449915e9.13.2026.06.15.08.11.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 08:11:17 -0700 (PDT) From: Christian Marangi To: Felix Fietkau , Lorenzo Bianconi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , Daniel Golle , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: Christian Marangi Subject: [PATCH net] net: ethernet: mtk_eth_soc: fix supported_interface set after phylink_create Date: Mon, 15 Jun 2026 17:11:00 +0200 Message-ID: <20260615151106.15438-1-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Everything configured in phylink_config it's assumed to be set before calling phylink_create() to permit correct parsing of all the different modes and capabilities. Commit 51cf06ddafc9 ("net: ethernet: mtk_eth_soc: add support for MT7988 internal 2.5G PHY") while introducing support for 2.5G phy for MT7988, probably due to an auto-rebase, placed the configuration of the INTERNAL interface mode for the supported_interfaces for phylink_config right after phylink_create() introducing a possible problem with supported interfaces parsing. While this doesn't currently create any problem/bug, move setting this bit before phylink_create() to prevent any possible regression in future code change in phylink core. Fixes: 51cf06ddafc9 ("net: ethernet: mtk_eth_soc: add support for MT7988 internal 2.5G PHY") Signed-off-by: Christian Marangi --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index 7d771168b990..5d291e50a47b 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -4960,6 +4960,11 @@ static int mtk_add_mac(struct mtk_eth *eth, struct device_node *np) if (MTK_HAS_CAPS(eth->soc->caps, MTK_SOC_MT7628)) mac_ops = &rt5350_phylink_ops; + if (MTK_HAS_CAPS(mac->hw->soc->caps, MTK_2P5GPHY) && + id == MTK_GMAC2_ID) + __set_bit(PHY_INTERFACE_MODE_INTERNAL, + mac->phylink_config.supported_interfaces); + phylink = phylink_create(&mac->phylink_config, of_fwnode_handle(mac->of_node), phy_mode, mac_ops); @@ -4970,11 +4975,6 @@ static int mtk_add_mac(struct mtk_eth *eth, struct device_node *np) mac->phylink = phylink; - if (MTK_HAS_CAPS(mac->hw->soc->caps, MTK_2P5GPHY) && - id == MTK_GMAC2_ID) - __set_bit(PHY_INTERFACE_MODE_INTERNAL, - mac->phylink_config.supported_interfaces); - SET_NETDEV_DEV(eth->netdev[id], eth->dev); eth->netdev[id]->watchdog_timeo = 5 * HZ; eth->netdev[id]->netdev_ops = &mtk_netdev_ops; -- 2.53.0