From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE3B521D596 for ; Mon, 15 Jun 2026 17:45:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781545543; cv=none; b=HJkxlOE2e/HsH6x7+klh+H/fYlCGs6lYJNKvj4iaUULIKIcmKrBCd/TINGhb0ko/oVkvLKzusmcbGybiIUo9ONIK0dKuVwhWH7KBYZJAA4c/2HwwpMER3CMVs9YBDt0wHg7TzM/KP3Pkk7ueJtycbgLYlE0XCKnM/f/G+/n6zRE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781545543; c=relaxed/simple; bh=Ual+FVg1sP1hRISdeCnWZofUMoPKpvVvuom2H7m3EJo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dbpJmZwajigVUisaz908NEXhEvu3Qt5viSz4vyvM4m9GcROKsgbFxJ/bXc+43/vMhr7Lhy68QPjojpzziI7rsoDn4NI5lau1iZEDTpugV6RAAOR9Mgtstdir7Y1hqfk32eaxn7xG3sghkx0lyocyd2F7htI+7w4UkIDLeoo5wVg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MQAk2MD5; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MQAk2MD5" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-91588056619so259806085a.2 for ; Mon, 15 Jun 2026 10:45:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781545541; x=1782150341; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OTBv6R/3G1uCLiky+ruAoiaz4p72UU1rBx31/thiEMk=; b=MQAk2MD5OF+e4O7zkID1TFC49YrxA/164MQiXs3881aNFKwrzRqetBj71zKrhZxYvL C75bJvKGysvQBDNCVydXaZxBJAtwMVWpZmW4CDpwBlqron/UmvpiMejy7coh4D2GNXeL B4hJz++dNX+SinwCVUO7yg+gKFX/pzeQGa2Om+mNQUQ3aBKXKiUh6zs14OKhZwHnilKe AMyFaiSO6uQVSgMYj3bWoXDaPUnR9PXgrdCpFH3GmC2Wb/blV09RDX3webQnf5zvKZ3k JT9+/S+cMn0PXjAvEKflzrsP4z3MVGcpC9t3Py0Ptzpks/W4Fts4vaH+h+RmYzrSlL6D d1Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781545541; x=1782150341; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OTBv6R/3G1uCLiky+ruAoiaz4p72UU1rBx31/thiEMk=; b=TCqxfnDN6ZaeLK8tJelAq7W6imFg80atVyObmKYGwwBXAYj9gZfaAuZKFLo1HHK7ah GyYRL/JcGPyZlw2cVPMty+QC9QQWJEhxTLg6drZ9WY2WNtxWaftkj8x8ygSvnpAA/Kw7 BRcHyquaOFs6R1OCKTWeWot51F+BG5N6WuD/9+H/VwRoQxpWv4WhvLY5sbgpkYr4N7Fo Bpcps2GDaxQkqH3WNzc7vxrML5tPxlnZ7l2eWXtdsJ0wPtCFE8rmrBvedqJAQ4P1iGHh wstepx4+7aRkhmMOwULf5dU5Gu/YLTqfLvkT+tMrLYYfHd76Siwe6mmIMccAVQKbDxJs qIqw== X-Forwarded-Encrypted: i=1; AFNElJ+/UivZbrFqbiW+NTukbpNdxYMlMs3vTJBuEGFG2rJXivwoC4SGq4bFAtQ8mXsD43qgma3OZsPwX1D9QV8=@vger.kernel.org X-Gm-Message-State: AOJu0YzhT8EOVAyJxJcyVB6rRsUr6vvJ7iHeSqBBTNMtG4EK58YB3odn 8huBVScyhKv+vWNrvfIL/aFLsyvc/VOKVom94sNxg5d8VvTOo89gkiWGXOQuKgVdFHo= X-Gm-Gg: Acq92OGf5XWGMOcjwixkIS/im8gkvT396WZ4felSru+0ahzhMqDXoAIXsLgVa+yL0oS Bvr0eHYsC8apM4ccxbJbOr2IEyPkcEy90T0NK3uabKXLe2Xp22KVDvg7FuEfnGAU+NgjQKfsUiU Jy3+fpkO93uT9n9Wo1IrZdlet2W8WtnTLHSGiapW/KJTD0+ahB6FzmfgQLHzaNeIoeJR/JbL8+u CQiDanMoWyGfMQu8xn/tUhUXpsbKWmizY8tTBfvqjJJXPE60Mcw0WEydl2rfxMWDzz+Juygc76b c6xVA56xfreIb0BwWqXpZhYbY6fbLVcQJ0euqdAR6O/Df+SRr23qC76xei9pKcu07edDMF/hvrA k4STX27bFDgzFNsG+/f7//YMM1DomNORBzfJlsql7ty8KxHo4LsCL8qFgXzxA0erodHLAT71DXQ 0WeGO553JlNkxMrKP1UJWTo3AYriRces8u4Y1aaW1/uiz6rsGsmo4= X-Received: by 2002:a05:620a:4688:b0:915:fad5:90a5 with SMTP id af79cd13be357-91c48a33205mr8247185a.54.1781545540422; Mon, 15 Jun 2026 10:45:40 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9161a035849sm1176338185a.33.2026.06.15.10.45.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 10:45:38 -0700 (PDT) From: Yuho Choi To: Frank Li , Sascha Hauer , Russell King , Pengutronix Kernel Team Cc: Fabio Estevam , linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] ARM: imx: avic: Fix OF node reference leaks Date: Mon, 15 Jun 2026 13:45:35 -0400 Message-ID: <20260615174535.701013-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit of_find_compatible_node() returns a device node with its reference count incremented. mxc_init_irq() looks up the i.MX25 CCM node for of_iomap() and the AVIC node for irq_domain_create_legacy(), but does not release either temporary reference. of_iomap() does not consume the node reference, and irq_domain_create_legacy() takes its own fwnode reference for the domain. Drop the temporary OF node references after each use. Fixes: 9b454d16e57d ("ARM: imx: avic: set low-power interrupt mask for imx25") Fixes: 544496ab5cbd ("ARM: imx: move irq_domain_add_legacy call into avic driver") Signed-off-by: Yuho Choi --- arch/arm/mach-imx/avic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-imx/avic.c b/arch/arm/mach-imx/avic.c index 3067c06b4b8e..6873a50bbe2c 100644 --- a/arch/arm/mach-imx/avic.c +++ b/arch/arm/mach-imx/avic.c @@ -173,6 +173,7 @@ static void __init mxc_init_irq(void __iomem *irqbase) np = of_find_compatible_node(NULL, NULL, "fsl,imx25-ccm"); mx25_ccm_base = of_iomap(np, 0); + of_node_put(np); if (mx25_ccm_base) { /* @@ -203,6 +204,7 @@ static void __init mxc_init_irq(void __iomem *irqbase) np = of_find_compatible_node(NULL, NULL, "fsl,avic"); domain = irq_domain_create_legacy(of_fwnode_handle(np), AVIC_NUM_IRQS, irq_base, 0, &irq_domain_simple_ops, NULL); + of_node_put(np); WARN_ON(!domain); for (i = 0; i < AVIC_NUM_IRQS / 32; i++, irq_base += 32) -- 2.43.0