From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8175303C8A for ; Mon, 15 Jun 2026 18:11:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781547075; cv=none; b=e2yiUWA6J2kw3gE4ezw5ghVdhJyWyi5vbS+QJZ4s9yvzHCXjl1G/o1nqLH59vaRmBiQTP3g29GaCfxFLf/RjEQF5mV2f+UpIgap23tguhTYwJlOqDk3i1134RXlRe2Tx0imKXmj2TW0DJpq6Qf1z9hzdcwx6eNkOD/jqd/c3Zx4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781547075; c=relaxed/simple; bh=PRz5HqABEFNqcItdRPhVqSjN9FdOe0gA+IYlzrwHfqg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gLhA/nl5YNnz1qVa19SiAOfD6TUZo544d1wy2Wn0DLYkHEFSkvniktf222XuJXPFLvB2O79ki3+BmYfaglgdWtWCGTuC5kRVg4k1FgInDG4icNrTg52TMkzX4Ff5n8OWM5SFMpQhTs3Q7LsfE5GCJx6HgwapEfdSfjBWvQXNSPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e36rgyIr; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e36rgyIr" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-45ef29c5561so1977452f8f.0 for ; Mon, 15 Jun 2026 11:11:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781547072; x=1782151872; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6YhHfYhZ56ymdmxnyjLOGaOGjwnoWlDkDUgcgUvLusk=; b=e36rgyIrOUrVa6GSonzh8FiHa1MPy12+v1Lfsz/RiAbVh+MJ8Noc6wXXMpKG0uWxJJ hwLspc0Zf4NDOcg1Xx9xWDzqs+oUHCEqJqlexCBfEFkDptUAEFmZ3hHpp9JEfaGhYQ9J zSEFoKrM1fqxO8kkXVFF62xDvvym5uZPC2GvjsjpFF7aT6j9sAhKtFe+4INpNJdO4UgA vxzSCA3CiYUqLQGEoxhQ2wKkpc1VhnUA4dWvViOJpaPxDy56pOwRi3kSQpjcDOL3Ae33 UwDzm9tPzFOp4x92kOR7Qs6Bv8cgo0HbdlumED4xfZ/itxuii+tIOhW4Aix/XQbv5cD+ HcoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781547072; x=1782151872; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6YhHfYhZ56ymdmxnyjLOGaOGjwnoWlDkDUgcgUvLusk=; b=GrVPOvmmkwg90mmqxxKXFE6r5d1553rhrkPmy2D4qL33xsIGJ1H7Q3WfDHjJqUe6K1 MI4SQdXlWpxc4+uXWN/kuK08Mi05MIJ7/CBuf3zSrsRaYfbagKeWCXz/TKeKVDiGKo3u a8do/hLVZEnF8DWe8+Evipyeh5wXUsPhGjSqH8V+1N1GUrYUjIZ/ri0jRmDbVdwZfEo7 qe1YPdUjHoifnWa7d3/6cpE8OAhjgF8P4Utc0lUq8YsrnqLcTqEaacMeSke2VFXPsPwK 5NFVgXpqPYzFZ1ZfsJz9fdIR4evfbmEoihFxliDsiLP9E5biKyXeJX8Iz2+wHcUXqOKy YCTA== X-Forwarded-Encrypted: i=1; AFNElJ+V0J9QziZQllgQcRhLH1vGvPXnU/B3LBe6aN0DgeZ5WhabxeFvaoxeGXGtG9K0mU9EJ+4HhIxU4Li470E=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/vSoCUqCda0LZAYQG+uSAMS94yYAPLiDMjV7qJ0FanfviBuMW cJPcdUE5VjC8AR+aD1hiQryfGRS1JzENzUlCsjkmXpGHQXZaL+SLUfja X-Gm-Gg: Acq92OGcjO0R5lmhga8xCweFa0JU73zR08WPF5V6Z6jzHTWqEG1wYx+2aonxrJK4hR3 SX416povmSbXsD56fqflOuiw4m/MOxSYgiNtOwEfNm7jiNgzgkqFX6QadcHbB1KVsWqHHOeIjmq SD3yzSK6ygA8zbzHe7h56WkArRzepi+GvlAFoeaJa5ZJ4y2ivXxMgtnMkKOdFG7T9v5jwY2AqwY OcFKrHA4N4FSvkef/fFUow3/U/Me4Fd91jVrhq3qNyLoJ1Jdkgfw6Etw14VI16+AUGSzoYAKgve FAMYWjf0MIylnzrua4uuAQrMLqym/HV6TThhuIMtbkOEaiK7J+oIVJC5bAQbbn7JnJ3HB9kmtMe MTstMjXpdm+tnjchW2VoVDC2vEbZYuBxeWAxG6HGWbP0LRsL4i5aXQ5vSHPEDj4oq6uvzVdPSx4 /1Scc/4DtCDKh2DZtRsXKnhAHFegxbTNxWUGmOLI02 X-Received: by 2002:a05:6000:4301:b0:446:96b1:f5f with SMTP id ffacd0b85a97d-46074a80071mr15768412f8f.8.1781547072261; Mon, 15 Jun 2026 11:11:12 -0700 (PDT) Received: from anthony ([2a06:c701:49b2:4c00:12ff:e0ff:fea5:3d2e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f263950sm37158556f8f.7.2026.06.15.11.11.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 11:11:11 -0700 (PDT) From: Amit Barzilai To: Krzysztof Kozlowski Cc: Amit Barzilai , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, javierm@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: display: Add Solomon SSD1351 OLED controller Date: Mon, 15 Jun 2026 21:10:44 +0300 Message-ID: <20260615181046.96655-1-amit.barzilai22@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260611-psychedelic-funky-foxhound-a8e39d@quoll> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Krzysztof, Thanks for the review. > > + solomon,width: > > + default: 128 > > + > > + solomon,height: > > + default: 128 > > Drop both - deducible from the compatible. Done. Both are dropped in v2; solomon,ssd-common.yaml already declares them (as optional) and the driver supplies the 128x128 default from its device_info. > > + rotation: true > > Either drop or reference panel-common (if this is a panel) or at least > reference that property: > $ref: /schemas/display/panel/panel-common.yaml#/properties/rotation Dropped in v2. Rotation is being removed from the driver, so the property has no consumer. > > + reset-gpios = <&gpio2 7>; > > + dc-gpios = <&gpio2 8>; > > Use proper defines for GPIO flags Done. v2 includes and uses GPIO_ACTIVE_LOW for reset-gpios (the SSD1351 reset is active-low) and GPIO_ACTIVE_HIGH for dc-gpios. I'm sending v2 as a standalone binding patch so it can land independently of the driver, which is being reworked separately. dt_binding_check passes cleanly. Thanks, Amit