From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F36E02EA171 for ; Mon, 15 Jun 2026 18:13:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781547221; cv=none; b=k7YySZDyQFPR/H5iFvVSPPYn/unMaRwSXVtrsWQ/wFMDOo8RyeYsHTX2CDXR/b+Mog0dlmfgpNcODjN0VTFxNq94qmqM5W5hasXkEGameVek16h4eijOUWR/BCqJCRxEdDVQP7oDM0gZSp59q8dvgyetxDt3scksG1JVFHy/LvM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781547221; c=relaxed/simple; bh=NuelC9P0khES2L+1lmze8qFEYD46l4CI3QqaFaENFBY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E6+1H7mc/kGYfxwYG16diyu1W3TJw1B9kYXAnc4ChGmX8iETFfN1qhIZKzDHk3U7xghm29uILZvJ7cOpmpgByHs7uwiZQR5nLDbny822g4SK9oAHvNQOYqRMjnK6AF3T/oSjQ+uR8ZTPMX/uQ8/WjZp//Sss+En+DouQ0EX9vtI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h93X0MJ+; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h93X0MJ+" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-45ef6565cfdso1727892f8f.0 for ; Mon, 15 Jun 2026 11:13:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781547218; x=1782152018; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CMIhznq4b/swPnkGP6rrvAKBGuzPasq5bzsDh1wVz04=; b=h93X0MJ+WVEnym26JOx5tp8X+RM+6tEr5MCUkPdDldj/U+Jcmmmrass2wFYtKyuF4j xeeo+yxiEPJCZQeBSi9j7kvyaZc4IdddmGeVSvzEfSSeRlkcqFT/MN4w13gJmBfsrzG1 8axv3Ln61ng7DAr7endnrnw/CTs4a4TaFgjveD8xAbGsCq5+bFnr1oFG6/+JsX+K3h8B TT4Z/Y5fo7JOoLrgcX/RzIZjJQs+0gYv8dZFCIt1RIFaI0VEM7Dib4aJXZ31M1irKmsH me/BmCHlIfsAmxwweW53jP6PZbtb7WXau8FfR8bAd7nLR77x2KDJ29zx9kGDdkPMd7TD g7CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781547218; x=1782152018; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CMIhznq4b/swPnkGP6rrvAKBGuzPasq5bzsDh1wVz04=; b=F2RzdYO+6mbBLawPHa4LR85m0puimZSckCfxqxcbIeJcHgK+8MnSxc1b0ursntJNJF rCrP0j/1rJLqPjU7WPsBZ++gW/Q/RuUTyE8x90OhZu3dyLIGowv6O3/VYbt1pEgwOt8U kXTbcYs+3AP9OzAR9JCCDlAiYLi9a2KlWQIXLFVLsIJJUBMCz2ZoJ6YvK2igIcRCOFFz c6suYXqqtkZEe0QhH0sRygDLS+nZKHf2VhJdVx0Pqq9/s5wlLSi0bIxcuyhX+lHkAo8H /lD6pvw7zALCirkxs00dgTVkV7ZNpZNDq7IO0xnNp4UZZQ0A2NdNKT4a+jSjjw86yAQz iMRw== X-Forwarded-Encrypted: i=1; AFNElJ9TmGrxaHLZyCjAKPRCMUZ2v7MjRN9tGPsirbbvgmKti+lxfFPy+Vl3XI9zD23zFYOyeoiffE3OKYlvH9o=@vger.kernel.org X-Gm-Message-State: AOJu0YxAQtcwtW120L9qm1vTCFfQ5F2TXcsAStoujpkqvGRfQIJC9y3n qKeDpjKJYbvQ79mWhVJIdUkE/UmLQowafIQSWRIyhSW0FpkwKiwDt4cA X-Gm-Gg: Acq92OFk6FWbMJcMNaasl1E5WXNDo2mlgiSsR17A1iFCSQxs289Rc3Is96VLFx9Ux6Y cJBsnezARHq6Vx6ZychOkW/Gpt5eN4xCPQGP2DJeQkeHRPrJXPAdi9/vqdH5wyaC6x0Mf+tYYRJ hOuRxg6mhAl3q51eOe0hgZX0KgN0/TIkeTodkcQgH8MAylLy5BU4N7o02OEAi/B3XumICLH9CJl 5m+gClGdj/frbd4du7ZPepG2ftiZEj4dSeLA1rCwiSdMpBtITbzKrlEqa80FerREVvI1MJ6bgPr 5RGwG0oFHOqFtMe9nw4YwzoBfN/qTWAxb/VAZ6g8YPbOoBdRpvGunPLE5Si92PdsQg6IjkSfrEO skfGB8AK32J6wYWO0qo1LmiWDDVRLNdp84TSxX9WPP4dUX4OdK+BPK65vYKaO4r6lGTUxB2yCWU 2ibfNuI+yH0EfkJDzbM4qhyCwcW2kaFlXLwsPEmkpP X-Received: by 2002:a05:600c:34c3:b0:490:c2a2:e91e with SMTP id 5b1f17b1804b1-4922ffc0622mr4405035e9.34.1781547218243; Mon, 15 Jun 2026 11:13:38 -0700 (PDT) Received: from anthony ([2a06:c701:49b2:4c00:12ff:e0ff:fea5:3d2e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4619b9b7750sm8954343f8f.6.2026.06.15.11.13.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 11:13:37 -0700 (PDT) From: Amit Barzilai To: Javier Martinez Canillas Cc: Amit Barzilai , airlied@gmail.com, conor+dt@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, krzk+dt@kernel.org, linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, robh@kernel.org, simona@ffwll.ch, tzimmermann@suse.de Subject: Re: [PATCH 0/2] drm: Add driver for the Solomon SSD1351 OLED controller Date: Mon, 15 Jun 2026 21:12:49 +0300 Message-ID: <20260615181253.97551-1-amit.barzilai22@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <877bo576o1.fsf@ocarina.mail-host-address-is-not-set> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Javier, Thanks you for the detailed review and for the Reviewed-by on the binding. I agree with folding the SSD1351 into ssd130x rather than keeping it standalone. My plan for the v2 driver series follows your two steps: 1. Add RGB565 support to the existing SSD133X family (so the SSD1331 gains 65k color), gating the format on a per-variant flag in device_info so the existing RGB332 path is untouched. 2. Add a new SSD135X family for the SSD1351 on top of that, reusing the ssd133x data path (the update_rect window logic is already format-agnostic) and adding only the SSD1351-specific bits - the 0x5c write-RAM command and its init sequence. I'm deferring step 3 (native 256k color) for now since, as you suspected, there's no matching DRM fourcc, and I'm dropping the 0/180 rotation support to keep the series focused; it can come back later. Two things I'd like to confirm before I send the series: - I have an SSD1331 panel, but it is currently unsoldered and I don't have the means to solder it myself. I'm trying to arrange testing through someone else - I can't promise it will work out. If it doesn't, the SSD1331 RGB565 change would be compile-tested only (I do have SSD1351 hardware to test the new family). Is compile-tested-only acceptable for the SSD1331 part, or would you prefer I hold that piece until it can be verified on hardware? - Could you confirm the RGB565 byte order the SSD1331 expects? The standalone SSD1351 code used big-endian (drm_fb_xrgb8888_to_rgb565be); I want the shared conversion helper to match the SSD1331 datasheet. Separately, I've sent the DT binding as a standalone v2. Since I dropped the width/height and rotation properties per Krzysztof's review, I did not carry your Reviewed-by forward - please re-review at your convenience. Thanks, Amit