From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDF2838B12E for ; Mon, 15 Jun 2026 18:59:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781549987; cv=none; b=ukxQWNakPFQ3mL9LCI++dPXu8FFZbMZRUbu2b/JHc9PE+6tF1koS3rbcNnby1ltPtQsNJc5vYjCHEWStNmzgaTw5Ka/D8tULbgputcjrThsvRMIY5c4dcLiCpdBonG8rV2JwoSB8zBCacrZvWTSdFpsuYbTLoVrZZuYTqKznzAE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781549987; c=relaxed/simple; bh=MQnOO5q7f8wr28mb6m2bfGXzHIJWSQaGpDfj5bYpUEo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fDhE//Y9OdNPr5wLvGq8LnbMjMZ7Q5Qg0zh4C7D32Y2zzdTRJR/7QQQPns5UA2L6z3TgGf0U0zE31Fn7kztPrftEwgVlmHT5Q6nwXu+S32SzpwREI8SRtgEG14Rsu/xG/3+8PQt/d41Rg8Ijk7Wleo087IA4YVHr2z7mSpfTIKw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mzm0f3bA; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mzm0f3bA" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-91574384cc2so431585685a.2 for ; Mon, 15 Jun 2026 11:59:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781549985; x=1782154785; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OsW5XuxVwM9FsQk0onouamkx26JAISpKvkEL/UuxvOw=; b=mzm0f3bAReUSZuK0U9y99u7noIoCiUStuFRNsTMO5YQb3WW4MDCAN3B7cSKHmlD091 gCclRSkCdKwqXKro8WuAEh1nNOD+5eKUyHBUnbRB6332Ug3VkCdiNvSORrNjSRJUrERn lSx1mgbm8tlRSHunTyCcw9cXeXP8KJOJGB1y9bJoCsAzHMKkRK74amAs7UQGhJbhayBi TXTI6ynHWAfyK5pTwMGlt7UOMKKso1WftbgKq51hfu9tpHg22yybh861TfSpdoH6hJv9 mTSELeliZspJKx/RUk2c2UPpk7r6mvEfDxTXIGGYRYYx1td5aa/+H0p0CNJbcyNfA2W7 6dJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781549985; x=1782154785; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OsW5XuxVwM9FsQk0onouamkx26JAISpKvkEL/UuxvOw=; b=UHZRz0LtNZ2QU801U6vWkJ+60FeX7nGxNkXJk3dYL0O7QGVItKSgc5V4yQmPCNdJe4 P9HlVmPCkqJ32KlxBxp4B7f7GxC4UxFjHJUh6+WOBeEGyxHYVzxf3E+aYbRqv7Lmv/Z9 X6fW9/JppId1Lk0keiDCW1um0WTPgueXdEiIpEwklgYbORe7MBmOyDDoDhCWieaYNvPw apP4tLexPvQe1MPH2+hghl/hXvXnQJdQunts8IHOUBr3abAAltzUAJp66aqeWFmhA+jB oyacBjJ5r01dPCiZRwv83BxQn7AcZTk8Pd+X39XQT768UUnoOZqjKimnJwoZm9lV8c7o jo9g== X-Forwarded-Encrypted: i=1; AFNElJ9OZDkUpwed0dhC7KUJMghiyM2Q2YbO+hi/9BXYujog+6vtTWq3pdzQfRHWEMA4fvnUt4g/ocECOxRNDkc=@vger.kernel.org X-Gm-Message-State: AOJu0YzbIS5qydxsRhMZu/WXM63xPsds4QbpRXg9fhwfukUB67JSat7V qxqAtau4CWKTUwuFIUT+ggkOZ4xTv4ii+3pI4PuzuuoFciBGA7kC66Ki X-Gm-Gg: Acq92OHXVldaHnTItqtwzmrCf9wH+OHuuejBrTa6e4ZriU6WIYVZkdMDTbNVZpb03x6 KoO8DnahZcOEPdunPFRRBs5GoyRQmfajdVZ5g+XWbC+dCzxgHlG21QAsXXOanJ/oC39BwraqXkD 6/ZG3y7evAy/rZCGce03QaKY+NB6FZTxePuOk8zhOWFeLd7EVXEbuYR6nXwlz/QimCgSlE8Ebnm pN7GJyXWtJA6r+WRhVYsvKgfRjMJ3sZi3SIEBdIHzx215zsYVmd0wf2yuLUjo2kI5foV/hGcjKN ZmMC5OQfn+uM4jZImoXUfs87KD8NuMaqMG6r7OUG+7uWts0DDwpOR8eHkj021plqpNuDjamF1Jq lhGnmRy4ymsXnP/e+ZX0IOY3EodATXzpPdF2tffscJm8HjHgBIaqp8bG3/iWnzQ/4HRmCTXJPB8 6U1BtkS+CSFq5GAoK7ppoiyTqSY0aeMW4FzRPqiJa1 X-Received: by 2002:a05:620a:6cce:b0:915:72e0:688b with SMTP id af79cd13be357-91c27000a51mr141341585a.50.1781549985553; Mon, 15 Jun 2026 11:59:45 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9161a03d6fcsm1145507885a.35.2026.06.15.11.59.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 11:59:44 -0700 (PDT) From: Yuho Choi To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Russell King Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] ARM: mvebu: Fix CPU node reference leak in get_cpu_clk() Date: Mon, 15 Jun 2026 14:59:41 -0400 Message-ID: <20260615185941.732764-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit of_get_cpu_node() returns a reference to the CPU device node. get_cpu_clk() only needs that node for of_clk_get(), but never drops the reference after the clock lookup. Drop the CPU node reference before returning the clock, covering both the successful lookup and the IS_ERR() path. Fixes: f6cec7cd0777 ("ARM: mvebu: remove device tree parsing for cpu nodes") Signed-off-by: Yuho Choi --- arch/arm/mach-mvebu/platsmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-mvebu/platsmp.c b/arch/arm/mach-mvebu/platsmp.c index 18384ea6862c..0f14d7376770 100644 --- a/arch/arm/mach-mvebu/platsmp.c +++ b/arch/arm/mach-mvebu/platsmp.c @@ -42,6 +42,7 @@ static struct clk *get_cpu_clk(int cpu) if (WARN(!np, "missing cpu node\n")) return NULL; cpu_clk = of_clk_get(np, 0); + of_node_put(np); if (WARN_ON(IS_ERR(cpu_clk))) return NULL; return cpu_clk; -- 2.43.0