From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C53AA3AA9EF for ; Mon, 15 Jun 2026 21:04:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781557464; cv=none; b=SwKQrR27LS37FEIuVyyRxOKWHBlgBvhBAMJWYQNZhLzDGdO+7tBoHZpgUcckWN918S6el9gYAbMS2yHGEq8mUXDurbCGhbDvgagz1RPDuOQJlPGw1UGNFRog1XQT60YTj/5XBTTvLUZsqeLv7PF+ZoLeqiKtrvsUic3bfYjTAOI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781557464; c=relaxed/simple; bh=ewSyNFkkJe2M5TEKdnG8Cn1riX+bCh08goHnowRZcc0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cQBH872WdCxkUPvmexaItrBF7PNyXHJ5GBqG4W/uokKZ1lTMLSTLZ+JuMIMFN2jny2lnzsuCIAJWyy0+CTjjr461Vjoc3e7TPzFXEbPUImxNEhWg39Fa0l4zmOsHv4InXbKfm9UnmQ2PXd0qPcgO8tJ64A1DQYobYhqDKhmTqfk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TRUTQ27U; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TRUTQ27U" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2c0c35980fdso39349205ad.2 for ; Mon, 15 Jun 2026 14:04:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781557463; x=1782162263; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ey2mAPNyVdR5wIhMgKILVqinTrDRQXxWuXDknth4zFs=; b=TRUTQ27UjIDGCrg/ArLIgxnLcSx9tPZ+SzXv/eCgv6yPqf1cIx16xdyn07Dil3jAhq WxxcDdNrJX1TTraTOerBnjj9lDrn5SphLsVsXX/UQrR7H69bdi1xMB4VhbTQwkkMLpfP TqtYJ6k/ifk1S6CvwbX7HXnL5EfKUiFPY83COZYCKLg8zjVeTgbSQ6dSkCw+frHiEZPM 2vSP4nXCKC05hgBig76i8qPigBeAEtCwBZ40zGcqARZLnTkUUClkg5Y9TfzP4/ejQfG9 yUhLERytq04naPYKqm5wTzSiUAlCn+iP6GFWcPc7EIwcPBS6+NxLn8qSgG0ojXqQh5ai uPsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781557463; x=1782162263; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ey2mAPNyVdR5wIhMgKILVqinTrDRQXxWuXDknth4zFs=; b=KiSzmTvm6q5VR8DCHuVOQLT4qfCclzU9eoNt5UNNthxeWF+R8kwOh8SHcYW5d/onnT xoxshpn1jjd9zFVX+FGoLgyUEgb/9ik8vD+oRntE1sTl2jYJlsHff6arKxPTueC/9d8C xrx/UoiBs2w6I4QAp9AYLJFp6QDaq4uXmoxXPn5sTM0UWHrLHAe85pkQXeU0gRZPsvFW CupsjgwoMQeHw64puxmpH3baZRx0Dyvxp/diyndJbwiR7BINxeQBE+OyxTgV9kXgooK0 e14aIvkBt7saXYRH/cSlJSJI5Q/xM8K5TCrtRFa+C6hn1P1wR5mxh3tZQMFdn7RCXdGk CwGQ== X-Gm-Message-State: AOJu0YyPvDOQz+iiQJDXfbCpSZU28Vrg+fDg0j2CVEl97f9MVgOU+lyC HjVhvOaJ/fZJIY6UqsIiLaQMBV+Io83tjIosDs2wawLA6UNpGRG+OzrFcd91p/A4 X-Gm-Gg: Acq92OFqoW8uCHuoHjcgxjSwLX18TugxLdrcIspSdGOWaWzvoTxGqO55eBKZfnDqiB6 figpiFTYlrN7FwPQlvww5+VG7v9hexMyTqP9yOzFrv5FxqV6+GNl6kp4V/TAPVsbxJo1dHD3l0M ceKu5qkl71mx/BTE/+nuxL1loMe7o7V+VbFuqZIBFp4Mvy10yDI8qsSFmdiDCeJzYNKc1dEQbCt k4QR18Y1MGVGVQr0719TjvvmnDJ1Mk8I1VUHq7lRXHFFZjc4geyMaUuFROGV/EMNQKaa6vsfbu2 c0kaFAEpguipqdtdBAjKRBqoNyxUKMSl8Prp6iwSZJHxVKQF7nDXkxpBkPjzxTLO4/MDjMfagHp /pabAmmC8xrBooYMwPz5hForZURHSRHGFVQxFKxJ0W7cASW25TOHkuzs11dXmUCAO53MpNzrskE 9YlXpXyj8/L8ntIauUeQaP9P5c0Vr/KhOj4D2EyhoPxb/bCtuF6FLs X-Received: by 2002:a17:903:19cf:b0:2c1:1a22:7c43 with SMTP id d9443c01a7336-2c69a19ac7fmr8481265ad.24.1781557463231; Mon, 15 Jun 2026 14:04:23 -0700 (PDT) Received: from localhost.localdomain ([49.207.217.37]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c433747ef4sm110934085ad.82.2026.06.15.14.04.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 15 Jun 2026 14:04:21 -0700 (PDT) From: Biren Pandya To: Sakari Ailus , Mauro Carvalho Chehab , linux-media@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Biren Pandya Subject: [PATCH 1/2] media: i2c: ov7740: Fix use-after-destroy in remove() Date: Tue, 16 Jun 2026 02:34:11 +0530 Message-ID: <20260615210412.34567-2-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260615210412.34567-1-birenpandya@gmail.com> References: <20260615210412.34567-1-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The ov7740_remove() function had a severe teardown order bug where it destroyed the driver's mutex before freeing the V4L2 control handler which relies on that mutex, leading to a use-after-destroy kernel panic. Furthermore, the driver explicitly called v4l2_ctrl_handler_free() and mutex_destroy() sequentially, but then called ov7740_free_controls() which invokes both of them a second time, resulting in a double-free. This patch fixes the issue by unregistering the subdevice first, and relying exclusively on ov7740_free_controls() to safely tear down the mutex and control handler in the correct order. Fixes: 39c5c4471b8d ("media: i2c: Add the ov7740 image sensor driver") Signed-off-by: Biren Pandya --- drivers/media/i2c/ov7740.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/i2c/ov7740.c b/drivers/media/i2c/ov7740.c index 632fb80469be..62c124a1353a 100644 --- a/drivers/media/i2c/ov7740.c +++ b/drivers/media/i2c/ov7740.c @@ -1116,10 +1116,8 @@ static void ov7740_remove(struct i2c_client *client) struct v4l2_subdev *sd = i2c_get_clientdata(client); struct ov7740 *ov7740 = container_of(sd, struct ov7740, subdev); - mutex_destroy(&ov7740->mutex); - v4l2_ctrl_handler_free(ov7740->subdev.ctrl_handler); - media_entity_cleanup(&ov7740->subdev.entity); v4l2_async_unregister_subdev(sd); + media_entity_cleanup(&ov7740->subdev.entity); ov7740_free_controls(ov7740); pm_runtime_get_sync(&client->dev); -- 2.50.1 (Apple Git-155)