From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f196.google.com (mail-dy1-f196.google.com [74.125.82.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70FDB34E74D for ; Mon, 15 Jun 2026 23:44:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781567043; cv=none; b=tn/QPCgiFdyBNz4W2r5B2xHjt4uqMvwDhpPWbD3G3Inar7p2oRbbhDIfygWs01m7ReoJ/lPkVGXVTNLpjs62YEzHKH82Uyi96cy79VJZYXXLV4kdtYbF5eB9Kof2V66B4CjMUuxhsrO8mT4d//VLFmD7NlWwn5tytMvNLpWCmek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781567043; c=relaxed/simple; bh=GGAV5Bs+klUPVkudLojPNBVoQ1862lo0EbXYz/LpQaw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nRJ4HNZMNJMn1BjlC8DAhJFC/7Ut3y/dZ3f9E8bPM54VlWJMC0KbiEUj/jaQx/10BHULUoNJ8MK11/du5nReyJC1CsGjY9L4xHGEvQfyH0aVOkBlGi3vkM9DIlZP4y8ES2l4kG3rbdE2tkanQ/+h7UjC2yp1Dk4Y7FA4Il+IQt8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qEOgZm7B; arc=none smtp.client-ip=74.125.82.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qEOgZm7B" Received: by mail-dy1-f196.google.com with SMTP id 5a478bee46e88-304fb780deaso4097055eec.1 for ; Mon, 15 Jun 2026 16:44:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781567042; x=1782171842; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lJEo/vTjAgusuqqxFMwIrCPx+m0XRfNRvmNhqxqv3rw=; b=qEOgZm7BY9iAtpNARlFIm9SyoxPwabWMkd8m9eh1gDUrEZjgJI6hI0IOi5MwUBAqFX GkJIOnPg58Hqr+V+pYh1DoNj32pdcDjS6QrxqmQNx4yOpUViK0zSlKo4n3vXS5jPY/GS W9BP//YeasVSZhMy4j67DaI/MQgdY69B13Kzac0zByn/6j+ZMQL39DSYGQHvAo5UwEgx eCkWcQvMg3+9ar+/dxV9S1CWmPY3qvFRsf7R8XF0WLdqx7P9mvtuc6n8nnlwOz1MHu9J u9N9burEymkv0FhpdZk5MiJgoYW0r04dRZvDWORLcutAedjIIA+Jh1cXLCXxBaM4nrEt FsGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781567042; x=1782171842; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lJEo/vTjAgusuqqxFMwIrCPx+m0XRfNRvmNhqxqv3rw=; b=EQ6cSGU7yDwtLCkBNRWfInLv6X9H/jm7yN9v8mJK2ILBr7Lo4E5/lIfWk6BaYdA4ve f8KjrNooQbUC85d/jMhEWFhZmiB6GB5x4q2cnucA/bqWsPj7K/13FZOfuNts2c4drtbY E40gEYU+2S3mxs2C/jNh01Dr7wUJGgUpxjwge+2A2ZpPt2SY/jI6213efkMj03OzkVYX sWn/BR8Nzqo1tahukog2UFTr2PJC+TUWs/CEGL79379Zfd3uuTvt12IsFf5XepMhzxxQ QxzsjanHzAAcp7Ea76o1Bp6u3BrXgR5zRQ81x8SWn+1NY7ETvmT52T+YQqhy52EaBK1d X55Q== X-Forwarded-Encrypted: i=1; AFNElJ9aUN2Gb1kFQEQrpODnJMto+QBjcoGTioiWbzU+o8ldg3gMy45mSyE/WBLfmzD4EFcIWQq1xGuh/vNA9ew=@vger.kernel.org X-Gm-Message-State: AOJu0YwGdLR9103sk8lGc+msav8M0RCSB3xL5czQS7E8RmlABWgmFdNy Lq6MEwDK6WkT0dSRqklLjGCAdqrUF+R8ptbcv8t56w5tKlPgzJXc2BwR X-Gm-Gg: Acq92OHTh98tQvtdk8ozBXDylGszgsiIR/7fHXlDRVJP0b2l/KpqhBYTcETP+V4AGyd 6OEyVeepscofTMgcBqUrFuJlJHr8oIZD+g2HNjdjcFZGqOz556MCCMh+wauUUpeo788bJvR1Abz F/83dLBASid+t2ivsjfmt4iQ7Vm/AobsYdkRIpEYGgPkeSA2U/lar3sHloA9Lm0ADhn+HCKvCJw vYd2L9ReuRpe/+XwcF0WWTGu/SqEsp5zjWCtBM98JoT231KOFZEytN8XgpKeFuu9rwEOGUitXCY 79CasZ3qL3FoVs/BYqhbYmD+btq9fEkCIHC4OKSwTgMFu5HnMq96NKKZSojWmafkhytgqJXjtwf z95jRrs4xnow1TXFJx4+8etgzUuVaXpqg7dJcfgWMc7BkS4KivhlLTC82VKGhyfo8Tk7sEMLcbC BPNLEWOU8qtmOKtp53uSEarR3Sn4Yz1p3sOAdwqdLZBpBxaaEa7udyo+g= X-Received: by 2002:a05:7300:641b:b0:2ef:8b72:1b9 with SMTP id 5a478bee46e88-3081fcd0213mr8007820eec.0.1781567041600; Mon, 15 Jun 2026 16:44:01 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e92096esm16988335eec.15.2026.06.15.16.44.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 16:44:01 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: error27@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v2 3/4] staging: rtl8723bs: convert update_attrib_sec_info to return errno Date: Mon, 15 Jun 2026 23:43:39 +0000 Message-Id: <20260615234340.97299-4-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260615234340.97299-1-dennylin0707@gmail.com> References: <20260615234340.97299-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert update_attrib_sec_info() to return 0 on success and a negative errno on failure. No functional change intended. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 69b6d3a2554a..0fd2415e7bb7 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -505,7 +505,7 @@ static void update_attrib_phy_info(struct adapter *padapter, struct pkt_attrib * pattrib->retry_ctrl = false; } -static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *pattrib, struct sta_info *psta) +static int update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *pattrib, struct sta_info *psta) { struct mlme_priv *pmlmepriv = &padapter->mlmepriv; struct security_priv *psecuritypriv = &padapter->securitypriv; @@ -519,7 +519,7 @@ static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *p pattrib->encrypt = 0; if ((pattrib->ether_type != 0x888e) && !check_fwstate(pmlmepriv, WIFI_MP_STATE)) - return _FAIL; + return -EINVAL; } else { GET_ENCRY_ALGO(psecuritypriv, psta, pattrib->encrypt, bmcast); @@ -558,7 +558,7 @@ static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *p pattrib->icv_len = 4; if (psecuritypriv->busetkipkey == _FAIL) - return _FAIL; + return -EINVAL; if (bmcast) TKIP_IV(pattrib->iv, psta->dot11txpn, pattrib->key_idx); @@ -596,7 +596,7 @@ static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *p else pattrib->bswenc = false; - return _SUCCESS; + return 0; } u8 qos_acm(u8 acm_mask, u8 priority) -- 2.34.1