From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f194.google.com (mail-dy1-f194.google.com [74.125.82.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C6C0351C34 for ; Mon, 15 Jun 2026 23:44:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781567044; cv=none; b=EmseZTY0vsCV8jgDNM+06i1ko2JF90uEEI0bXXRz3jmLOXA6hwAwOF8nFSchNYcBYA5hlEKRS+CDs8OkHruJDgcb04yE4/Ey5xAmEkkpn28vi6TMXjSMhGreqjmp0ihVoeQTuqiG9T5su3VR3Got5aPuLtSLmCyjq9lUKOTT/q8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781567044; c=relaxed/simple; bh=lpCGztzB0M+oV02K6JezYWz2x0x5KRqyFcOocnIlTgU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PjhuN+hQ+qbQ7UPwm+cbPN8UJ1qrHDXmO2s50SclftJ1+9Rj/BrbSuESx7puQRPhhlRZGh0PRd8Pyegrt+1MGaMzDBEAxbIkBFN9vwIOCe10tNSx+Du3l9bjNXZUSg/qQYWLR2AgUbsAgGlcGgbheB5u+IbgiNcP902JdckED4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZM+6xtcd; arc=none smtp.client-ip=74.125.82.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZM+6xtcd" Received: by mail-dy1-f194.google.com with SMTP id 5a478bee46e88-3074adb8fcaso6433212eec.0 for ; Mon, 15 Jun 2026 16:44:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781567042; x=1782171842; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e4SHLN/exFnBg1lCGc0xPmy1xjyK1non5IlHXkrwXcY=; b=ZM+6xtcdjeh/zBbqPmW/R5Ax9YM9nWz0w/b1VVROZROQAxN0OPfjPUMwI8a5ENkC6m IYnfUUvj5kxwH3cBbuQNYGwGpLZJAWKpDNLhGQrDcOgysvfrrS+kCRBCm7FXmHS6OjuV G2JkEZMjHiy7EKMsBVqzxPcPGcMGGsZUS6lICEYue0ovDr34iw3575ibXBJmKg41jg32 EBVIYhPw5ianW7cB7+7vLkFQhJfYYC0oCO2IhToBGQQ7/pTzdsoas+IfKcCKGuDgbPmS VomKUKOP/a4Pl0dB8UIPPULjQQxddjeKbOLtz8xs7G20ponuIs3i32JGMl0qJllt7YH5 tcfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781567042; x=1782171842; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=e4SHLN/exFnBg1lCGc0xPmy1xjyK1non5IlHXkrwXcY=; b=srs1gPMH6fWusXVVF7Jc0hYamaGu8ahvcJWgsjvoSvs07B2LShW3uocQJEAaPrJYrd JxM8Wr0TN31guffiZMzBZ941PkL5/tYkHqEi5l7IgfDtiF68+ShoboMXNfR5nysx6gUx mNQaigYj9PfzPnopanROBu9LEBFKtqc4plGJA0eNCpExw2jhSLWYCGZJ62DqT++Iv3XT GtxCevmMFY8oxyO6Iqo7elD4/0tfAPxmClr3nFv2S8xUEGrMVTSvW1SS9Y83aWEj5SPl FytLurirSWYUeLY17r/X0BL80KMk8AslJpA+4PAa2JR/GuekGsW+kMDGJ1ZKmqGWN9zf Uu5w== X-Forwarded-Encrypted: i=1; AFNElJ8h+IoqoEu+zkHSi6PGZRSonRAwiT67UN0WQH8wu4kMxXDoAB/zEkc3svAherXsHvDLR9g+2X7gntimwAU=@vger.kernel.org X-Gm-Message-State: AOJu0YwNXz/0MDAD7bKibLGAjcAcHjbCTjpUUBodO1IkMqUEbxdqlmrb V2A4ZVAu52QpTt3OcYgfWOgdL6ejRHMor89xxM9a67p6Iz7cEC3UN8GK X-Gm-Gg: Acq92OHBvav97C7qBcI3NZ7yr26E7zyXK3ys9N/3wA60/VDiQIrGt6HbM1ZFevpONbK cR3E68rJ7tcNXaQnuoNRzhk+Lmqr8ai0pbdWrUEgXHALG+y74ZKBCBW2FM/ZCb3hfei/9vqmsMJ oVsmZyP2cXb+sIKc5Ss7w2JzwqqB0MRAm5P8D80MoY+dK9sF4eATPZePjRIs4HUrtjsLPt1NCqh NOUMuAZdLJQphs4OAoblxIGybsX2wSvrtNrGbhCHZQITyq/VP9FgDLzwCxSCEKGHNyPq3CUVZhB I1W8Z7ViZyAOkzV+atjPYKrvfWaub4yEquY95Nfaonvk0aq6DjCS20mBiffxxh/TFxjmNWSYZtk HqotuFM8eCxR2gKsVKiJYoYZJBZCqQ3ivOIjL0qTJg+Wj6tRdSm7oaraorAw1HYe2NW/5cbq7Vl ThD9mhWueEG9P1dWWlLAYnKkRl7PgMIMApH3ijbk1nhZqofX29H8a1x/l3nU4uUJrcQA== X-Received: by 2002:a05:7300:6417:b0:2e2:3381:2fba with SMTP id 5a478bee46e88-3081ff64166mr10133350eec.3.1781567042346; Mon, 15 Jun 2026 16:44:02 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e92096esm16988335eec.15.2026.06.15.16.44.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 16:44:02 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: error27@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v2 4/4] staging: rtl8723bs: convert update_attrib to return errno Date: Mon, 15 Jun 2026 23:43:40 +0000 Message-Id: <20260615234340.97299-5-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260615234340.97299-1-dennylin0707@gmail.com> References: <20260615234340.97299-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert update_attrib() to return 0 on success and a negative errno on failure. Update rtw_xmit() to handle the returned error code. No functional change intended. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 24 +++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 0fd2415e7bb7..4d886a35f4c8 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -654,7 +654,7 @@ static int set_qos(struct pkt_file *ppktfile, struct pkt_attrib *pattrib) return 0; } -static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct pkt_attrib *pattrib) +static int update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct pkt_attrib *pattrib) { struct pkt_file pktfile; struct sta_info *psta = NULL; @@ -741,23 +741,24 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p } else { psta = rtw_get_stainfo(pstapriv, pattrib->ra); if (!psta) /* if we cannot get psta => drop the pkt */ - return _FAIL; + return -EINVAL; else if (check_fwstate(pmlmepriv, WIFI_AP_STATE) && !(psta->state & _FW_LINKED)) - return _FAIL; + return -EINVAL; } if (!psta) { /* if we cannot get psta => drop the pkt */ - return _FAIL; + return -EINVAL; } if (!(psta->state & _FW_LINKED)) - return _FAIL; + return -EINVAL; spin_lock_bh(&psta->lock); - if (update_attrib_sec_info(padapter, pattrib, psta) == _FAIL) { + ret = update_attrib_sec_info(padapter, pattrib, psta); + if (ret) { spin_unlock_bh(&psta->lock); - return _FAIL; + return ret; } update_attrib_phy_info(padapter, pattrib, psta); @@ -793,7 +794,7 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p } /* pattrib->priority = 5; force to used VI queue, for testing */ - return _SUCCESS; + return 0; } static s32 xmitframe_addmic(struct adapter *padapter, struct xmit_frame *pxmitframe) @@ -1954,7 +1955,7 @@ s32 rtw_xmit(struct adapter *padapter, struct sk_buff **ppkt) struct xmit_priv *pxmitpriv = &padapter->xmitpriv; struct xmit_frame *pxmitframe = NULL; - s32 res; + int ret; if (start == 0) start = jiffies; @@ -1967,9 +1968,8 @@ s32 rtw_xmit(struct adapter *padapter, struct sk_buff **ppkt) if (!pxmitframe) return -1; - res = update_attrib(padapter, *ppkt, &pxmitframe->attrib); - - if (res != _SUCCESS) { + ret = update_attrib(padapter, *ppkt, &pxmitframe->attrib); + if (ret) { rtw_free_xmitframe(pxmitpriv, pxmitframe); return -1; } -- 2.34.1