mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>
Cc: Michael Hennerich <michael.hennerich@analog.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: ad525x_dpot: fix sysfs cleanup paths
Date: Mon, 15 Jun 2026 08:58:01 +0200	[thread overview]
Message-ID: <2026061555-overnight-cornea-cbf3@gregkh> (raw)
In-Reply-To: <20260615065140.77960-1-pengpeng@iscas.ac.cn>

On Mon, Jun 15, 2026 at 02:51:40PM +0800, Pengpeng Hou wrote:
> ad_dpot_probe() creates per-RDAC sysfs files and then, for devices with
> increment/decrement commands, creates the command sysfs group.

Which is the incorrect way of creating sysfs files for many reasons, not
the least being what you found here.

Please fix this by using a default group and the is_visable() callback
instead.  That way it will "just work" as the driver core will handle
all of this properly.

Huge hint, whenever a driver calls a sysfs_*() function, it is doing
something wrong.

thanks,

greg k-h

  reply	other threads:[~2026-06-15  6:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-15  6:51 Pengpeng Hou
2026-06-15  6:58 ` Greg Kroah-Hartman [this message]
2026-06-15 12:25 ` kernel test robot
2026-06-15 15:37 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026061555-overnight-cornea-cbf3@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=pengpeng@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome