From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4764F481660 for ; Tue, 16 Jun 2026 23:40:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781653211; cv=none; b=m1IlzifYeBSAeqKur8T5KV09m2DFUYU9ilrXcHFuoppbcS5EkvJObUxwr/Ew25UnikPa7ARLiRuiUQ1nE/+BW0xI5MUecqNqAFRUNIDgpZFpKLbQt21z1NicVOtuUwAG92nYJYANH8kcv8TnltsDbS+Y6wyrJCtPyJ+0EBQZkiU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781653211; c=relaxed/simple; bh=yNMUWb5Y+60YVxGF7kl63GNYPl2UKKGa3y15L2vP7rA=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=kRphOI9ufkmFWjUIW9CRquG7HRrH3ME40GzBZyIGnlGcp9mL8XglRzOpT33AwXoBgzoaM1/eZugcfkypCQeySI+riEAMPMK4n1P1C2UJUWxsgkcIgyLC6qW/pcAEb12e60OJeqNNq8WLSeM4utHtUZT5NZZxm9g6Jx7tBJIHESg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=l2QSqrnl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Z9UFwjbn; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="l2QSqrnl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Z9UFwjbn" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65GLUKqm149710 for ; Tue, 16 Jun 2026 23:40:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=gh9zzMuTowQO7XrJBUk8TB IviH5cPM1r8wircBtM+aQ=; b=l2QSqrnlIBHHIV0TYvKRPJUUMWIaPQNy/kersp PTLnKT5JLleYWn5fprwkTPShX6CN283/NB8ziZnSYrXk/xBiFq03oQl09os+xa1p l730koI48caG8QQxwWXCaPXZN3XGJiYjWcFKnqQ5BExxT2nK0cHfjFCjxDWBv1ie DPNzO4qF4nddorsZ9qgGCpFipBqnhbADoLjyBsp1jbJa2nbiA69DUIXNh3kFuzWu N3M8PiehasqM4wNle5204wdZuqgtp6UoyLQYHQGdqz6XJBZL3py6K3j24eZZ/olv NUaPFhDM5h0Z89/mRd/Tnj/J4sJBjsb89KDE1D4/+ZlyRxVA== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4euef20cmj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 23:40:08 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-30bd2951238so12393eec.0 for ; Tue, 16 Jun 2026 16:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781653208; x=1782258008; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=gh9zzMuTowQO7XrJBUk8TBIviH5cPM1r8wircBtM+aQ=; b=Z9UFwjbn53z5onIOOvEePpUKwyxVcml19kKKJEK+adQr4JvcyjC1T38RL9ts0sfaAR HN1w4bS9dT/NG77b4qRfRDpTbRiOewgDUSAyg3spe5YEnhZxEiH0NlKIEupRExxxUrX+ e/Qum5b+37Z1Zu4LMesTaCYbS/PAnfQGONdfh2WcbNeNkeS9stNpXAn0dmEyYCU+4I3y P1neLoYQVEaA6d51uUEZF9EODuh5FkuWlAySlwldpxm7Hr80DeuZZZp3AVF26bHrl8pJ P8psB1o1a/EszHtUlbxj6oRon2FCxm+F5dygyNJnxgzlhPN8LgcPJ5DPy91hulpEAeki 9Zew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781653208; x=1782258008; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gh9zzMuTowQO7XrJBUk8TBIviH5cPM1r8wircBtM+aQ=; b=VatBE0Z/Dfywu3i0fnJV/BqBsbMOHlCJjWUoG1Ft8dugQLRhzsu+2bE4XmTwXHRSTc W28fekf93xckKZycK4hlO96Gm1pvf+ktgAs4Jshut2yN5na5+1bTERLyN7hccy9dhW1p wKEoBEYRCgeFpbDuQA3A/IzlDoFgRLs56VuyeGsauIJiYevk0WQ9TCkCQEZsw2Y3tUhh JP8spd3pKO5BTgG9FDz9TDnW2IAd4loSzEl/nyrRVrjqVhkcG2rJC4gIFa38+FiWslpQ TdLHKwCEugoJ7sbH1b8wyoeWDmTKnbAICYiW9gPVkCkce7BQMWHPpi3pSpPxSFj+h5Rd jjsg== X-Forwarded-Encrypted: i=1; AFNElJ+h1GARuRq40Pe8xze6RNwvX8bvgJ6LKjRF+xIMXSEy5aUMkbCZRdIn5G6ERmRQ+XNjL89IFEiVfaiZfOo=@vger.kernel.org X-Gm-Message-State: AOJu0YxOZC2iN5wLOaxMOme0LHk1Jorb2j/sl6ZYehYkR/DrUS0iXRNo VsvCyj4sHQXpEy8Rouq5UnQs/9vWXe56lKhF6ZOAsRv/F9tSLDvyfcrxz8prXSpW+T4OQDf7/Xk FcdWmH0NrAyCSdNUUsATF+fqjnrBLhDppfZc+ppynP4bReTDIliZrYjVFLblxKxFaGqcb4wSy5J M= X-Gm-Gg: AfdE7ckuGaw/9vMQSTJ1MVmyA+H5OIykjlBznR/rerBLMHyHovGM0TW/bNdVAaRgLkv 00ccZbuAfEBehnpwFJILHdleTN2PAIYCLqPaeQ64cWYI5sndd06XFvGi72dNp41JT4V+hlcz7Q9 YFY1mcAzFD+YSI2RiUVFChAPiJfRPgDyNP4xCsdFZrg5MPW7dt8rXQnUtS/cMVFAOL6dxCYp3s+ QbuWQH4xJek/uL1hHmLhbzPO+9doX1YoC41sEW9HJ2/wzXFfOn3UIkkODFkhvPqF5r0K5W2JQ/Y MEXdZzaQpdwca1MOEz8u4n4l/7jvubPwrhAwD6vwIh+97iRYXqPE4MTnlgTawYobx7VE8dMl4Yv aCuVSavBmwYzmJid5yz9OQq/h2zaD/qGGXVfosFDT5b8XMyl098JblrKFSxxRxdGaJDnuvNRRGz GjzcAdLA== X-Received: by 2002:a05:693c:3118:b0:2e5:faa9:ca76 with SMTP id 5a478bee46e88-30bca0ed2d0mr381157eec.7.1781653207575; Tue, 16 Jun 2026 16:40:07 -0700 (PDT) X-Received: by 2002:a05:693c:3118:b0:2e5:faa9:ca76 with SMTP id 5a478bee46e88-30bca0ed2d0mr381143eec.7.1781653207015; Tue, 16 Jun 2026 16:40:07 -0700 (PDT) Received: from gu-dmadival-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30bbbd636fasm2828607eec.22.2026.06.16.16.40.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 16:40:06 -0700 (PDT) From: Deepa Guthyappa Madivalara Subject: [PATCH 0/3] Implement Region of Interest(ROI) support Date: Tue, 16 Jun 2026 16:40:02 -0700 Message-Id: <20260616-enc_roi_enable-v1-0-fefcc4e76f33@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIANPeMWoC/x3MQQqAIBRF0a3EHyeUlkVbiRCzV30IDYUIor0nD c/g3ocSIiPRUDwUcXHi4DPqsiC3W79B8JJNspK60rUW8M7EwAbezgdEs6i+dU3XKwvK0Rmx8v0 Px+l9Pz8dmyRgAAAA X-Change-ID: 20260616-enc_roi_enable-4d385c4783ae To: Mauro Carvalho Chehab , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Deepa Guthyappa Madivalara X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1781653206; l=4136; i=deepa.madivalara@oss.qualcomm.com; s=20250814; h=from:subject:message-id; bh=yNMUWb5Y+60YVxGF7kl63GNYPl2UKKGa3y15L2vP7rA=; b=D+ravmlfXpAgpOVhgJHA2Ko1YabJwKfFtOKcP7KtGU9xmyChul2lKuXuQzFzfkNdGhi2v2uS/ QZf4rCSHsKpCaWx+8BFsO4u5dB+fwFQG6yTKX+uIiyfWOcxYUU1DzIZ X-Developer-Key: i=deepa.madivalara@oss.qualcomm.com; a=ed25519; pk=MOEXgyokievn+bgpHdS6Ixh/KQYyS90z2mqIbQ822FQ= X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDIzOSBTYWx0ZWRfXzv2TOSw2j5Yr cjrBJ6A+zEQzaxGaj2hmqzmwY5q94scDWyQky8rcAKwXLS5ZYvGPFLmTdkyZylrHqw5wuo3hK5s p/180JBwZCOJ7Qn/UOmpjDJIF/LRQow= X-Proofpoint-ORIG-GUID: SWH4gCvf3O3Yxou-Gks8GYhbgk64dwrz X-Proofpoint-GUID: SWH4gCvf3O3Yxou-Gks8GYhbgk64dwrz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDIzOSBTYWx0ZWRfX/hrmEtyuARoJ E33gvhN7QCEFka3W64Yve+Lib+dIXTktOiy9QeSMbqNyiAo2XSDteGe6DldKyFv1Hg09ajeyCXK SkHD/phDRispu1emm3I/XfFCXyJJDxqQEVvyE2KhWPTpCIBvREClJtTHGzBWtqJ/wTvAwbBaegH hBpSysNQjevHJMv9O7SwO1m8Wzatdwe9yMtuOnR25B2M+Hq7dhTC4PYUF+60fcwKcjrVKjwaJ0r qcZLWvbMUS8EUD9aE9skOAS3VssKXhY1fQWNT0frmXgfCrbL3KhZllhysnt7W/mcriaSJJ2eL/9 qZ6fJQudJYABu08cM6YePpPsPVlbgA0OXch2GC5cffAtYgnIA7wsFEpLpq4AmYFIHtpZIhFqVX2 2ZzIhKbt03vs0YrnxgN1N8oZN+yllvi/w50eSEDUfKjYoUwlMtNzZu3DI2FRQvxO2i9trw5v1Y2 wheSU8iisfhXhLlGsXA== X-Authority-Analysis: v=2.4 cv=acpRWxot c=1 sm=1 tr=0 ts=6a31ded8 cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=Um9VFfwTIzMb-0Dl9GAA:9 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_05,2026-06-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 clxscore=1011 bulkscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606160239 Hi all, This patch set implements region of interest(ROI) support for video encoder to be configured as a MB based delta_qp for the whole frame. Custom controls V4L2_CID_MPEG_VIDEO_ROI_MB_DELTA_QP and V4L2_CID_MPEG_VIDEO_ROI_MB_SIZE are implemented to achieve this. Corresponding support is added in iris encoder to implement this feature. This submission and design is based on the feedback received from community for the RFC[1] series posted earlier. Initial testing is done by adding support to v4l2-ctl[2] to test this control setting and its functionality. [1]https://lore.kernel.org/linux-media/20260113-iris_enc_roi-v1-0-6c86eba38587@oss.qualcomm.com [2]https://lore.kernel.org/linux-media/20260616-enc_roi_enable-v1-1-252792d27894@oss.qualcomm.com Results: v4l2-ctl -d /dev/video1 --list-ctrls ... enc_mb_roi_delta_qp 0x00990b92 (s8) : min=-31 max=30 step=1 default=0 dims=[139264] flags=has-payload roi_mb_size 0x00990b93 (u8) : min=16 max=32 step=1 default=16 value=16 flags=has-payload v4l2-compliance -d /dev/video1 ... Buffer ioctls: test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test CREATE_BUFS maximum buffers: OK test VIDIOC_REMOVE_BUFS: OK test VIDIOC_EXPBUF: OK test Requests: OK (Not Supported) test blocking wait: OK Total for iris_driver device /dev/video1: 48, Succeeded: 48, Failed: 0, Warnings: 0 ./v4l2-ctl --verbose -d /dev/video1 --set-fmt-video-out=width=176,height=144,pixelformat=NV12 --set-fmt-video=pixelformat=H264 --set-ctrl=enc_mb_roi_delta_qp=-20,-2,-22,9,-16,-2,14,-9,-19,3,-26,19,-23,30,1,0,-6,-7,7,2,-2,15,-15,-24,-24,-26,-26,5,-1,-1,9,-11,15,-25,-11,26,-11,7,-26,-27,-8,-18,7,-4,-12,-23,-11,22,-7,7,-14,24,6,-8,-7,2,7,-26,2,-25,-1,-3,-4,-6,-26,-11,7,16,-30,-22,-15,30,-14,-29,-11,-8,8,6,19,15,-17,21,-27,30,-17,-28,-10,-20,1,22,29,-19,-2,28,10,12,-10,7,-4 --stream-mmap --stream-out-mmap --stream-from=/media/foreman_qcif_nv12.yuv --stream-to=roi_try.h264 --stream-count=10 Validated on SM8550 MTP. Thanks, Deepa Signed-off-by: Deepa Guthyappa Madivalara Signed-off-by: Deepa Guthyappa Madivalara --- Deepa Guthyappa Madivalara (3): media: uapi: Introduce new control for video encoder ROI media: v4l2-core: Add support for video encoder ROI control media: iris: Add ROI support framework for iris video encoder .../userspace-api/media/v4l/ext-ctrls-codec.rst | 14 +++ drivers/media/platform/qcom/iris/iris_buffer.c | 101 ++++++++++++++++++++ drivers/media/platform/qcom/iris/iris_buffer.h | 22 +++++ drivers/media/platform/qcom/iris/iris_ctrls.c | 104 +++++++++++++++++++++ drivers/media/platform/qcom/iris/iris_ctrls.h | 3 + drivers/media/platform/qcom/iris/iris_hfi_common.h | 1 + drivers/media/platform/qcom/iris/iris_hfi_gen2.c | 16 +++- .../platform/qcom/iris/iris_hfi_gen2_command.c | 62 ++++++++++++ .../platform/qcom/iris/iris_hfi_gen2_defines.h | 3 + .../platform/qcom/iris/iris_hfi_gen2_packet.c | 6 +- .../platform/qcom/iris/iris_hfi_gen2_packet.h | 3 + .../platform/qcom/iris/iris_hfi_gen2_response.c | 29 ++++++ .../platform/qcom/iris/iris_platform_common.h | 5 + drivers/media/platform/qcom/iris/iris_venc.c | 4 + drivers/media/platform/qcom/iris/iris_venc.h | 2 + drivers/media/platform/qcom/iris/iris_vidc.c | 2 + drivers/media/v4l2-core/v4l2-ctrls-api.c | 1 + drivers/media/v4l2-core/v4l2-ctrls-core.c | 21 ++++- drivers/media/v4l2-core/v4l2-ctrls-defs.c | 10 ++ include/media/v4l2-ctrls.h | 1 + include/uapi/linux/v4l2-controls.h | 2 + include/uapi/linux/videodev2.h | 3 + 22 files changed, 409 insertions(+), 6 deletions(-) --- base-commit: 06cb687a5132fcffe624c0070576ab852ac6b568 change-id: 20260616-enc_roi_enable-4d385c4783ae Best regards, -- Deepa Guthyappa Madivalara