From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EC65481AA8 for ; Tue, 16 Jun 2026 23:40:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781653211; cv=none; b=GXZuJxgFbziNfDJuJdov9NXaXQiu45Nw5/tIPRxOuMeMfvwBlt6ob6+LffQw/Z1o7qrB/8y0MliPBZSDtrMBV341MhCVVz8JV5o7vo4D4RTZ9pgHJJCabvsECruuccDLPEZMoyjll8qUKMTcdJJcTdfipDhQQd1j7TzTZl8IK30= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781653211; c=relaxed/simple; bh=s2axybC9gZJV6DhelFvJqIsgDslOKwc4D1G669PivyQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KSVyPgXD3xgfML0k6piwI8KtDlISMLCNbRqLXa5cCC8gxcAt8sbPO/n1S0HnacOPv0JM6kFDqzH5KFBRrruZ1CKB94HKZ2FKSdrvXahGgZ+KWSZydqABbTVGCKjBkoJpnOA27Cu4TuRLIF0i2ZetVM0lixZn0RqMooo8Itzj6Po= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=R7sgntdd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Qr1x7VVS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="R7sgntdd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Qr1x7VVS" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65GLTcwq249141 for ; Tue, 16 Jun 2026 23:40:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0Tmy1cIYxXjpzHBntLzbSuQARaXb8dG+6b7KwUXzoV0=; b=R7sgntddRyQ36YY5 1oVYBMgfYIr0+mBiTT9S3Cz1fQ5G6xRPGn+pAV6SLiOA8PCSvqJWOz5ibYpk4Hdm Gbi6xJFhvyOtHC52P6uz20YkwK40dfOqWc77447Qi0iQmc2s14F1UJu1ZChsrbN7 4a+rcgF1YsNE6FK9/Ktae+49OicHpDoWJV4nRZEkypXMS6zeHBAaYDi1gTWRg5PD vUpvj4vgCG0LPUBuBCh/BgtggtWUx5+T0qQ+1nNlGsEDuxp77ijY3RQVPd8Mk/Lj NWozHyw6phuYMn9HtIdXTEqXIhlbsGuD2q+++b4ER5NJCMpzMGTYXUuQ3/mH1qzD MN3bMg== Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eueet0c9m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 23:40:09 +0000 (GMT) Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-304dd29553aso782297eec.1 for ; Tue, 16 Jun 2026 16:40:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781653209; x=1782258009; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0Tmy1cIYxXjpzHBntLzbSuQARaXb8dG+6b7KwUXzoV0=; b=Qr1x7VVSxqniEe4ClCug10doI0Pxpae4KCF2SLpJI5jOY+Yh/8Oc662EsGg7vWK7BB NJRlIpfgmU0iy2gP/w8mVTm2Gmi0amHtxOKEnAT7ywRurRXs+ueqN5eZDRQhwVtSV/MW jYclcZqntFuYERGi5PLeee5qo7SIvcc0G78tmx4UX8OjPu9BiRXI5v/hDnjFskuh9P+5 L5joE1p1+gyG5tEp9gb/01uNpA8hpdsnMsgQbQDo6DaDQbzcZyZKOS+D+z92+8i7HCuA VosiOC03MwyKySPlF8+Ca98dM2hs3QM96FbafYmV2VeEeQC+8r74QJzBm22wJGmiiX5S 3XzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781653209; x=1782258009; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=0Tmy1cIYxXjpzHBntLzbSuQARaXb8dG+6b7KwUXzoV0=; b=U2ScWmFLQOt90ERfnWH+joQw1Scpube6JtEqeI8/tr9OWMNwWLm8fBXid5dMagfK8r bRGlIM1bgSznV5oFOYrUI7R0+V4Obx/Hod75H860P9rf3hInHeD8ggRn0/edrHiodTJG hCrJLs9Y1O3W7hNzHEfTEj7stEuAh1bG5qBUfCGuvoPP4paQ1slQYA16ccSwFWcQxX0I WmMOOXFtBmRstXTtIWO6eMYC/PtMnJq4PtDNSwMlLDii/aE+1Rw0z30sM6IEwrKl7L2C +yEMR9+f2AfW+6Rge0ZKANIDHd6RrgWtdMS6uNWnlYH4OvGtXPnBtPN8YK/KBDfdy5xX qjiw== X-Forwarded-Encrypted: i=1; AFNElJ+3+8sdn3jlZLW0x4rGUGD8Lxk3oOtaafUjD5mTSzeMGdfzTwiaw9A5QwpIS2cavdsdp44iz6qMgDZDLPE=@vger.kernel.org X-Gm-Message-State: AOJu0YzK6lAo1ywvh6ReyjkQgrp9+z26i3cpxi/ZAq8xuPKxNppHcYCx ALTAcpo5V3qdLrTaRHGY7V92DVW1+st1L6Cs6VssyVAW0wsiDC6LxepPduqwYSga8aV6Px7JDJh ieof2EKyThATsUCDdUKW0MnUr7FIskpDimKdYXZxWU6VsUVGHvGrtJEYxR2KHzIU9dRkO38GiHu k= X-Gm-Gg: AfdE7cld2zWFBTsWTCgfUKJI942aWu3M1DoJOFTnkDQhpOkl50RAsmMslLxP7h/zsEb yyNSAM8alavaN+T6Hm1MbqbR6D+yDAmV55CRRPX7JlWo5VpQ79kNclyYIlNAYFMFX7Q8Wf/ODpn n9CPVOM4oypVgWgwKkBU0TLOvYx14vNwFc6Y+17zq+4ImOimPWh4JbFt+M4jgyBkO/d1zmoVXKg VnwDVaPkK2bNB9qTWQv/1EdczQYnRauX5fW0F7mBad6cl36N0Y9IbKgIAsJlm8uZcrDRSmM8y8+ WBZf88Julcc/BYziQSHUNztrsLc29pvL+iGKrQDzQ+S7wxwF7hDBaEx3u2yixyLzqsbBKPZsH4Q Yic5gUMG9zS2qY5y7xXn2ifs9Flo5ux30bt3njq63xbL9Fb8nR/fiyHE6rKvaKhzGRRQgnKEzIi gJfe0WTQ== X-Received: by 2002:a05:7300:2153:b0:2d5:9438:2a02 with SMTP id 5a478bee46e88-30bc9cb8b04mr388071eec.1.1781653208919; Tue, 16 Jun 2026 16:40:08 -0700 (PDT) X-Received: by 2002:a05:7300:2153:b0:2d5:9438:2a02 with SMTP id 5a478bee46e88-30bc9cb8b04mr388058eec.1.1781653208386; Tue, 16 Jun 2026 16:40:08 -0700 (PDT) Received: from gu-dmadival-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30bbbd636fasm2828607eec.22.2026.06.16.16.40.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 16:40:08 -0700 (PDT) From: Deepa Guthyappa Madivalara Date: Tue, 16 Jun 2026 16:40:04 -0700 Subject: [PATCH 2/3] media: v4l2-core: Add support for video encoder ROI control Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260616-enc_roi_enable-v1-2-fefcc4e76f33@oss.qualcomm.com> References: <20260616-enc_roi_enable-v1-0-fefcc4e76f33@oss.qualcomm.com> In-Reply-To: <20260616-enc_roi_enable-v1-0-fefcc4e76f33@oss.qualcomm.com> To: Mauro Carvalho Chehab , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Deepa Guthyappa Madivalara X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1781653206; l=4874; i=deepa.madivalara@oss.qualcomm.com; s=20250814; h=from:subject:message-id; bh=s2axybC9gZJV6DhelFvJqIsgDslOKwc4D1G669PivyQ=; b=5e7ji4nw/cmeEZBzzL43KzRs3bfG/FnCF0j/D7yVYPIfhaJFhwtPn1LjC0TzyQUicA/YJGbNE yNMlZ3kDSdEAH9/P7yb8T7b0t2TvyJ8KEwRwEe2l0lnB+bW5onTEavP X-Developer-Key: i=deepa.madivalara@oss.qualcomm.com; a=ed25519; pk=MOEXgyokievn+bgpHdS6Ixh/KQYyS90z2mqIbQ822FQ= X-Proofpoint-GUID: uL3MrdHrxkuMAjW5EvOOQ4qqcwaM-TJ5 X-Authority-Analysis: v=2.4 cv=JufBas4C c=1 sm=1 tr=0 ts=6a31ded9 cx=c_pps a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=1VXWyIoLJVhIH0d9pWEA:9 a=QEXdDO2ut3YA:10 a=bBxd6f-gb0O0v-kibOvt:22 X-Proofpoint-ORIG-GUID: uL3MrdHrxkuMAjW5EvOOQ4qqcwaM-TJ5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDIzOSBTYWx0ZWRfX9Ax/QtHDgRNq Dj6CJRmnAKboTjfff5VlfGcBWx3q7zEofnk+tA3Xb5t/PqBx14VZoZqwhJB6iM2zSH9OGIadgra YGvdjrxr+DjrnlfCbZ3vy6LkktAhgSeyadUUkbhgZlGGBMqSefFLUvfvmGGaXrjaKVkMH9rWzuI Dgv+eNC6cphLd2aQBfKFlIMKVCFuCWQYz+iT2uWW+MNukb1X0pp4gNP7hfbmtZ7Z46VIejF3vwN fHqmEvhN9Lhg6LYAIm38GBtBmSeiEJuXyR0IWm6dIEIBY29zs3mrScF+EGbyRm6x4EOOxkBu87g dsJeiB01ObaShdsOziCBakkYjBI6ZIwxuVMbrq057hJKFXmgD4TDvvHZZqGmHhtAVHb2miKlVRp 2bUpAzaIxk68l0EC86C1YM0z8y3hUL3FHEPz5XbdZKfYmKI++6ULtnp3Rw0im6fCCXENvJUQ4Tu PPAsNbB4ORbahU05Kmw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDIzOSBTYWx0ZWRfX/UAsh5RYNUV7 s/ru0bB2pkgTUJY/we7cbK/TUigiIoRMGzawoyffsQ+mBnC4ycSlByQfxFVW+zHRlXNCHxw7n22 6rRo1q3wErSvwJ8m+jHxg7rz4LLiG8Q= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_05,2026-06-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1011 adultscore=0 priorityscore=1501 impostorscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606160239 Add necessary support for controls V4L2_CID_MPEG_VIDEO_ROI_MB_DELTA_QP and V4L2_CID_MPEG_VIDEO_ROI_MB_SIZE. Signed-off-by: Deepa Guthyappa Madivalara --- drivers/media/v4l2-core/v4l2-ctrls-api.c | 1 + drivers/media/v4l2-core/v4l2-ctrls-core.c | 21 +++++++++++++++++++-- drivers/media/v4l2-core/v4l2-ctrls-defs.c | 10 ++++++++++ 3 files changed, 30 insertions(+), 2 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-ctrls-api.c b/drivers/media/v4l2-core/v4l2-ctrls-api.c index 93d8d4012d0f4fef004e417d0aee2ae44b1b30bd..7d41cfd7378baaa929d4da0266c45f731bb54285 100644 --- a/drivers/media/v4l2-core/v4l2-ctrls-api.c +++ b/drivers/media/v4l2-core/v4l2-ctrls-api.c @@ -980,6 +980,7 @@ int __v4l2_ctrl_modify_range(struct v4l2_ctrl *ctrl, case V4L2_CTRL_TYPE_U8: case V4L2_CTRL_TYPE_U16: case V4L2_CTRL_TYPE_U32: + case V4L2_CTRL_TYPE_S8: if (ctrl->is_array) return -EINVAL; ret = check_range(ctrl->type, min, max, step, def); diff --git a/drivers/media/v4l2-core/v4l2-ctrls-core.c b/drivers/media/v4l2-core/v4l2-ctrls-core.c index ba047d7d86010bf0cf8f8fbf2dc343883d6bdae0..ec7e49407603b34d3b7eed40cc6fde001b0b10d0 100644 --- a/drivers/media/v4l2-core/v4l2-ctrls-core.c +++ b/drivers/media/v4l2-core/v4l2-ctrls-core.c @@ -287,6 +287,14 @@ static void __v4l2_ctrl_type_op_init(const struct v4l2_ctrl *ctrl, u32 from_idx, memset(ptr.p_u32 + from_idx, 0, elems * sizeof(u32)); } break; + case V4L2_CTRL_TYPE_S8: + if (value) { + for (i = from_idx; i < tot_elems; i++) + ptr.p_s8[i] = value; + } else { + memset(ptr.p_s8 + from_idx, 0, elems * sizeof(s8)); + } + break; default: for (i = from_idx; i < tot_elems; i++) { switch (which) { @@ -367,6 +375,9 @@ void v4l2_ctrl_type_op_log(const struct v4l2_ctrl *ctrl) case V4L2_CTRL_TYPE_U32: pr_cont("%u", (unsigned)*ptr.p_u32); break; + case V4L2_CTRL_TYPE_S8: + pr_cont("%d", *ptr.p_s8); + break; case V4L2_CTRL_TYPE_AREA: pr_cont("%ux%u", ptr.p_area->width, ptr.p_area->height); break; @@ -1365,6 +1376,8 @@ static int std_validate_compound(const struct v4l2_ctrl *ctrl, u32 idx, return -EINVAL; break; + case V4L2_CID_MPEG_VIDEO_ROI_MB_DELTA_QP: + break; default: return -EINVAL; } @@ -1403,7 +1416,8 @@ static int std_validate_elem(const struct v4l2_ctrl *ctrl, u32 idx, return ROUND_TO_RANGE(ptr.p_u16[idx], u16, ctrl); case V4L2_CTRL_TYPE_U32: return ROUND_TO_RANGE(ptr.p_u32[idx], u32, ctrl); - + case V4L2_CTRL_TYPE_S8: + return ROUND_TO_RANGE(ptr.p_s8[idx], s8, ctrl); case V4L2_CTRL_TYPE_BOOLEAN: ptr.p_s32[idx] = !!ptr.p_s32[idx]; return 0; @@ -1556,6 +1570,7 @@ void cur_to_new(struct v4l2_ctrl *ctrl) return; if (ctrl->is_dyn_array) ctrl->new_elems = ctrl->elems; + ptr_to_ptr(ctrl, ctrl->p_cur, ctrl->p_new, ctrl->new_elems); } @@ -1998,6 +2013,9 @@ static struct v4l2_ctrl *v4l2_ctrl_new(struct v4l2_ctrl_handler *hdl, case V4L2_CTRL_TYPE_U32: elem_size = sizeof(u32); break; + case V4L2_CTRL_TYPE_S8: + elem_size = sizeof(s8); + break; case V4L2_CTRL_TYPE_MPEG2_SEQUENCE: elem_size = sizeof(struct v4l2_ctrl_mpeg2_sequence); break; @@ -2215,7 +2233,6 @@ static struct v4l2_ctrl *v4l2_ctrl_new(struct v4l2_ctrl_handler *hdl, if (flags & V4L2_CTRL_FLAG_HAS_WHICH_MIN_MAX) { void *ptr = ctrl->p_def.p; - if (p_min.p_const) { ptr += elem_size; ctrl->p_min.p = ptr; diff --git a/drivers/media/v4l2-core/v4l2-ctrls-defs.c b/drivers/media/v4l2-core/v4l2-ctrls-defs.c index e062f2088490470c42d6c579ff7675be454a29b0..8f895060799ea13443143edd398dfb97f4ba0085 100644 --- a/drivers/media/v4l2-core/v4l2-ctrls-defs.c +++ b/drivers/media/v4l2-core/v4l2-ctrls-defs.c @@ -974,6 +974,8 @@ const char *v4l2_ctrl_get_name(u32 id) case V4L2_CID_MPEG_VIDEO_AVERAGE_QP: return "Average QP Value"; case V4L2_CID_FWHT_I_FRAME_QP: return "FWHT I-Frame QP Value"; case V4L2_CID_FWHT_P_FRAME_QP: return "FWHT P-Frame QP Value"; + case V4L2_CID_MPEG_VIDEO_ROI_MB_DELTA_QP: return "Encoder ROI MB Delta QP"; + case V4L2_CID_MPEG_VIDEO_ROI_MB_SIZE: return "Encoder ROI MB Size"; /* VPX controls */ case V4L2_CID_MPEG_VIDEO_VPX_NUM_PARTITIONS: return "VPX Number of Partitions"; @@ -1622,6 +1624,14 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type, case V4L2_CID_COLORIMETRY_HDR10_MASTERING_DISPLAY: *type = V4L2_CTRL_TYPE_HDR10_MASTERING_DISPLAY; break; + case V4L2_CID_MPEG_VIDEO_ROI_MB_DELTA_QP: + *type = V4L2_CTRL_TYPE_S8; + *flags |= V4L2_CTRL_FLAG_DYNAMIC_ARRAY; + break; + case V4L2_CID_MPEG_VIDEO_ROI_MB_SIZE: + *type = V4L2_CTRL_TYPE_U8; + *flags |= V4L2_CTRL_FLAG_READ_ONLY; + break; default: *type = V4L2_CTRL_TYPE_INTEGER; break; -- 2.34.1