From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 684B213FEE for ; Tue, 16 Jun 2026 00:04:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781568296; cv=none; b=IlIJZjqgHD6jxChKzFLtzkGt0MU5D7D/HX1OJDr4g+S43DfCpWBuYmihnl/FSTy1vDW5Ma3cKDDcDNiLtk5nVzBGcZi7xw4ZDpTwxLTByHSwFKXwfg0J4TvcR4YtEyvj21dsG2VIHi8h8md7XS86V2YURfON46olKP4yYmUpmmo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781568296; c=relaxed/simple; bh=SUPr9326R8/I85NqmtSxzGXasITRZ38mBZxBYOCk/p0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ooZENg2S6+tcffifjIkyD8l6nAtiXAP7qJXi1hgvP6NALiqJgjGi0lNqtCiUScfrbB1q/2A38v3pc5xH7H2Knaca2fdjJqo7UesuLEpdKGw+MhgfFADDCU5+uQAIkMjh4yuA2IxnlJbnxs5HyQrR8zzzJ+CdDq6QJhOONj9Iam0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FfsJy/xn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=j0aZyNrJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FfsJy/xn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="j0aZyNrJ" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FIxJBw781711 for ; Tue, 16 Jun 2026 00:04:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rZBfUegtVT46gf+3kV/ulvsSL+G4ssvBArwyOeiJ5Vw=; b=FfsJy/xnufqnSeKf Xze1sj8sFewclvbfiDjIz8b1Ey0OQ2aQD6MfQa55DRAYX2ltfl7GOeaZg1H0bkyj 1cUb8/PIroEE71i/ytKj5ziy+KZ0/w9Nomc4rQ08Pjso9zMkTlsJ4LKVrtKPBsqV d+hr6RmmeQO90PdA6HZYYLkAxFCAAKKisqTDz+oaP8irI1M71la95XCQ9AfRuS/o seEN9YqtyNxGLiZVTW9qxrJM3L0LkBXoP7SErURtx8/P7kDFRGoQyKMuL+M6/IUQ 134H5d4QNOscV4YE2mNCRLO3bRZPArHHzHIyCun60VzKyvSCqStl7hu2tkY7dxSY WEeEMg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4etetjuqg4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 00:04:49 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-915d3261c5cso814593185a.3 for ; Mon, 15 Jun 2026 17:04:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781568289; x=1782173089; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rZBfUegtVT46gf+3kV/ulvsSL+G4ssvBArwyOeiJ5Vw=; b=j0aZyNrJvnTGq++YQsXSWFQ189kZ/8jPAOWCAMduKcBqv2Aw7k6wd1FlXOnp3O392H JaFW+yx1gbcJG2TXHsEYqkf0ZRCgjgCrjaHoaUclCAi4thNcHkpgL1A6haXVQaEkHM0e z8bVndarZIzPNxt1+W16VsuBZFqy1wEGvlmps2RtsCXWLYKoh1tG87Wq26sEBpaNrr97 cFziqlwqf6QzR93UIEKg3lOAmpZbMNql9IKzTM1v5kbvJtcEhPO0Od/dKDitekjM5k+y CScR+oBIvHW+y1f7UxRfO0lkUJu8t58c4QVsThP9kG2sAI6bqDce+aYkLFoiopTjojRN OiDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781568289; x=1782173089; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=rZBfUegtVT46gf+3kV/ulvsSL+G4ssvBArwyOeiJ5Vw=; b=lXKv/onJqFniVxIAwHCAeYYvfvmx4ayAm+fXbNaiTCBtoYwFlzPpdAbewhcHGfUMvq d+N2DcFhqABETMKdtawikAZb6DH1bgNS2v2D6D74kGDimwYcdCuLoGgsMQ5Q8j8IVRrL L+oUdE8oOqKhN6TuyOEgnxI3u5A0tnUim8VBZvkHJAkB1n5ZeRCFdIzsbFPyIc8sdh1R OnRcRUgGumO/7q7brjgukgis9We7oJwef0F36EAidkoAdTS1J0ymOfEL0szc26QpzeYJ XDkK4zFJDJVHfOJVBj2ax7Cw0hBr2H8j2FYNLypGx3QOaqqZrqmDkFc4irDd0FMIi+6v lQ2g== X-Forwarded-Encrypted: i=1; AFNElJ8svgtQJB/90svaD48rRPkw+7119hSD+3J1ggXp/XEC2A8h9dWsogBeVfLCjmQj4T/xjW2j+YNuBeqN06I=@vger.kernel.org X-Gm-Message-State: AOJu0YyFT0v7GJaDSAAaaqoEmU+k+cwpTutgCil135/JjwjPF8F9hbjH 2Eg/wbPAoTPN8MQMlX/VSS1Dw2VrthbAGaA7QlEZACB1LA76qr0fekHQChhNOGxKqi1xVSLa+v0 y4nVnSLdlwkQBqDsKYqGr5aC5dblsMqSDqoeE3kczDqWkgr239tn18E0Gx1K0fvfzjlE= X-Gm-Gg: Acq92OGGtOZc4vruFUpBPVuu5ban0oNagOyz4T8mP8cgrHj29ZIEo/+iay1LFsLhl8/ gJMf8awFCwqAkfzDl61IqxoZymvFTQ9Prgb6DgLtSdw6bgFpcI4mfXjSGxdYZ96t9HcykpDdzad wn3RM3kF1M0qAXym5pv/jMTK/QhQp/gVmH3pd8/z9Ly9AK5a6pgmt0n0UUzOoYMpxPPaCC/EGwL kOgaeEkOcSnvQLUr5bBMIM1X2V+scHAHQI3d2sHWyyYXgB1quSPrRX6oICwUoMdUvr3AedKVD3m CeiqZT9vAoAyiKIAqKq//tdXf8LqfZDd2pXfl3fvi6mFU+5ugXzt3lmUgUoos+1C9AnvzWQOiFK BO0wAMbcG3C0vpb7ybdTBmAJw8B+YE7sHUmDDLV0HdOu0D8Ee4g5mCFwwUYGWNkkMKJJxnyHYYd 3ooe9NQPbhVvhrsYt4Da0aRzHDrzoomZz/gbw= X-Received: by 2002:a05:620a:2584:b0:915:a762:2735 with SMTP id af79cd13be357-91c47799fd7mr210617285a.37.1781568288715; Mon, 15 Jun 2026 17:04:48 -0700 (PDT) X-Received: by 2002:a05:620a:2584:b0:915:a762:2735 with SMTP id af79cd13be357-91c47799fd7mr210611385a.37.1781568288243; Mon, 15 Jun 2026 17:04:48 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e1a7092sm3015731e87.50.2026.06.15.17.04.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 17:04:45 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 16 Jun 2026 03:04:30 +0300 Subject: [PATCH v5 03/16] media: iris: Introduce set_preset_register as a vpu_op Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260616-iris-ar50lt-v5-3-583b42770b6a@oss.qualcomm.com> References: <20260616-iris-ar50lt-v5-0-583b42770b6a@oss.qualcomm.com> In-Reply-To: <20260616-iris-ar50lt-v5-0-583b42770b6a@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vishnu Reddy Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Dikshita Agarwal X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4447; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=vk2n05YaqyNL1lA1l7CdzDHPMAEMMeRGvxRtE9L+Mhs=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqMJMO5NJZdxcfI07EHv74CzfYbRVDgOfSBpbS8 806WVLBtjaJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCajCTDgAKCRCLPIo+Aiko 1SjLCACJ5iSuZLJwO8U75b0uzLQeYt+gmFY3mI/wLagM2FIkoI0BQ96Lwsg752FdWyVLN/zljXb khsPudaw7J+KmYEAAgzaUXnZvddLDp4vDrOI8t/4YT/DnxCZnkplOkz354R4JLctbM4EHkFUMUk UnksLH8SLokRxeJjTHQmHYPI/N+XlNmbn9o8dJTzFApDyGRyADxut5VoQSuphwj/YGKiMBegWjQ qaD7iEG82M/szol637TL78y8pZl74VbLnDd/RDyMasQbBSPucTgQAQgIS0ceAYduk5TzHXPwnJE tXNL2gg5CxCPZhysCmC39A2p5q7WrWAPk5Qla8sqRl+za7ID X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDI1NCBTYWx0ZWRfX+Z9H80j+J+ha Uy6WvZdQ0d092GBwL/6yHpLNdM5i0IB1OmkSI/Agao6lSwUu62C3RGXmm2SfLFNhkajixTR0ftp DUC4s5BV8I2YypGSg+c9oLJqix6if5kSIPmf5zZ37Rqa3ZKKbiv3k0GI7trueY8HEWgDbeFqjhR 4Opkco0kiM2THKrj1MEE9WLbsPaKIF+8R3CkusaN7Ii8RjArnCzpcFSIvla42qaMuIUPklDCyg2 hN2PGho5enopv3cMMcBQfPF0MjGjDZwnrSWWsgc9tEiMTVQzypH/Un+OeM2W+aYCYGX/HG7c9zi 9WZA3uF5XelAW8xBt/SNT3j46y9yzv8rSlms7QT8SKtGcP3SN3C0wkwz5wpbjcKicJY4EKN+7BM qlTOxH5tU6dmWbYASozo7S2fPCcOcXjFeDZdaRexvnVdywGavxXoOk8bs9Bl2elXFyZoVyLZpmf Ldp3005BxcUwPoaAs9w== X-Proofpoint-ORIG-GUID: hcRagB-wYyCssgA_Ra1CcpRU8kdkDH5P X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDI1NCBTYWx0ZWRfXz/nXFYORYtZT y2IKp/tG9W8n/WtxHMEz1gTsOG+tUWbA+52FReKZD7W8CH+npLPLZG1PBInKCdPHmDp2ya/HgrF f0+Nou0i3u7jPCZA+9Rc2u26JtqfoJg= X-Authority-Analysis: v=2.4 cv=HttG3UTS c=1 sm=1 tr=0 ts=6a309321 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=4Uh0hlRDs2lXuULb_e4A:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: hcRagB-wYyCssgA_Ra1CcpRU8kdkDH5P X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_05,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 suspectscore=0 clxscore=1015 impostorscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150254 From: Dikshita Agarwal The set_preset_registers sequence is currently shared across all supported devices. Starting with Qualcomm QCM2290 (AR50LT), the register programming would differ. Move set_preset_register into a vpu_op to allow per-device customization. This change prepares the driver for upcoming hardware variants. No functional change so far for existing devices. Reviewed-by: Dmitry Baryshkov Signed-off-by: Dikshita Agarwal Reviewed-by: Vishnu Reddy Reviewed-by: Vikash Garodia Signed-off-by: Dmitry Baryshkov --- drivers/media/platform/qcom/iris/iris_vpu2.c | 1 + drivers/media/platform/qcom/iris/iris_vpu3x.c | 3 +++ drivers/media/platform/qcom/iris/iris_vpu4x.c | 1 + drivers/media/platform/qcom/iris/iris_vpu_common.c | 2 +- drivers/media/platform/qcom/iris/iris_vpu_common.h | 1 + 5 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_vpu2.c b/drivers/media/platform/qcom/iris/iris_vpu2.c index b8714dcbad10..2dc121a3f5e8 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu2.c +++ b/drivers/media/platform/qcom/iris/iris_vpu2.c @@ -45,4 +45,5 @@ const struct vpu_ops iris_vpu2_ops = { .power_on_controller = iris_vpu_power_on_controller, .calc_freq = iris_vpu2_calc_freq, .set_hwmode = iris_vpu_set_hwmode, + .set_preset_registers = iris_vpu_set_preset_registers, }; diff --git a/drivers/media/platform/qcom/iris/iris_vpu3x.c b/drivers/media/platform/qcom/iris/iris_vpu3x.c index 3dad47be78b5..dc02ced1b931 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu3x.c +++ b/drivers/media/platform/qcom/iris/iris_vpu3x.c @@ -261,6 +261,7 @@ const struct vpu_ops iris_vpu3_ops = { .power_on_controller = iris_vpu_power_on_controller, .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu_set_hwmode, + .set_preset_registers = iris_vpu_set_preset_registers, }; const struct vpu_ops iris_vpu33_ops = { @@ -270,6 +271,7 @@ const struct vpu_ops iris_vpu33_ops = { .power_on_controller = iris_vpu_power_on_controller, .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu_set_hwmode, + .set_preset_registers = iris_vpu_set_preset_registers, }; const struct vpu_ops iris_vpu35_ops = { @@ -280,4 +282,5 @@ const struct vpu_ops iris_vpu35_ops = { .program_bootup_registers = iris_vpu35_vpu4x_program_bootup_registers, .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu_set_hwmode, + .set_preset_registers = iris_vpu_set_preset_registers, }; diff --git a/drivers/media/platform/qcom/iris/iris_vpu4x.c b/drivers/media/platform/qcom/iris/iris_vpu4x.c index 02e100a4045f..f608a297d4a3 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu4x.c +++ b/drivers/media/platform/qcom/iris/iris_vpu4x.c @@ -368,4 +368,5 @@ const struct vpu_ops iris_vpu4x_ops = { .program_bootup_registers = iris_vpu35_vpu4x_program_bootup_registers, .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu4x_set_hwmode, + .set_preset_registers = iris_vpu_set_preset_registers, }; diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.c b/drivers/media/platform/qcom/iris/iris_vpu_common.c index ab41da1f47c8..a49113b0da23 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu_common.c +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c @@ -483,7 +483,7 @@ int iris_vpu_power_on(struct iris_core *core) iris_opp_set_rate(core->dev, freq); - iris_vpu_set_preset_registers(core); + core->iris_platform_data->vpu_ops->set_preset_registers(core); iris_vpu_interrupt_init(core); core->intr_status = 0; diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.h b/drivers/media/platform/qcom/iris/iris_vpu_common.h index 09799a375c14..21ed4c9bd5e3 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu_common.h +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.h @@ -22,6 +22,7 @@ struct vpu_ops { void (*program_bootup_registers)(struct iris_core *core); u64 (*calc_freq)(struct iris_inst *inst, size_t data_size); int (*set_hwmode)(struct iris_core *core); + void (*set_preset_registers)(struct iris_core *core); }; int iris_vpu_boot_firmware(struct iris_core *core); -- 2.47.3