From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BBFDDF59 for ; Tue, 16 Jun 2026 00:04:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781568296; cv=none; b=m1cvjLaJ6Wqv5KLVMOEV+rCBZCyEgoqM1HyWnJwJOWhrBKKN++zosYvgHYVDEOleM5so4iimRZn6UrbBxBv1Ex8h3j29xxVcR4QI1UUXlrOhrrUlZMyff9wVMMCJL+yk+fnxMXbyg73kWChfw6BVYC3JGDEyNlexyatUdjZtIZw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781568296; c=relaxed/simple; bh=mn+e/RylLLe8OTePgCv2X/kFcuAkbIe3sFltrQBvOOg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ua63Q7hTNdhTMUOraBLoaMgowqQKLaAO6grQlrSgDoQhLjbW1vaez5+QYmCG/Q2Wa3qtkNl9+ejXpu+MmUQVB7RF/DYr23s9MWG+C46Uo/IL+rseY8kKzp3+vzAvlyNd8hzX0d+KrjPD1qkweKEOajNMZqvfSvPPgsSQ0e3wIqQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=f159LoDw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gNinkRFp; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="f159LoDw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gNinkRFp" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FIxUs6781976 for ; Tue, 16 Jun 2026 00:04:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BSlDrwbGIU+LailKGlDSa67oRh8dtUgn/OIYCvnUjAg=; b=f159LoDwNqlGlkGt 96eYEjasqTgPKsCV/S+X37DuulLm0Y+WtQqYIvvB4k2AIhDJ5ZJ7fhTRySRxRtAL swbSNXg5m9ybckJG58EBxnxFRVXn8j7WYmRbs9bcwJ6CG9B3AlznHizx0HnC8M9y nItXvGuH9qXJaS9J59gdAzwFcnHNfGpfIxzEwmX8lXV6GDjLB4JSHJN/FMs5XmwB 1/L4NVKX8FlXGLrlvixdmEpz/l74yeEvigEuLRiGZjRNis8zdaUNovDipGkah0js w/mHpDS9ahXtZwFeIXWj8QzvlH0iNNHfAp71u0szJWvQ5Jnh9Y+UPC1L+upeA6r+ 0xqMlg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4etetjuqgf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 00:04:54 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-9156cb14b1cso375339985a.1 for ; Mon, 15 Jun 2026 17:04:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781568294; x=1782173094; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BSlDrwbGIU+LailKGlDSa67oRh8dtUgn/OIYCvnUjAg=; b=gNinkRFpYGmytpeuIGqML8KwiCbEfA095VnmkjlGZgFx54DoMe9na6JVzRJ+ahxBJn VkbYr3uNFH2eaT+kNYR4Kp0hhjVhsN3YxsLCQ4mlbSjoJ0gHpOz0mSlNaeWoYs08EBz7 F+o8Ll1KHpnrcTX2dmGzZzroihTZv2sUpBS53iRNQgzU85DnC+ITln9aFjgzdXrE0Ys/ ByfoQj2h96UxvMw8FFX9IXyQDgE0SHm9kfyBaVxWlaVrjoVXyH3IUx+m6lNPajkVOvGp WVZIHNuWX0XxF5UqvP3Yam4doEWsEwDvV+IeNv3MN0spvlDb8n1dGRn5Ch77Pl+akusp 2rMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781568294; x=1782173094; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=BSlDrwbGIU+LailKGlDSa67oRh8dtUgn/OIYCvnUjAg=; b=RegdAGpzBG2yRjAiVLfM7sYHZtclcGkd+Vsy+y1r6gih9KF2JokNF9sAE3ee/FfQ2J KIKeHApKwnYoLs7wFK51QrRtGy7BzmCre6zVoJfNZ96bwZ4RaXrlr0KjttpGta94H+Vg 1KorRJ9ykrBDIU0h9Lz+XWnaZZqnij8FQ4tMce65IdNmZtIn+vAsRuXOOl5Yh4gw/K0F PWjEF6F8W1m/TX7WlnkRYJqK9UxvtMV0qasVDzF7JhiZQTQxOkbXAHvZE/QQ0QIHY6re oRb6MPOqEWfUUvopZ2vF3LR29nPpPLxeC5fbn+7rR5g7AyzinUc8WYaVzIzNE3Ms19I1 DkWA== X-Forwarded-Encrypted: i=1; AFNElJ+AyvZtu2LCkDy5WCa6WgEJ3Q9aQ5wAFQX5YiF+SUPEeFiZ9XLd2FTXSNpJQbl5jRklrNQRLt+F1S5hDOc=@vger.kernel.org X-Gm-Message-State: AOJu0YzPe0+IOaDY0UycF1SlQ0It5BZa8svSG+zBE1zasi/dZisasNyL XijpVMm9teEq3kr99bgjWhydsl0n2x4B8cZOaCzBAGfkUfb9CG+aibClubr0s1bppd/QvwizNgp p6a+8E9rfFJqdJKwbiSP636ugPS7idrx2IS/v6oJvYAoEzRVfdh4mWp5NE+742huz0a0= X-Gm-Gg: Acq92OHoWKMVWO1v40fc46zjHSDySQfZ+GoG2wxEREABuKovlh8rpSvW04fj7CzAByK TrJ9Wfsfal/hSOPpYmO2shtCo2C+5JRL4J53bbP18xpW78hpdMKwqdN0hGnQnhhy+1FVOqm7yFr Iv00Xm8qG62Vn+3JUicYOqXNmGJJ9Fd/VUIpxHovs14fd66KbBIB7MqyjKiSFoMxfWr7oWwuKWU qDea52pps+E4pnzKi8js1zjPtqxzRBdwJyE/Moiwww82vORt3qVyFIWT2E/vEz5pYscEtZfeElA yUszWEVT3idMFYeXZrNdeTagz9DrTzB01S0eU7ExrJPMI6eDW0y+7fQ5qQd1tlItnVn+4QvolV0 GdISVr/mK7lFZU057mE1272eA64QTMw7GXDVnIlCmX9WQ1W9yK3MqocspW3tMA8XeKtEKqmA/27 6zrtVf7jnhSR+ebBW1kufEjkbdcgRBkrA+oP4= X-Received: by 2002:a05:620a:270b:b0:915:bf79:3e09 with SMTP id af79cd13be357-917f1474c81mr1970545785a.44.1781568293763; Mon, 15 Jun 2026 17:04:53 -0700 (PDT) X-Received: by 2002:a05:620a:270b:b0:915:bf79:3e09 with SMTP id af79cd13be357-917f1474c81mr1970540385a.44.1781568293243; Mon, 15 Jun 2026 17:04:53 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e1a7092sm3015731e87.50.2026.06.15.17.04.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 17:04:50 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 16 Jun 2026 03:04:31 +0300 Subject: [PATCH v5 04/16] media: iris: Introduce interrupt_init as a vpu_op Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260616-iris-ar50lt-v5-4-583b42770b6a@oss.qualcomm.com> References: <20260616-iris-ar50lt-v5-0-583b42770b6a@oss.qualcomm.com> In-Reply-To: <20260616-iris-ar50lt-v5-0-583b42770b6a@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vishnu Reddy Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Dikshita Agarwal X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4931; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=jlbWJ6BnLAb8hDHnLKbkTUpBs5ZGORWEUsmmVGvPwio=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ5bBZL7qvPUPxHc5l36bc7PoE38NQ+LNbTd93dzz3z5U/ COa+1uok9GYhYGRi0FWTJHFp6Blasym5LAPO6bWwwxiZQKZwsDFKQAT+dbOwTDvvXShePai3szm 8pm7mTavnfN460VflvIMre8m58wz7/Wxtz569OCh5eK1Rk4bBB6eM1DZ96+jNySJL1mqtdd2V+P CJbyNFdxzTetKPltnq7IYWagF/jKJ2l3w5vBOkdc/jer+fnyr2rcjy/yYoYPDw7npS6O+HYz3P1 U4cQZjEE9Qar38PJ1LTiK1R6/+Wc6jOjFANlokpGbL2r5575bZrqyuLTGvUGQvYbIvfnX573HLF VyfN2l7i9jJTJurNWMNq4x5/MWPkj77ZoYF79LL+zfpT9axvbd38+TyLPRkY3FWTBW40cpZZi18 +7V74oJLLP/PGJYF9/YJlnupFf/TFCr883D6Lq+GOsZPAA== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDI1NCBTYWx0ZWRfXzSGw2WXW8MAK ux6MdIJ249Vj8XY9PAjhDBzLrnxEGcy9Br0fs+rC1MVb+jI99dx9tPpo5gNmIGPn+qiNdeRppwc k3XMeTzKgCExbHF6e8OqBVNElzNgOeI+TzcuAYZrptua05s0hN5n2Cad6sozBuWFVoTCP38lWwj rXjKF1E7MUyu+u+3FnmZQYrRDKEVUjiQqtmtrvnhIXhBPtmV+3XpHl9g25S4h10CFIOzkYU+Kii qQ8SWMQsTcqT7I2utnBkbJNoeqzSvBJW56HfEQf3YTSfxEa3XTCqF+afj28zDL74LK6wjLhwcFg YDeX9RGvT7PgREYJXbysDrsPZ0/jKpabuZqwl+/E6Onl1P0IPm03N9DROW8gd4ulfSwAcz91BgK 20awvoZa3WHFSb2EDR54dqSSCUYKnoqyHhRO9dHKyv4Aanaphv+3MZU6N/yKxUR0Diwj+LFG9mn xP+QfO5rPn+p+SHpyyQ== X-Proofpoint-ORIG-GUID: -g3sqBp1wehgqAfug5tYnPRAz8Oxt_cx X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDI1NCBTYWx0ZWRfX+rWkg7Ixxzrr D337eJFmwgfnvK7H+xRoEBtel3t4RMMZj5D140fwoZ13ZBYKEP+NfyYvYX96LIHn5EBQ5QTreOU HnVDs8V2kTyCTV5h7nMS2//Hox04YPk= X-Authority-Analysis: v=2.4 cv=HttG3UTS c=1 sm=1 tr=0 ts=6a309326 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=2EYiHOum3YQmkHKk0wkA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: -g3sqBp1wehgqAfug5tYnPRAz8Oxt_cx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_05,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 suspectscore=0 clxscore=1015 impostorscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150254 From: Dikshita Agarwal The interrupt_init sequence is currently shared across all supported devices. Starting with Qualcomm QCM2290 (AR50LT), the register programming would differ. Move interrupt_init into a vpu_op to allow per-device customization. This change prepares the driver for upcoming hardware variants. No functional change so far for existing devices. Reviewed-by: Dmitry Baryshkov Signed-off-by: Dikshita Agarwal Reviewed-by: Vikash Garodia Reviewed-by: Vishnu Reddy Signed-off-by: Dmitry Baryshkov --- drivers/media/platform/qcom/iris/iris_vpu2.c | 1 + drivers/media/platform/qcom/iris/iris_vpu3x.c | 3 +++ drivers/media/platform/qcom/iris/iris_vpu4x.c | 1 + drivers/media/platform/qcom/iris/iris_vpu_common.c | 4 ++-- drivers/media/platform/qcom/iris/iris_vpu_common.h | 2 ++ 5 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_vpu2.c b/drivers/media/platform/qcom/iris/iris_vpu2.c index 2dc121a3f5e8..dd2eeae0d9eb 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu2.c +++ b/drivers/media/platform/qcom/iris/iris_vpu2.c @@ -46,4 +46,5 @@ const struct vpu_ops iris_vpu2_ops = { .calc_freq = iris_vpu2_calc_freq, .set_hwmode = iris_vpu_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; diff --git a/drivers/media/platform/qcom/iris/iris_vpu3x.c b/drivers/media/platform/qcom/iris/iris_vpu3x.c index dc02ced1b931..c3b760730c98 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu3x.c +++ b/drivers/media/platform/qcom/iris/iris_vpu3x.c @@ -262,6 +262,7 @@ const struct vpu_ops iris_vpu3_ops = { .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; const struct vpu_ops iris_vpu33_ops = { @@ -272,6 +273,7 @@ const struct vpu_ops iris_vpu33_ops = { .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; const struct vpu_ops iris_vpu35_ops = { @@ -283,4 +285,5 @@ const struct vpu_ops iris_vpu35_ops = { .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; diff --git a/drivers/media/platform/qcom/iris/iris_vpu4x.c b/drivers/media/platform/qcom/iris/iris_vpu4x.c index f608a297d4a3..90ccdc0d2a07 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu4x.c +++ b/drivers/media/platform/qcom/iris/iris_vpu4x.c @@ -369,4 +369,5 @@ const struct vpu_ops iris_vpu4x_ops = { .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu4x_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.c b/drivers/media/platform/qcom/iris/iris_vpu_common.c index a49113b0da23..375bcd923476 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu_common.c +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c @@ -31,7 +31,7 @@ #define UC_REGION_ADDR (CPU_CS_BASE_OFFS + 0x64) #define UC_REGION_SIZE (CPU_CS_BASE_OFFS + 0x68) -static void iris_vpu_interrupt_init(struct iris_core *core) +void iris_vpu_interrupt_init(struct iris_core *core) { u32 mask_val; @@ -485,7 +485,7 @@ int iris_vpu_power_on(struct iris_core *core) core->iris_platform_data->vpu_ops->set_preset_registers(core); - iris_vpu_interrupt_init(core); + core->iris_platform_data->vpu_ops->interrupt_init(core); core->intr_status = 0; enable_irq(core->irq); diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.h b/drivers/media/platform/qcom/iris/iris_vpu_common.h index 21ed4c9bd5e3..9151545065cd 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu_common.h +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.h @@ -23,6 +23,7 @@ struct vpu_ops { u64 (*calc_freq)(struct iris_inst *inst, size_t data_size); int (*set_hwmode)(struct iris_core *core); void (*set_preset_registers)(struct iris_core *core); + void (*interrupt_init)(struct iris_core *core); }; int iris_vpu_boot_firmware(struct iris_core *core); @@ -44,5 +45,6 @@ void iris_vpu35_vpu4x_program_bootup_registers(struct iris_core *core); u64 iris_vpu3x_vpu4x_calculate_frequency(struct iris_inst *inst, size_t data_size); void iris_vpu_set_preset_registers(struct iris_core *core); +void iris_vpu_interrupt_init(struct iris_core *core); #endif -- 2.47.3