From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FE822749ED for ; Tue, 16 Jun 2026 00:43:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781570593; cv=none; b=HfciqhKKXlQ6GB3rRm9Mg6YoeoukSPMsHPQubQAuowcRo8gQGn3OE6EJPkGK4PhoIxvPFD35Xb5nhtYiIm4lJylBEGBpLdHegyoWR/cCjOb7y1TQtQakqS8lP6OsoqFuKhet+anM2Aysx1hQFDF75NyN8kmDfoUB70ysBMA4j5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781570593; c=relaxed/simple; bh=xvBfm/pYZxiWkJLQonvi3rI/JX0mS8D9FzLrQfOuYgY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=sZRvquGpMtsfeGzXQtbeoOPEaT/ENFuKiLae6DDRy6jBoBMmfoUy3Y5E3N78UZI1ZfvbdP300qRxUfDE/GE3eTwTzt9RDknBLf/VLGtBG3zVKUR8qRxu+FsHv5zRyPFFqmgmPra167znVqB8ov4WPNQg8mZK20iQTpGVgPWz3jg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost.localdomain (unknown [111.196.245.140]) by APP-03 (Coremail) with SMTP id rQCowABHK+IZnDBqiWbeFA--.11117S2; Tue, 16 Jun 2026 08:43:05 +0800 (CST) From: Pengpeng Hou To: Herve Codina , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: Pengpeng Hou Subject: [PATCH] misc: lan966x_pci: depopulate children on populate failure Date: Tue, 16 Jun 2026 08:43:04 +0800 Message-ID: <20260616004304.95117-1-pengpeng@iscas.ac.cn> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:rQCowABHK+IZnDBqiWbeFA--.11117S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Jr4ruw17Ary5CryfXw1DWrg_yoWkCrc_Wr 1FvFW7Cayaka48GF4xAF1rCFyj9F43ur4vgF18trZaqFyxXrs7Zr1DZF1DGa48ua9rCF9r Gw1DX34Sv3sYkjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb4kFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVWxJr 0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AFwI0_ JF0_Jw1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67 AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIY rxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14 v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8 JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfU5oGQDU UUU X-CM-SenderInfo: pshqw1xhqjqxpvfd2hldfou0/ lan966x_pci_probe() loads the device-tree overlay and then populates child devices from it. If of_platform_default_populate() fails after creating any children, the error path removes the overlay without first depopulating the partially-created children. Mirror the remove path ordering on the populate failure path by depopulating child devices before unloading the overlay. Signed-off-by: Pengpeng Hou --- drivers/misc/lan966x_pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/lan966x_pci.c b/drivers/misc/lan966x_pci.c index 0bb90c0943bf..823fa06aa1e7 100644 --- a/drivers/misc/lan966x_pci.c +++ b/drivers/misc/lan966x_pci.c @@ -178,10 +178,12 @@ static int lan966x_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i ret = of_platform_default_populate(dev_of_node(dev), NULL, dev); if (ret) - goto err_unload_overlay; + goto err_depopulate; return 0; +err_depopulate: + of_platform_depopulate(dev); err_unload_overlay: lan966x_pci_unload_overlay(data); return ret; -- 2.50.1 (Apple Git-155)