From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0846925A640; Tue, 16 Jun 2026 00:51:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781571083; cv=none; b=ZCBdrD+PYfcytKW9oeD9d6q7bcLc5+2EMWakULE7snVvozgmHE4x2yY6+0DAXQDJoffUc/p7Gy/WtExDLjl9xen5W+8ysKD2PGRocC4s2ppYUicdCBr9g7oxmpn4dLH0kxQxbOAU8/SOqIySwbAHqrcV3L/rlVjzXla5F+ZdJAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781571083; c=relaxed/simple; bh=6mx2kU7lUEEySHhhKl7A8Zn9gTlfT14DRZWRQcxz+5E=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XeBcZISp/PP/XyhZDMG0zz9VEBXV5H3sG5vdBH1kGj04sgPKRwjMG+lQ9K1UP7qM0SM0JLFnvHZUZL+vgf/vCphBdIGGpmVyDObHYWK62omIogoN7vmV3DGq3vLwhwgYcww4i9IjXp5/KQtd8SQbfYNJ1Wu5CMWYoil+YK9yQC0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost.localdomain (unknown [111.196.245.140]) by APP-03 (Coremail) with SMTP id rQCowAAnSuEHnjBqMZjeFA--.7999S2; Tue, 16 Jun 2026 08:51:19 +0800 (CST) From: Pengpeng Hou To: Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pengpeng Hou Subject: [PATCH] soc: qcom: geni: depopulate children on populate failure Date: Tue, 16 Jun 2026 08:51:18 +0800 Message-ID: <20260616005118.5108-1-pengpeng@iscas.ac.cn> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:rQCowAAnSuEHnjBqMZjeFA--.7999S2 X-Coremail-Antispam: 1UD129KBjvdXoW7XryrGr47tryftF43uw48JFb_yoWkWFg_Cw 1jvF97Wr48t39FgF4vyF1akryvva9xur4vqr4DtFZIqa45Jr1DJrWDZrs3Ga45ZFs2gF1U Gas8Zw1SkF93CjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb4kFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr0_ Gr1UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x0267AKxVWxJr 0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_JF0_Jw1lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AFwI0_ JF0_Jw1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67 AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIY rxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_JFI_Gr1lIxAIcVC0I7IYx2IY6xkF7I0E14 v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8 JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfUeKsjUU UUU X-CM-SenderInfo: pshqw1xhqjqxpvfd2hldfou0/ devm_of_platform_populate() installs its devres cleanup action only after of_platform_populate() succeeds. If child population fails after creating some GENI children, those partial children are not automatically removed by devres because the action was never added. Depopulate the children explicitly when devm_of_platform_populate() returns an error. Signed-off-by: Pengpeng Hou --- drivers/soc/qcom/qcom-geni-se.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c index cd1779b6a91a..46dd7b7a8f90 100644 --- a/drivers/soc/qcom/qcom-geni-se.c +++ b/drivers/soc/qcom/qcom-geni-se.c @@ -1406,7 +1406,11 @@ static int geni_se_probe(struct platform_device *pdev) dev_set_drvdata(dev, wrapper); dev_dbg(dev, "GENI SE Driver probed\n"); - return devm_of_platform_populate(dev); + ret = devm_of_platform_populate(dev); + if (ret) + of_platform_depopulate(dev); + + return ret; } static const char * const qup_clks[] = { -- 2.50.1 (Apple Git-155)