From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79539351C14 for ; Tue, 16 Jun 2026 11:44:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781610274; cv=none; b=KFyCOM9iaNOFu/6yGKyATuNUK9Ity0uFZFBAEFdCpq0qJVeky7V5yBD98SdPAgUvdef5kL1wgoO6PyUICdWs5W2pmukyhTNjhdhKLaK6DO85UAcFrUC89ijxztRetobkzUZLb01b8LcnEi38Z2iBCeLe6xDCi1buDciozyN18g0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781610274; c=relaxed/simple; bh=aQAERmJfPCm5nxIOgdlfK4MBzHNE5MLOfzqcJBP0AZ8=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=LbWVc+4Fo5iV3eID6wA4YvPeq5Xsu3lyrzIiBFKhXwbHIM5Js0m+yNbekSjKjLNMRnjkGGoB7+D4W7Paqi3NTeQX56tBcG8SeubhoC/G8+wfCkZQmNhO2aMGnRYm/AZ9S657LI8/mkOrDAT581sZLCHdK7uWfo6IlqhaJXNIRKk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=Gg4+Suuf; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="Gg4+Suuf" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-490acbb0f89so28851325e9.0 for ; Tue, 16 Jun 2026 04:44:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1781610271; x=1782215071; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=PveeYdI2S8spK0O7FtsUe3Gj1929XE8sM0pQ+0MZALU=; b=Gg4+Suuf6ncfsfFRO+PQlTyDT3cryYpUzJ/Aye2Ys2mZPw4J9FCOwr6Aqa1K8kRnYz 07s867+ePEl9E+N51lyIqPpA4s4F3q+mn68UEZHewg9RIddV46vFwAsYJ1eYWiv1OZBS sLJaMaz2fnHOVP0dZcfir247cbCFJRj8z+TMNtTrMaNPZ27Vu3YiPpFsQijvCDLpwKeb 4TzhvMh/TrwOUoDw33tDKz1FKp5tx/gCeuMKDGkugu37TowqcN7TShLGvD49wz/mpUd4 WmhWOF+RbAwVcCJ3EH/zsdpl5uuw+sUclAzwOiQuog0ysDNevgMK4d47rJSFz2ZgGVQF +nPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781610271; x=1782215071; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PveeYdI2S8spK0O7FtsUe3Gj1929XE8sM0pQ+0MZALU=; b=rpTfrcFDfbHNLME9ZazwLq5CG9/xX2FfZTrpBzyQk8cqG5Wk/JBvAYgi+IGD/K/Ja9 Ra9J6kV2cT3ixvRZJlyoM111XGAjD/Om/wpm5glqSt/1bltFsISh+bE6MOeIiB7uk1qo dk28MbeVStxDuS14PQEH1KpLO+SaK+ZVe0ZLyFQeDTMG3glOgXfs+DRe49HsPtVCFRZi +kM/HPCAyXHluTJmgymWCdodhYams+45sP4UImIl/yw63ilOLfJ2q+lZygjRGLPhI7P8 xT4wXugu1ESh8zfwNvMVydjYuCQwJxp3k7BZTaDUbgPl20ThpjYxmyOPhfZFk4v9QNsp PV5A== X-Forwarded-Encrypted: i=1; AFNElJ+3KPlf4QeLh9rRgdkGoc/9a5ALooasx9hDlUsgTGn/rneeJrZSMBzYmRMX+lIzV1iFAmA4zJuiO/lRQM4=@vger.kernel.org X-Gm-Message-State: AOJu0Yza1tHbOhhH9nBaXFPNRI+3lCEuApeMab+zIzoh2uNwgRppfsub whH0Rzc43/EFp6pJTNuLy7sWezqyehjG0q6BFsZWp+TowPSp5ZmemVrTCZpf0NKSYFM= X-Gm-Gg: Acq92OHItwQwwLk8i88G8IhC0rl0wg6uv3cJ5dCLULAkpCAPMpx66UVm76u5lccPn8P /pQqbWrB//Pslno21QIm3e5wfOJ2zEZ/PGGzc8KiP+De21mg75Hc/ytefhYN+rkjI5TINtd/elX VLWsDbUFHx/INs9gAEeuiPRMDQtBfkM60otqYdYkGpLl5gojHcjdHorFG2jbfxE/oKc/7zqS74z jQenATukYdOIyu4lwfTAttmlX33w29A50NYOV1dIFgbCsfqKHWSKUoQt3v8ZlPCIYWM5T0GFgjS 2IwCQmYI+3112WpnULN9izwaflQ5xdpF31sWwSQKcksdGp6XuBkrrQ/YvdYGCr0gH+HBE5eO7tF x34xXxMHMyAMVfdV0VXlntZG1obmXOmfH5xPJ26W7TqFRXhqsSv0y1rpMhZsdQMyqV5cGuIzTUY 741kko4eOsGrM7E1og2nDFls0ythD2DjmSqnteC0XR8y5vp/3z X-Received: by 2002:a05:600c:4fc2:b0:490:5cb3:e94a with SMTP id 5b1f17b1804b1-492200851cdmr203396395e9.2.1781610270949; Tue, 16 Jun 2026 04:44:30 -0700 (PDT) Received: from localhost (mob-176-247-49-54.net.vodafone.it. [176.247.49.54]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f2b0c10sm44070018f8f.21.2026.06.16.04.44.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 04:44:30 -0700 (PDT) From: Francesco Lavra To: Mark Brown , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Charles Keepax , Andy Shevchenko , linux-kernel@vger.kernel.org, driver-core@lists.linux.dev Subject: [PATCH] regcache: Do not overwrite error code when finalizing cache after error Date: Tue, 16 Jun 2026 13:44:29 +0200 Message-Id: <20260616114429.1852456-1-flavra@baylibre.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1171; i=flavra@baylibre.com; h=from:subject; bh=aQAERmJfPCm5nxIOgdlfK4MBzHNE5MLOfzqcJBP0AZ8=; b=owEB7QES/pANAwAKAe3xO3POlDZfAcsmYgBqMTaoDL/q8qsVYiJUR0Tm4XZsgXBFpOQbfXOdu lMbKGi2DpWJAbMEAAEKAB0WIQSGV4VPlTvcox7DFObt8TtzzpQ2XwUCajE2qAAKCRDt8TtzzpQ2 X99FC/9ELJGz4JvqSBCCijiYlefO7sOebTCyBuCrnprgrQjTOXihE8QI0cMdX6MTs6bDTNAxSgz J9jDBdsb6QkZs+k75dVAFtHaDN/xux/upKXLYmZ8kNsEX0Jot5jg9qQ/01+fkGHIvM+VrI8VNgJ mS4KQqJ6w/dDdtBAXtit5mS/jABZmRuzuFGK1RJC1/zhYGFwzjcF2XW6gUSVdXWRk2+SbqkJmNu Ps27hC6kLlfDa2XtZor2uKSa0RkK2tGbM0Ue1QQfL/JeMDX4xPDkUl+VKIqKGbtNVwhqfPZvva2 fZSOksw8zLGj+w6nMftUF87tL8b7QzxEDeWdNpw3jiZwfRU/PTu767HN2Zh/dSlNyTcqN2ckcLN p1C5YehtMXxS4p7U7yqUks3WDOoTUPwYlSR+sJdI4CyUHMVkCkllrhC/xY41UjGYIrADlS0ny5V zkD3t0b66qEgDnm24YJeLF0FHqjke9uANP3PZPJB7Vbiphu9q5wtEN0VHO7KNEsNcTMD0= X-Developer-Key: i=flavra@baylibre.com; a=openpgp; fpr=8657854F953BDCA31EC314E6EDF13B73CE94365F Content-Transfer-Encoding: 8bit During regcache initialization, if an error occurs in the cache_ops->populate callback, and if cache operations include an exit callback, the error code from populate() is overwritten with the return value from exit(). This hides the error condition from the caller of regcache_init(), and can cause NULL pointer dereferences when the regcache is later accessed. Fixes: 94a3a95f0315 ("regcache: Add ->populate() callback to separate from ->init()") Signed-off-by: Francesco Lavra --- drivers/base/regmap/regcache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c index 27616b05111c..aa8f2efed779 100644 --- a/drivers/base/regmap/regcache.c +++ b/drivers/base/regmap/regcache.c @@ -245,7 +245,7 @@ int regcache_init(struct regmap *map, const struct regmap_config *config) if (map->cache_ops->exit) { dev_dbg(map->dev, "Destroying %s cache\n", map->cache_ops->name); map->lock(map->lock_arg); - ret = map->cache_ops->exit(map); + map->cache_ops->exit(map); map->unlock(map->lock_arg); } err_free_reg_defaults: -- 2.39.5