From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6075F3655C5 for ; Tue, 16 Jun 2026 12:35:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781613351; cv=none; b=SwCmwuTXUzDEz8hxNWMmZR9sLZoKqV0rEcwzO3nq3+Yjnjbu7u69axrxDUKlG0lvGzKZspJaCmEmmBlYd/31TajepXnTLdgDe4O85bMyIi5OOnN9hGANFygDNj0hVZs7wsy8SRxOMh8bZJ0y2CgxIpi2lo5yle8tAS8G3bwUfik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781613351; c=relaxed/simple; bh=/mmH6npz4AxufBt7XC2xb6b0PYgx//uQNM2MxYf1Luo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SjYHRcXor9GJn/fJ3Ad4L6ttJeV4JTEgonC9fh4z1Y22cygpUQAjKWvZ7xOZyDrrJB3FUP831w9v0jQzM3XuoLHtvPdE5kW5wYa391sAqsMCSyGIohvfLbYeqlJfaEHUr3bwStcfy4kgGzbyUmACW4JQwrLDkJVMNLHURfMPHOE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U7jDG/zX; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U7jDG/zX" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2bf1f074a12so44833565ad.0 for ; Tue, 16 Jun 2026 05:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781613350; x=1782218150; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hcaZaLpVNVoBd9KHF0IvuQGd/Ly3szz/z8XxvZ4OmWw=; b=U7jDG/zXmLzwFOPOsl4ANWr+7HSzmujV+UGPyyrILadzwxZ1W52JWfphaDGi4daec/ rJW8W/DfGhTZFrXAFadpen/siZHlIvuxxy53wLSLq3UMH2yIB/c+Iu6cZQeK44ErLUaP aGMfxrFcQ2OsQiNVFHqKiZ3LQSJJCxtpFrFSblXqjEEota1Qxw8wYgcRIFW75e/kZpbr 0uoP75MkJvPI8sN3gQQHsTpEw7K5sc6mKSU5+3ZsHdiXTalamvotasJ73NgveiGIc+Ts KBRqhdFCDsnf60XjQ+Trf1LBJJgKTMxxUpraD7kX8iSoQ7uikMWDcRCHJTId7096g4fG 5teg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781613350; x=1782218150; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hcaZaLpVNVoBd9KHF0IvuQGd/Ly3szz/z8XxvZ4OmWw=; b=ntw1WD43vT1HzqYK5HyAKgiyPrS6/dsqHwkWE9nsCzfLspYhsb/z3HTR+7X25z5Ga0 O5rhcAayjs8MEkPnlCywfPX2rlsYn7NN1unHQ1TZi0w5NSvoDsYCMXhLihaoMYzenz5D DtPaGVxJNOhi57YeJOR5uLucgEJQBeP4n6mtwr91my64RVtCxPec8e4eRVlo9pu8EakW NcoGgjU5/i79eSempIRfCUOjRBQfrmk8tJOcUdbNZYi7q++jR8D1UMa5FRF/hf05Qiof D75AsaN+W/NhzhiICvid7VdhxXQxc+HCLgd/bpLbPWr064oFHofMNPo/BWHwDXKshyXq dREw== X-Forwarded-Encrypted: i=1; AFNElJ9BqL2Wm6fHs05m0nmdKHVmrVlO6I5jyL6bFLMoSLWoWCsbYTNkdG2LNaWzKH+I9MtbQDh+cwwXSNgFTxk=@vger.kernel.org X-Gm-Message-State: AOJu0YyYkIVL2s30cXer+fCcsKH6dSm/av6Zsc+K+9z7DE+8GejHlfPY Xrg/WqFYkDARU4jkuMKY3MWZCXJZf5L5AqRK2Zyk0IyI2w/r/jxNfV5f X-Gm-Gg: Acq92OHalCOulvWTNr9cQYqwlickhz03iDL3A3PgHC5+eflgISIlk+ZgW7CLUhKSdql pLyXd30h4opsy7gPnq1rSFsAeOMN4Od6ablQ8TFJeDPPrr32SiBUZJqQk+wXUHKM4fm9+ZDFLvl Y6xMp+f5yFIN8XxsRv0Z3p+rdg3BAz/ktxRC3HdDipj+5qz0KRr/oGo9hsQmg4pEiwHzc5UnxYh ejiTNythWyzLrUFRSPPgWj1YwoQnvR2cV9A/CusQ2tXeXHxbzLRY6aNtW5d0w58T+9P+HqMiZ+/ h77fsvCy14tPGlF85trwJ0H9th5WBwWrmrqk6/wTGqPFEf66NsUnycXYCyZinJh6NjczDhWakgS Sw5UKn/liff+yJixqwypRv17CrwIl48J7wAxhDrI6MWD5PDfLSpxDzziiPuZA3U7lJHb/sHdS8X iYAfkJKUCYdlevvPiM0/XhuuaJipD1UBT884oHtrajPOB/WxdBt9+demR6DnXnEQ== X-Received: by 2002:a17:903:2f44:b0:2be:bcae:f6b0 with SMTP id d9443c01a7336-2c69a17a8eamr37121035ad.22.1781613349654; Tue, 16 Jun 2026 05:35:49 -0700 (PDT) Received: from localhost.localdomain ([103.87.58.178]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c4327aca9dsm130789505ad.50.2026.06.16.05.35.46 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 16 Jun 2026 05:35:49 -0700 (PDT) From: Devansh Soni To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, Devansh Soni Subject: [PATCH v3] staging: rtl8723bs: use PTR_ALIGN() for rsp_buf Date: Tue, 16 Jun 2026 18:05:28 +0530 Message-ID: <20260616123528.44278-1-devanshsoni874@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The original code was using manual bitwise calculation for the alignment of rsp_buf. Replace this with the standard PTR_ALIGN() macro. The manual math ((SIZE_PTR)ptr & 3) always returns 0 and is completely unnecessary because kzalloc() already returns 8-byte aligned memory. Suggested-by: Dan Carpenter Signed-off-by: Devansh Soni --- Changes in v3: - Replaced manual bitwise math with PTR_ALIGN() macro based on feedback by Dan. - Updated commit message to detail kzalloc() 8-byte alignment guarantees. Changes in v2: - Wrapped commit log text to resolve line length issue noted by Greg. drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c index c1185c25e..38ce3156c 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -184,7 +184,7 @@ int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv) return -ENOMEM; } - pcmdpriv->rsp_buf = pcmdpriv->rsp_allocated_buf + 4 - ((SIZE_PTR)(pcmdpriv->rsp_allocated_buf) & 3); + pcmdpriv->rsp_buf = PTR_ALIGN(pcmdpriv->rsp_allocated_buf, 4); pcmdpriv->cmd_issued_cnt = 0; pcmdpriv->cmd_done_cnt = 0; -- 2.54.0