From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 262D02C027C for ; Tue, 16 Jun 2026 13:46:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781617579; cv=none; b=NYFpTah2HCkvlGoVDDIBeX5DwqBCO6OUn0XgGVtIkF+MnqjwB2S+9Hwxbgb/6e2x9bBhvWB4yqkFRThctycGsMyUB9ostzANDL+OszEsnAdaVHCCzr6Ty3BlGszHmTVat5/pIQ5fGjx0OVISTaHskw/sTkHjLz5E+rOuYxSfaPc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781617579; c=relaxed/simple; bh=BlveFnvCyuuxxrlhkvdOrm76dEkEjcUXw/fMbQgsxYk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YusKerkOM9qIwxP9Rwi9KGEbxNTa9rDt7fBhgY2t+5Eif/unAWO/H6uerctp858vNPqEWhjC99MnHsuVVs+PhLpYpd386cM9pDhxpqt3eeGEUoLJwBHACpm8W44zKgQZtshDGZ7FiiLT1GU42Wpr3cz1rOLZCRhN40xP8vSKOMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hyEUi1Bj; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hyEUi1Bj" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2bf125989f2so33559605ad.3 for ; Tue, 16 Jun 2026 06:46:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781617577; x=1782222377; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=llhKls+j1Ixs2wr3qNDyvz9TD5apL48O8f6aX/4laYU=; b=hyEUi1Bj6+HKDFAT0/POEZqZY/IwN8cwtsUvrGPcaURX5FWY6UXttKcrnmmB+8M8hg yLJD5/is0rlBuQ13Feq1qW9o++Dk5CLj40T5DA4TGPz2YxfdKpoLK18ghLw8KIdzxiO7 m4FQ/F4X3JNHOOy7ipOtq+m9kv8DawhNG2BYWo71LWfhLE5UppvhR6W2b5tKIpOO8YRj U6luDXCRwUXE3jxdy4tYHYZ2QFEZY1rn0KtkAausnf6tScSgtFNiMaCWw+onMw1Is0XW H+8Rbuhcb1d72opEHfS8ViN8sWtrvI923NEj3TA6posMNJhEdi6LhL4q3ZCdoNucwKak 0rqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781617577; x=1782222377; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=llhKls+j1Ixs2wr3qNDyvz9TD5apL48O8f6aX/4laYU=; b=ZMCn2vS5Fi6PuvzSsdo2lOqRz2c1JvQ8nYnNOYYNtFlIbzk/e1LWRcKSqCmeBhnSw+ b7QETpsOtUHvaLRafTKJ9HUPypeIL8YuARblsvQABrrcvJkH5NxBpiVlDlNUqfQUAC33 nDqN0FX8bFPQVmOVCsajcxBTIIPVyC7A2V0hxmMLOfJJq/SUKM3CXeUctPFKPv7prRDF pnbz8+rRWX1Nq+l18r/yuUxPrDFHOv8DRgZq/4QJIjML0YqJOapKZTkjzJM41IwGMlN9 MhwV8cC1qCBBK47fmb8YioyACqqKyuzBTfU+SLHC4oEh2ci6a0MgfETjLiHSl/EGkyyI jGLA== X-Forwarded-Encrypted: i=1; AFNElJ86GOzTyyCf40x5+bxCgkKPQdM/YOdFvx6Jy+UBsExhi9BUCeoev1qlM13OhzWYMMVQj7X0+MK9sVdlySU=@vger.kernel.org X-Gm-Message-State: AOJu0YwuYhHlrE6sXoqAe5bPuaLvQfioWRPBvB3xQffvewCumfk3Da95 heSJ0OyJTmsbWtzeLsnTNZgLGS2HCN//i3q0ahUK37FvA525bRqmxw5aOCMTMFYq X-Gm-Gg: Acq92OGM6kszkLHVcKEOChHpGOWWSkJsApjRLy1simkWW+ftgo04Wn4PidlcAy684Jr 4ad+h3dwGAUSNyv5lhpMltfOPH7iTs3vEu7X/DFtFrRvK73P9tFVjm2Qh0YtlnOCHRn4U7C/NTa 7nP9C4/2YqSnBAA420o7ngf2T6LrohwDaAUzPgb1FeDLibpj2VewKdWlby6w7neGbFIOuNQhjK5 tSfE4QBtSsiK5/BnbgOG+JBucR40bKfUUYU9SnnQ2yElMT6ouVcDoxRI+Xd4xHP7lDmYPfESFVo Xo8LMY3XFYlfZ9axsBGBDWy60mn/Q2Q+t3ygXiFji8SeHgBorn+1n3y8oQwshfEhFSpeRDLfJd2 L5f4TnWWreqJn2oZkjqberPTaPsTlDSaFsc47gAuw39oCiLm83sjDE0ZSrylisH7MscS92XlO3m 8nSEVdNYBCEc24mO1/4LrmIUZ2lIDxRaUUznCdvvowYvSabYGtmWi6 X-Received: by 2002:a17:903:1448:b0:2c6:a99a:52b5 with SMTP id d9443c01a7336-2c6a99a54b8mr12860755ad.12.1781617577344; Tue, 16 Jun 2026 06:46:17 -0700 (PDT) Received: from localhost.localdomain ([49.207.217.37]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c433079999sm132366055ad.66.2026.06.16.06.46.14 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 16 Jun 2026 06:46:16 -0700 (PDT) From: Biren Pandya To: sakari.ailus@linux.intel.com, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Biren Pandya Subject: [PATCH] media: v4l2-core: Fix memory leak in v4l2_fwnode_parse_link Date: Tue, 16 Jun 2026 19:16:11 +0530 Message-ID: <20260616134611.52984-1-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In v4l2_fwnode_parse_link(), the remote endpoint fwnode reference is acquired using fwnode_graph_get_remote_endpoint(). This reference is properly released in the error paths, but it is leaked on the success path. Add the missing fwnode_handle_put() before returning 0 to prevent the reference leak. Signed-off-by: Biren Pandya --- drivers/media/v4l2-core/v4l2-fwnode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c index 77f3298821b5..93ef83c591ef 100644 --- a/drivers/media/v4l2-core/v4l2-fwnode.c +++ b/drivers/media/v4l2-core/v4l2-fwnode.c @@ -633,6 +633,7 @@ int v4l2_fwnode_parse_link(struct fwnode_handle *fwnode, if (!link->remote_node) goto err_put_remote_endpoint; + fwnode_handle_put(fwnode); return 0; err_put_remote_endpoint: -- 2.50.1 (Apple Git-155)