From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11D66369234 for ; Tue, 16 Jun 2026 12:53:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781614408; cv=none; b=cymbYdr4OraUX4e8tJFaiuK+9b1fuR6I66/36Oc8DGj/WFdF4RUoQcdn7hAw72nX0DO0DaYcH4tSYRjzhjFuphgYv/+yYV6xqAkrWX0gNi0SMQ1wM6S4xx6xAnIEnt0E/HMRJplbE2Gx0wbKdTQ25Myo48LtQNUmGsxRuV/+RX4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781614408; c=relaxed/simple; bh=YFV6+4Y2jEbzKse+72jZTF8wjPB6mANj9vZWsSG4AII=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=eTWwutupaas3KHHSOPHayODOiWL3qIJPXCZy5GQbFqDexiz7TFGlaCXzza8TLyx2T5hHVi3PQlUodiBV2VyjxLQeul87aY6Zqj4P0PvT3ygIsLoQC/hW6hXOfzTUwsyd7T5gj257YTj6T3dJT8tSZvawciBCG+UqSVTF6SIfWyU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EBMs0geD; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EBMs0geD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 070891F000E9; Tue, 16 Jun 2026 12:53:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781614406; bh=cunf4OExbjNUIQ3IMFlfRZ2EixC2QKEZi+6jKoO59SA=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=EBMs0geDe3lT8MeAAWw1XAlODv5hRecifV0kQESA1gYJgBEPeMJgY/3cZ3KNxI7zp mGsNEkZfOfjpTJ9q5YBTUuRErOtWZb6fe/10flKhFWCj2kkArSCxcdgo8hP3MU4WJD t+sVVL/gVfvUdurLLRgUux2NEPYMcoRSQ9hdlq2WZ0XiFzaCoYxYcJnAhPLGNyqmD2 e1vUPCxDk6U0RH0lJIfZ1/7s0h0AHLZVxdlmR0qlHSn3l35+PfUS4HhuW447f7IyQk 8++GXw8s8MEBaYvOIR2jmCv29B9NsqNPnU0w51KQaBjAAFR/v84BgOhwRDsrSq69+U mX/y+Kp0sjIUg== Date: Tue, 16 Jun 2026 13:53:17 +0100 From: Jonathan Cameron To: "Yicong Yang" Cc: , , , , , , , , , , Subject: Re: [PATCH v1 3/3] perf/dwc_pcie: Convert to faux device interface Message-ID: <20260616135317.546b784c@jic23-huawei> In-Reply-To: <20260615063459.25361-4-yang.yicong@picoheart.com> References: <20260615063459.25361-1-yang.yicong@picoheart.com> <20260615063459.25361-4-yang.yicong@picoheart.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 15 Jun 2026 14:34:59 +0800 "Yicong Yang" wrote: > The DWC PCIe PMU makes use of the platform device interface but > is not the real device, it's actually the RAS DES capability of > the root port. It's more appropriate to use the lightweight > faux framework to abstract this, it'll be more simple and no > need for the complete device and drivers model. So convert to > the faux device interface. I'd perhaps add a little here to say that he cpu hp callbacks might be reordered wrt to the registration. That looks fine to me but it's a little more complex than this patch description made me think. > > No functional changes intended. > > Signed-off-by: Yicong Yang > --- > drivers/perf/dwc_pcie_pmu.c | 101 +++++++++++++++++------------------- > 1 file changed, 48 insertions(+), 53 deletions(-) > > diff --git a/drivers/perf/dwc_pcie_pmu.c b/drivers/perf/dwc_pcie_pmu.c > index abf50f173202..fee040f8b833 100644 > --- a/drivers/perf/dwc_pcie_pmu.c > +++ b/drivers/perf/dwc_pcie_pmu.c > @@ -17,10 +17,10 @@ > #include > #include > #include > -#include > #include > #include > #include > +#include > Why there? Seems like they are alphabetical order so should be up under d. Other than that looks fine to me. Reviewed-by: Jonathan Cameron