From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9315338C437; Tue, 16 Jun 2026 15:13:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781622794; cv=none; b=AFGOz0eP2+HloFeyJxRCaKnSFjmlb+Zj+0fMyMZjrmWDfVlUJecoTRvEMTS0TQlZ2uuFKox/Aa0NT3OdYkzIeubrMFzF6cFVZ6pM6v6XQMal4bRHpMwmtuMS9J/dgdT0dKriQmzAXlGSr4nmiwf0uqqaWJRvxgP+rDCDC2yCU5Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781622794; c=relaxed/simple; bh=PzZIg9YZv19Mr1+tq+lHiDTvQCq0HO2p87a98wLIZ4M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Xu53PvOlyHtjQkRSFwAj62X23CW3DNsuq8r0v7E72XWG+mKmRA3qhRdNrHaBQWHxbievIn/D496MjGzkNivJxoR33ecX7Vf7i9oSs5yVL1kLuoT8PpmGhMRuSGDYthsh0o6GJvlaWEzGhKD6cCg7AGeTD+XCElYWQdyzYvYWm3A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FUBGBwg/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FUBGBwg/" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65GDxqXW3986552; Tue, 16 Jun 2026 15:13:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=nMfMGCWOd9H 89jromNavrfYC39YmqX2k1Df5HgZ5blw=; b=FUBGBwg/zNLo8IX3Z6PfkpQSOCj f4lghPf3k6R7BERSDK9RGeOjSw0JFKJSNmpuM0synWdSjDmlvhGkCBbjszSk12xp aX4abhJh49pd37Ds+Gpm3HHknnBJCp2UkImHtHoU41bhEtuWcmA6gL8qySNehztv c8fPeSPhGf948mm79OxpqxRPLk+G2+4ZNpw7pJyZSOA5ZS9zClC3Ff50KTFmWJbc XBFiyXLOcvXmV6jeA0hcLiEUhhpTzW1gO9D3cNjIqAU11i/n/K6C7TPUh0Qp3gZW 6WdX1mR3hNbMDSH9oVBvAB1et985Ex2+cuc9cGgTlSedYGlX3A65ugXULGw== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ety52ttw0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Jun 2026 15:13:03 +0000 (GMT) Received: from pps.filterd (NALASPPMTA03.qualcomm.com [127.0.0.1]) by NALASPPMTA03.qualcomm.com (8.18.1.7/8.18.1.7) with ESMTP id 65GFD12k009993; Tue, 16 Jun 2026 15:13:01 GMT Received: from pps.reinject (localhost [127.0.0.1]) by NALASPPMTA03.qualcomm.com (PPS) with ESMTPS id 4eu371bkc3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Jun 2026 15:13:01 +0000 (GMT) Received: from NALASPPMTA03.qualcomm.com (NALASPPMTA03.qualcomm.com [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.1.12) with ESMTP id 65GFAnTa006281; Tue, 16 Jun 2026 15:13:01 GMT Received: from hu-devc-lv-u22-c.qualcomm.com (hu-kumaranu-lv.qualcomm.com [10.81.89.194]) by NALASPPMTA03.qualcomm.com (PPS) with ESMTPS id 65GFD1Pl009939 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Jun 2026 15:13:01 +0000 (GMT) Received: by hu-devc-lv-u22-c.qualcomm.com (Postfix, from userid 4187942) id 6EC786E4; Tue, 16 Jun 2026 08:13:01 -0700 (PDT) From: Kumar Anurag To: Rob Clark , Dmitry Baryshkov , David Airlie , Simona Vetter Cc: Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Kumar Anurag , Srinivas Kandagatla Subject: [PATCH v1] drm/msm/dp: return 0 from audio_prepare when cable is disconnected Date: Tue, 16 Jun 2026 08:12:52 -0700 Message-Id: <20260616151252.3599089-2-kumar.singh@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260616151252.3599089-1-kumar.singh@oss.qualcomm.com> References: <20260616151252.3599089-1-kumar.singh@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDE1NSBTYWx0ZWRfXwrJCmUPA1xwT z3i2wNd7m+EDQzPJOyxgQhoZAFEVvQXXl9mI2tuVVJ4JGPD9kUebZUbxwXm7JhKsMejMHh2PiTC IoS7++iiViWaYC4uUfwaMMCYmR0vnsc= X-Authority-Analysis: v=2.4 cv=FJwrAeos c=1 sm=1 tr=0 ts=6a3167ff cx=c_pps a=ouPCqIW2jiPt+lZRy3xVPw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=FelO9ux0wxsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=2H7k_GLycxiurF5OyM0A:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDE1NSBTYWx0ZWRfX4HBJ0ApSavLU bzD41q8q/0zNQIkHwZc1vfT7D/6x/9EKcDXRF+XIZokq9yaYwqnAOaUEsBfSOgP7qtHHiOLk9Ro tzlXmUx43eq32BxiqsWpObJQpe8AkkYpsZwBY5OyUFtYS0yOXrqfadyk/rxIxVnW7Zvg4dKxpZL 1bF6SanhSMNUqiBwat6viSORQiiI/bu+8mlwFeaxClhar8yBr13S4OSUeNWUptdVALo8hs8zqpm ddi6h3GzR32O99wDrBc7Cmn/HF6hD9DkmnW85P0LEYT3c3gMeP9pSWCGvpIFzYXZ6pN2COU6smh P+KkMAEQBOM/FiLu6U8PZoQjvK9eDsaAnvJODVX1ax7De+SGJJ8nbeWyjyhbzRPhwFejW3od4nX ARNxCDvidRI55+RGbrDrW0uDYXceJ6n/cb9kA6HSFRFDEwC9EgTJAwVPRTY4TMFOjuRkbF0YETJ 4l3aVswKxmDXJ5cQGUg== X-Proofpoint-ORIG-GUID: f-OW269UIHsxnv8beBXd6lU3WEo2F_Pn X-Proofpoint-GUID: f-OW269UIHsxnv8beBXd6lU3WEo2F_Pn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_04,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 lowpriorityscore=0 spamscore=0 phishscore=0 malwarescore=0 impostorscore=0 adultscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606160155 PipeWire treats a non-zero return from prepare as fatal, marking the DP audio device as a dummy sink when the cable is unplugged. The active_stream_cnt guard already prevents any unclocked hardware access, so return success instead of -EINVAL when the link is not active. Signed-off-by: Kumar Anurag Suggested-by: Srinivas Kandagatla --- drivers/gpu/drm/msm/dp/dp_audio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_audio.c b/drivers/gpu/drm/msm/dp/dp_audio.c index 41018e82efa1..df222943ae57 100644 --- a/drivers/gpu/drm/msm/dp/dp_audio.c +++ b/drivers/gpu/drm/msm/dp/dp_audio.c @@ -284,10 +284,8 @@ int msm_dp_audio_prepare(struct drm_bridge *bridge, * such cases check for connection status and bail out if not * connected. */ - if (!msm_dp_display->power_on) { - rc = -EINVAL; + if (!msm_dp_display->power_on) goto end; - } audio = msm_dp_audio_get_data(msm_dp_display); if (IS_ERR(audio)) { -- 2.34.1