From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D27546AF11 for ; Tue, 16 Jun 2026 16:22:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781626945; cv=none; b=AIpRcFg5+mz9o6wwKjIcGpdgSzLlLgXq3jUxC71NBlyc5chp6QL2rYcQcs+E7BrIedYoaBCCEZiRLy9VKHvDXOCg3P1Au5hlOFaQbJz4oxbrB+3t/hA02nWKANum74Iyn5UkwLFrbnIiMeGJgmswDI+YqDO11FzQ81DPnY0OqTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781626945; c=relaxed/simple; bh=41zPCEol0eUufpMQ9H4c98v89lecisBNOafqo2EcZA0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=khUFN3cMIiw3U4BgHhEPz2XR9bL7tkU4z9YXIzpwMt0lVmRJMqmkSeMVyApDoiaGUbjQLv0WLfiPrNQ/ekNG5eYwNuMAVc9NGvhnuOmuzGJ+HI1kOqBjyjHB8KwM6NEfpQaIr24sP52cEVOX9I0R8uM5XXYtZ40sAxm5a1Y1pgc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U6rsdRmj; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U6rsdRmj" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-36dd65b95f2so58198a91.0 for ; Tue, 16 Jun 2026 09:22:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781626943; x=1782231743; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=66s/Cqlsk2WljPV0p2lHq/M1AWz2z3pkZtLVHbifA+k=; b=U6rsdRmjVYvJ4CVnUtoFaZVesed9H0tlWtGehxNn2I32utjmWkqlaSOLtQq/G9JkPK M1S+k7MqpPVEs1oMPo4GvutScCfBSlIaa+GA1Y1Z00LpQXrnxuWoN2W2GeICyAQZL4p1 R0iFJEPPDbRA+p32vDdnDkl1I+e8BP/1dghcUdyc+mwhWdQLOBcO8ksKqWk0LOITXzo4 ZwqhzyYKgvVxcRfW95lVeRaBPJK7uz+AHk13pLgrhb5EcJlN+U86Qsv+HMNYWU8xccNF 4/fcHAXA8maxtUUkNFtjxchD8wKFS+RhNttxGJmIhuxuyhRrIqCFy/dYa9Fb+czoWJcz 4jtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781626943; x=1782231743; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=66s/Cqlsk2WljPV0p2lHq/M1AWz2z3pkZtLVHbifA+k=; b=eSH659i7L2xZjOokjYYshhu4PQz0O+Ld8oOsU9HPw/BKfOhb6SdoP5TS/SI6n2BBM0 xHyjabhRLODLcN2DGA//O08dPfpMWasnQqw7pezw5vPDu7eRyFQyCb58uXJ9jpRVbNno 64pNMaNkXFZUk1vLZoqBX8nUccAHd/GvxS3tnJQVJgBZmRoCipibm3N0D6IJlfYJYAaU cMQuGcEo/D4lzwR7hkJQW+bVxd0yPZi/WD+9Jo7I/R94hgaKn2b3+wQbbBQD/ZZe37QN HDP5w/j1Z8bweenf0FMxcYyEVzVDWv9/IM5ADVSe/Wxb4+je9Ctl4gEXRsBx+x7uv8Dg /wVg== X-Forwarded-Encrypted: i=1; AFNElJ9wF7agD5Abxc+WX6KLiIN4wf7tEHLBziZ7vpk9MLeVlUEOCx0f/dyXZTQUh4pIKwhow/iZfZbyTk0udd8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+ZdmajFijSEpdwYQzN4OzOh9/u9MSH6Imh/XyVY3b+OxM8FrO 61jwPXtzIMzVdV6RiQiTGMOA6I0EO/cdgzbhErE0HZjUv/Xe9qj22FDH X-Gm-Gg: Acq92OFEzw13RYpEVA3phdoLWAdr/BgdSsFz0r2J82v3xan6lc60rkdQZM48jU3VBvY XiRzBs76T1sX77rVATQO7Z1RGaaxluCWBTnEit38hVNWFzTuluqF9mCFAzPL8gOZhJOidMudsJu FQjz+k4E+22Ka0Emt91x9tQOEZLE+kgrPOT6vtedRj0Iq+b7mDViXFv/L+4HYMsz1Mv1wHsyTb3 w3OyMBLCFqf9QBvwclq2U1dJ53xadwDWNXvCH5OJxwdz9epFKlP5CwxaWNkQNuDdhHk1fHV1hVC kM2+qoS4h81HkJU2soVRsmVfeWrFFS2Us3tC4KCdyj8IkCjLCzMRENPJuSQuJMGiNf5fox6hHzL negkemR6XtYjt0hZF+hSPiN8VFzy4lr3bIthNNkeVNa3mWbW5tyPfljJ5/3MAo+n5EpuuFHrksp d87pS7dS/02QqkNgkqtmCJpSThJW6lB5Qovo0ysy6tYblfG1iu+EeX X-Received: by 2002:a17:90b:4f92:b0:370:aa94:1662 with SMTP id 98e67ed59e1d1-37c8e5a9d5fmr220652a91.9.1781626943607; Tue, 16 Jun 2026 09:22:23 -0700 (PDT) Received: from localhost.localdomain ([49.207.217.37]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37c521e76d1sm3360775a91.8.2026.06.16.09.22.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 16 Jun 2026 09:22:23 -0700 (PDT) From: Biren Pandya To: sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, hverkuil+cisco@kernel.org Cc: jacopo.mondi@ideasonboard.com, tomi.valkeinen+renesas@ideasonboard.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Biren Pandya Subject: [PATCH v2] media: v4l2-core: Drop manual fwnode_handle_put() via scope-based cleanup Date: Tue, 16 Jun 2026 21:52:09 +0530 Message-ID: <20260616162208.56488-2-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260616092516.46339-1-birenpandya@gmail.com> References: <20260616092516.46339-1-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Simplify v4l2_subdev_get_fwnode_pad_1_to_1() by converting the local fwnode variable to use the __free(fwnode_handle) scope-based cleanup macro. This removes the need for manual fwnode_handle_put() calls and naturally ensures the fwnode reference is held during the device_match_fwnode() comparison. Signed-off-by: Biren Pandya --- Changes in v2: - Updated the commit message to remove the "Use-After-Free" language, as there is no vulnerability in practice. - Adjusted the implementation to declare `struct fwnode_handle *fwnode` directly at the point of initialization, rather than at the top of the block, conforming to recommended usage. - Renamed the patch subject to better reflect the true nature of the change. - Link to v1: https://lore.kernel.org/all/20260616092516.46339-1-birenpandya@gmail.com/ drivers/media/v4l2-core/v4l2-subdev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c index e6b133ef7850..806b059410ce 100644 --- a/drivers/media/v4l2-core/v4l2-subdev.c +++ b/drivers/media/v4l2-core/v4l2-subdev.c @@ -1243,15 +1243,14 @@ const struct v4l2_file_operations v4l2_subdev_fops = { int v4l2_subdev_get_fwnode_pad_1_to_1(struct media_entity *entity, struct fwnode_endpoint *endpoint) { - struct fwnode_handle *fwnode; + struct fwnode_handle *fwnode __free(fwnode_handle) = + fwnode_graph_get_port_parent(endpoint->local_fwnode); struct v4l2_subdev *sd; if (!is_media_entity_v4l2_subdev(entity)) return -EINVAL; sd = media_entity_to_v4l2_subdev(entity); - fwnode = fwnode_graph_get_port_parent(endpoint->local_fwnode); - fwnode_handle_put(fwnode); if (device_match_fwnode(sd->dev, fwnode)) return endpoint->port; -- 2.50.1 (Apple Git-155)