From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3659E32E13B for ; Tue, 16 Jun 2026 18:30:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781634622; cv=none; b=CD9DC28GtOMTpWIRtizgJdz0N/2+2hcNFMCYbPDY0SffUDE2PJRkENqcRm29pHKibq4xGB6vwCKlM44PpkB4bZnj0ufu+KzhTXBotdM1/qWdiDSlVInnyrurLx9HAkD8XNXwhxquQ7CdkV6EiDgkRSuwslve3JzXRrk0iJnTX/Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781634622; c=relaxed/simple; bh=7bWL7uUaWVpjOFK7KGND3N73dvQqoB8oILQDZFP/+NA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HolqfqCMOG94pZsSvwO2Lsu/uyeFAhtWGj9bV8Ogbg7PHTHFDQf0E+DEvo/CNT6ooha+OjVRX3Pvd+650f/umoxgTPaKaiJFb8BpnfzgdnTR9byRr95+mjhNGQ+A5qjz8DIUlCJm3LzQ3VMRkPZWvrw4kAWKAw+AXX4Tl8qrKMg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WWoVH4yH; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WWoVH4yH" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2c0c3546924so31803755ad.3 for ; Tue, 16 Jun 2026 11:30:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781634620; x=1782239420; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KEi1MjXj+z1W6jRPKa6Or+XS7xlVkfSz1SFMtHSjLrM=; b=WWoVH4yHxw1tr/iw7HXfmGeYIxvdhEmfceNRauk3fflN2EktgY6upJG7QxyXTb2KMy iJhs5sZP+iWakVKlaQ/9228B9xZAoN+uHpklHoqEsKtSt7cH4q3rWNIWNpEmx57rJCZ7 jhDxHiWI0TQmcX+Maz7VarRynHGkZUgBW0MJNOm7lCDM/RFinQTrozQKFHwf37AX5G+K oDwVmr9ThN2GTt/ymrXA+9mBHXSxYfH3ohnitQXkEn/L9AjAy+iSYTAOj6AH0OV9AEuF 6j6V7Exyz4zVcRpih+E2zpe+vXhDqNUARLlXzOwHamxjsBvWI6vtmDQOTyEImYGq40b6 +hGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781634620; x=1782239420; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KEi1MjXj+z1W6jRPKa6Or+XS7xlVkfSz1SFMtHSjLrM=; b=CGE8F+Bjy3N/5Ph+6Xif238oyrrAbNPXgqL5fPO5DT60mfX5eUVlNKsp+NEasqdQX3 avCxb1MJjtMNGpskfX3oaudCOoluli92iEWUpHXIs1MDAhVhTq+fGagjkWhkGQtjUnsC rO/ACMsZG/IBlQiEgnoTNZJPJf1MeRDI6zMdIwcLBz8+EpGNXWbNKvWWTevQVAujJwCe 5Rd67Ae1NpmS6AM8/Vl+i8/bBw33UH3dYsZBbx7jnP0+rtA8rTo3OidCttRREbtE4kjP 4qvlDcuZwxg/DiKr35GGH6WKJzkEbnYJG1cmmD2v3dAa1LyX0rwdZ6nOLpKBDah3IWeL +mxA== X-Forwarded-Encrypted: i=1; AFNElJ90F9881yM/5PrhrL7IT49ddG8wUqs3KdhLKQkg8d04B412qLQD4ogCTyrEmIcuUgpoopjklAsE+NJQUYA=@vger.kernel.org X-Gm-Message-State: AOJu0YzCXiv8QRWfdSCn152thFnT8O2F3wPhA1IqmrHuedeFHdo9LI0a 7YDWaDSLtaXiHFoHh0qSpMTQOlgYPJMPGYhW0tHFNC70RMXVj/hAENOo X-Gm-Gg: AfdE7clXrczY1ajtuuvBlnkuKJ0+cay3RaTz+hzQ81BoG4+u9m2WWlxBkrWRY5v9Cqn frWJfleyaRuAL4VvQEmEAfaaD5S2dITCvZQjtPnmzZFXQjIzdTjNYpNewLQI8iROT1BgT9RIYzv apettYDeaLVlNMNPqObU4oFMMJ22BKdtFwlw83zsGHZy41oIlSl0FV0YJIEBEUOCLRy61Sx6PpG u80hoY0bThU+rxWe0OwmvsDnHFIDe8OhNszvUhBjx8zBxSN25QX2FE7/dsCg+OS45LoJhQcgN51 K2fZ9f7P96f2oGpirI/MuFG5yWfejawDU50Gt886R573nRp5Qg/cst1MV3ijNGvpML2OvuPtrjF P9pyt2ixDfbKWZk/hieZHYd9nO+a7jWMdWwFvR+7eNAYfrvvskPT5rpdUFvjy03AJ8W6Q4DdM6y it/WBQ7UIS1T/ZnUm04Q== X-Received: by 2002:a17:903:46cd:b0:2c0:b932:867d with SMTP id d9443c01a7336-2c6bc23127bmr2340595ad.29.1781634620506; Tue, 16 Jun 2026 11:30:20 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c43345e3ffsm141092685ad.71.2026.06.16.11.30.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 11:30:20 -0700 (PDT) From: Sang-Heon Jeon To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen Cc: Sang-Heon Jeon , "H. Peter Anvin" , linux-kernel@vger.kernel.org, x86@kernel.org Subject: [PATCH 1/5] x86/setup: remove unreachable memblock_reserve() return value check Date: Wed, 17 Jun 2026 03:29:52 +0900 Message-ID: <20260616182959.2429774-2-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260616182959.2429774-1-ekffu200098@gmail.com> References: <20260616182959.2429774-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit trim_snb_memory() runs from early_reserve_memory() in setup_arch(), before e820__memblock_setup() calls memblock_allow_resize(). At that point memblock_reserve() either succeeds or panics, never returning an error. Therefore the return value check is unreachable, so remove it and the related logic. No functional change. Signed-off-by: Sang-Heon Jeon --- arch/x86/kernel/setup.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c index 46882ce79c3a..f9395bc632ca 100644 --- a/arch/x86/kernel/setup.c +++ b/arch/x86/kernel/setup.c @@ -742,11 +742,8 @@ static void __init trim_snb_memory(void) * setup_arch(), so there is no need to reserve it here. */ - for (i = 0; i < ARRAY_SIZE(bad_pages); i++) { - if (memblock_reserve(bad_pages[i], PAGE_SIZE)) - printk(KERN_WARNING "failed to reserve 0x%08lx\n", - bad_pages[i]); - } + for (i = 0; i < ARRAY_SIZE(bad_pages); i++) + memblock_reserve(bad_pages[i], PAGE_SIZE); } static void __init trim_bios_range(void) -- 2.43.0