From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C6B334FF79 for ; Tue, 16 Jun 2026 18:30:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781634627; cv=none; b=M5munt73pMTlSwIOFEDY7lFJIoXwERxVYYi1WxmQnNGhh9XeqCt8l8MVENfTZwloEn0EKNr9ib4Hz+vTedlBLpMuAT0LrZtHTa6+BM6jB/occHkPTYX4AtoBbV3rKzg4gOKuPo4uOZiR+GxRGWIgup5vM9BnvfHOmboZQe4Nnk4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781634627; c=relaxed/simple; bh=dybo8/HrHeGrJGasUpHRaqT8xbB02VCrzfApuMlEzCs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NPZQObsRdhPkb5GStCJ8egzSYKu7KiPTRwAMnblI5EbFXToeuQgw/0R7RPOHBACB/LUG1WhCfpEgPScnPyjocpeHdIYI/i5cuGGxnL6VGyopGxa8xae0NEpZWVH79jSv+BohR/ydAFG5suCZSrLfWbotNVNdT3R2VPkUJji9FLw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iO9AK9QN; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iO9AK9QN" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2c0aa420401so36521695ad.3 for ; Tue, 16 Jun 2026 11:30:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781634625; x=1782239425; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VtnXNaxn+fspW0Xw1nKXB6TGSGdVBv01OAGdj8wNpN0=; b=iO9AK9QNKZ1IT2DAT8O1Mcvvx2XZ5Yr327SVGETMj6+5xFRx7/Bx90Jqvjt7WViJhI qbFJC3Dun40Yj4SaS7b6t7RGzznpcJhMIU/ZURvOyM+HXqZJk7w9Guspb67dFvapISMO NYq0dGS8YsC3K/Dj1mEi3Idgn9mFImY3YV2sVEOA9CJxY931JmCiK2tkZnvydgwe9lwq WfxlPBanBfAdjoZZb7erSgSIhsVJ2Nlnqkd7cMRe79dusfxADMV60DX00cKcRXHuvUEA koKOvdQ0B9iJjS8mAPWYy3G1SUnQTh3Jv6WohZ7ayK99HxEpNqSCjjrpxWcTe3JNXUsx 9sJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781634625; x=1782239425; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VtnXNaxn+fspW0Xw1nKXB6TGSGdVBv01OAGdj8wNpN0=; b=Eo0UN/xb1v56+7TsoIVNBcdO7SfXJu1UFwTFXlDuRKPtOzpBTOJaxiQPonM8TvLFiU 32k4iI0dJl7p3hAlQq0j60WCJV8Srmlr7nOhk1dtszxdcNk+kfD6hrtASUH2ccvWRt/v UAPEGv3ibinMJMhkSqPDk3dkG2HiHrLzknOEOgOr07mkCqVs/AbANhEtYVBRG1x0M8Mg v308b7HBBGAVd4jHfJ287qgkX5H/QDAjJ5EcWV5lT6B7yPREYM5ZOuF5H4+ehS0GpCiW STK+CNPfacVXxCmQP8VWQMEVw4sfdEu97q8pMejvcpN4+heKve2vIMQXaqt65EQWNGK2 GKug== X-Forwarded-Encrypted: i=1; AFNElJ8ObN6DTJiHjpUEvA9LPNWqSo2vikTnsJkpi/dnIOINgCE+yEhHEcuKhA+0IlOvqfqak5hUikEX6Dzodik=@vger.kernel.org X-Gm-Message-State: AOJu0YwnOpaLtJ/ubcc1PobmED8rdx7hylmnaVlQ85FrAymPalHrFkNc gSoRVNk1gvApbNs5D1bhiVewEZtIYMwr3lxfkW2bd2UkunmUd2difQHR X-Gm-Gg: AfdE7ckWfQsJp8obW+yZIXBk2nSQsNJi+lnzlJZBN3USwVsHLmtLA6n6IlSJKwvVmjP o8xmILSIA+mCoiZYGV3UuyvZYe2EF5QfeIcky6wbHxBxRz1duFu9y1JB7Q+edb8xy/e5FG/RrlP pPmOIuxEuhc41sIiW6No07SwAkzdgoECNKzDtwrfExS5onNugppmNJu+ZpIfDJwhXPJb9xkWL6y 3D7nks2Y9D9K+oO9XOZSQ9LcQoPxmdv2jbzbzmRLO2bZbV1D0PgRvf0MkUDNjY/8tppTqp16t1K +xIBfX0XrhAsiiYJHv0fyRnbZFbXjjWHiS3/uT0j/FCWsISuisNx72o2MJ3vl/sd2rDwUSEo7Ax XWze2V5MFX2/sYTw+7/5vNj3C38xF7iUiBrGOjX8Jz3atX0NZjajB5rh2m8egrE82EGlupsUsl0 I0ubGl6Q2JLF+YGaoJaw== X-Received: by 2002:a17:903:32d1:b0:2bc:f1ef:2e64 with SMTP id d9443c01a7336-2c6bc0c8905mr2089075ad.12.1781634625343; Tue, 16 Jun 2026 11:30:25 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c43345e3ffsm141092685ad.71.2026.06.16.11.30.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 11:30:24 -0700 (PDT) From: Sang-Heon Jeon To: Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz Cc: Sang-Heon Jeon , linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org Subject: [PATCH 2/5] sh: remove unreachable memblock_reserve() return value check Date: Wed, 17 Jun 2026 03:29:53 +0900 Message-ID: <20260616182959.2429774-3-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260616182959.2429774-1-ekffu200098@gmail.com> References: <20260616182959.2429774-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit reserve_crashkernel() runs from early_reserve_mem() in paging_init(), before the same function calls memblock_allow_resize(). At that point memblock_reserve() either succeeds or panics, never returning an error. Therefore the return value check is unreachable, so remove it and the related logic. No functional change. Signed-off-by: Sang-Heon Jeon --- arch/sh/kernel/machine_kexec.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/sh/kernel/machine_kexec.c b/arch/sh/kernel/machine_kexec.c index 37073ca1e0ad..ba9c412f14d9 100644 --- a/arch/sh/kernel/machine_kexec.c +++ b/arch/sh/kernel/machine_kexec.c @@ -165,12 +165,7 @@ void __init reserve_crashkernel(void) goto disable; } } else { - ret = memblock_reserve(crashk_res.start, crash_size); - if (unlikely(ret < 0)) { - pr_err("crashkernel reservation failed - " - "memory is in use\n"); - goto disable; - } + memblock_reserve(crashk_res.start, crash_size); } crashk_res.end = crashk_res.start + crash_size - 1; -- 2.43.0