From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29FC636E47E for ; Tue, 16 Jun 2026 18:30:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781634631; cv=none; b=jrviYSFmardpuxe6WzFtWWiH0WqcXq86eMfwVwSSdDDKsix31Lu6dpURdEx6yPROpfVeJj7wnX0LNG0iWp7Lcqj/MS292mRWy/Qs++2sjNdRA+GbmiLuMazddoQ1nQn4Udpt4yshXSZ6OJ2KrcO5wh+xHGDCBxFBm/2jwWsqrDg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781634631; c=relaxed/simple; bh=DEagmJuOkCERPqHx3QxiQ/XX/qQrU+kVJ21V5t2ympY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jcVTRiO0/zQaykgjzqQbAYd6WKtIezOwoYwfiTQf7xihHh25zcq7cWqYTMkO8vZXhG6Penh0/YCqnmXR35EvVulmLByJX92MX4FFhHZoeI6ILoVNm9UgTl5FcCoW9xIQjzTXa4wZXIn02LJLJG6jDhtvW3c8/KzG9iPVoR0SviQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZerISIfr; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZerISIfr" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2c6bb8a5980so736415ad.2 for ; Tue, 16 Jun 2026 11:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781634629; x=1782239429; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=K1he5shRljJErqV+epkFIAgUXMzw0QNV0w27axVOLuE=; b=ZerISIfrEMb7ZWfZa7ORwXFBxWd/w4+lDqvN4GxFk6cNlwlUJWDty0AgR64XykKhsC 9MRumC0IbKXXPwWJW68XubP5JGZ5CDocbmxrFa8mxbg9F9Oazhpk6zOgZb/wIOd9yJiP DCK1+U9TchKyvZCMj0uKLXM8wPrRvSxQ3dISFLb/0pCv8WCn/tOQ2mS09eeK3Ac2+pEx P1sgK0n3mv+2FEyR0lCyXwYR5vzPxUeRk8l/jpAWnIR1GgeCp7UpyUvDeQQgFp6spjpS pnL0x/ZHhSA80bEKHtRcMDbuySWFh1mvZazpjGOmX96Ce19ky4k0Hq7tRk10vQfRGwG2 5nsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781634629; x=1782239429; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=K1he5shRljJErqV+epkFIAgUXMzw0QNV0w27axVOLuE=; b=MlFAe+LAmunMhCfG+1IRHaq0XnHmqmcbt5wICvLB0lGLou39H7rVb4Ib6awsqrlFIH 0+VAfTsZ/E3U147/HRpzR5ecdY30v5+x4gykAk8jyczmQz7QpEvPqDga9akHGF14HURP YyXyd1kK6ybxxcbHf3e/Fm9eFUqBEsmyDbEqQfQkxFVxgI2eTNantZIlmqXMQ8j20+5+ +wG7qqsmOJ8OvWGjd9ryjye9a7NP19qHJpHxJDjjLs/b309DSigSKPuxj8YpvwXShDpM XJMtuF3eNu2gr1SWAvbhZGyLx3UEH6C+IuOQgGFgz6sHsbJSi290+bOGkhXwaMsxqmSG KVSg== X-Forwarded-Encrypted: i=1; AFNElJ/ZHF8ahLNiUYtDP2mGaq6zLroWCYSNF7AG/ccqmWrKZeTVrVZHiO4YKbn6BtpyAx5rFyI4XcgwVCe9iBo=@vger.kernel.org X-Gm-Message-State: AOJu0YyyT3tCLZH7yIqLMq7FF1+4umJlNtCRA3ghm0QiNnQv1E79mdTu yg7AdrWNr791EBNoqAfzi/eTxfr6ZxPkVo0aqOex01LZbxjhiE85u2bH X-Gm-Gg: AfdE7cnN2TuQ35a/Q4gS1xyKFJMkVeqO8U+qTc8M9HsZ565p8EQ/w8e4JYZO1J95NLv V428DRfP8XQ2p/DgGHZmgB1sq8EyomNMi5s94gnSPJWBTCD3lqzdgsFHruEMmIjhbZKV1KvD5Mw /TP8qGDHt8RjQae09i2LmWJFYM4FDuIcj6nyUW5miTGbK68H2hOd9LwN3eawPntSqAlxUQhGfNn BiyxsWbzghB/XGMdBpR+nk/shFNft/aH3A6Keawww3T9VvklyYk5lLYoMCZzy5m2ZLY9ttqcXXc m2RJMUmlnlnf6pR8eeQ/ddA4QVzt7AguPNUzk2ewRP6wLjjw4K6xb/kaRSG2QjgdKDsKY+lLbqi RXnSRKFBltvPrGyzkzq8cIvXv1OXcnLU6QXfJpPJ0TSLmO9dWtR3sVSZsardZDmIJowdxxHzQgx ISnMHsMnovJkF5bKwcDg== X-Received: by 2002:a17:902:da88:b0:2c2:245a:336c with SMTP id d9443c01a7336-2c6bc0aa0camr2020545ad.14.1781634629498; Tue, 16 Jun 2026 11:30:29 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c43345e3ffsm141092685ad.71.2026.06.16.11.30.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 11:30:28 -0700 (PDT) From: Sang-Heon Jeon To: Madhavan Srinivasan , Michael Ellerman Cc: Sang-Heon Jeon , "Christophe Leroy (CS GROUP)" , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Nicholas Piggin Subject: [PATCH 3/5] powerpc/fadump: remove unreachable memblock_reserve() return value checks Date: Wed, 17 Jun 2026 03:29:54 +0900 Message-ID: <20260616182959.2429774-4-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260616182959.2429774-1-ekffu200098@gmail.com> References: <20260616182959.2429774-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit fadump_append_bootargs() and fadump_reserve_mem() both run from early_init_devtree(), before it calls memblock_allow_resize(). At that point memblock_reserve() either succeeds or panics, never returning an error. Therefore the return value checks are unreachable, so remove them and the related logic. No functional change. Signed-off-by: Sang-Heon Jeon --- arch/powerpc/kernel/fadump.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c index a313b1653124..88ca6156b81a 100644 --- a/arch/powerpc/kernel/fadump.c +++ b/arch/powerpc/kernel/fadump.c @@ -154,13 +154,8 @@ void __init fadump_append_bootargs(void) if (!fw_dump.dump_active || !fw_dump.param_area_supported || !fw_dump.param_area) return; - if (fw_dump.param_area < fw_dump.boot_mem_top) { - if (memblock_reserve(fw_dump.param_area, COMMAND_LINE_SIZE)) { - pr_warn("WARNING: Can't use additional parameters area!\n"); - fw_dump.param_area = 0; - return; - } - } + if (fw_dump.param_area < fw_dump.boot_mem_top) + memblock_reserve(fw_dump.param_area, COMMAND_LINE_SIZE); append_args = (char *)fw_dump.param_area; len = strlen(boot_command_line); @@ -632,10 +627,7 @@ int __init fadump_reserve_mem(void) (fw_dump.ops->fadump_setup_metadata(&fw_dump) < 0)) goto error_out; - if (memblock_reserve(base, size)) { - pr_err("Failed to reserve memory!\n"); - goto error_out; - } + memblock_reserve(base, size); pr_info("Reserved %lldMB of memory at %#016llx (System RAM: %lldMB)\n", (size >> 20), base, (memblock_phys_mem_size() >> 20)); -- 2.43.0