From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA5D63DC4D9 for ; Tue, 16 Jun 2026 18:30:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781634634; cv=none; b=P4GRHP6xVqySdso26n7HcjT0D8xGg/7tEzFQ5tUOF9QNiLRkG+i6jGqAlCIi8boYD9xp1td+x/lUqrX86E7HVqvVcTu5JoqWlxKhyYKqNgeHA3uJzgzF/0NsTsFDhhJ0pmBHg5mxFA1BRWdSoc89tfElk4ZS6xqB+1UxiP0EJrU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781634634; c=relaxed/simple; bh=+4oo3m2ArdTtJjh1PvNQw0FG0nTQSld32N4HDZ9xpoU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AG6mi3HrdNBLO+vhQFZp0eV8hr6eMiQM/GwvNeRTc0JeYY6ODE90ht0as2mmQANijr7n2/0uL2EAR6Mm0xU6gRe+sVvIBk9FC5rhrzerznXMmgKoB5IRsHLVjYZ/Yw7ooqus+F+CMW7oPSxxVvkoOZLU3XBQxsDmHO4M8mVDfPs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AMgHsO/T; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AMgHsO/T" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2bf30d530bdso48277695ad.3 for ; Tue, 16 Jun 2026 11:30:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781634633; x=1782239433; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iUdu/4xkrp4af+ENG/+dz/iliEwP+6UzwIHbpWo5uXw=; b=AMgHsO/TqVXH65RiPQfUPgxqWYOwR8HPYs7a+24Qp6jkoAjMG6JcbWzIDbQ2FZQi4u oz5euL0UnFl0UBTir2cVy4+HSOgJ/txyCBtkN4b35qIcc3oXsbChh5DGndYfUuTc//YA XGlhldcIMN5HkMZhuU4YrQdKVGc7y0LSDEGQp3NrnwqcHL2KWrjeerhNOo5aBu9/LCjw OgcSWZC0yAaoNG460ZGZ/+iqKfiIJ0Z1vQSFBnpocAXHrk95BZNYS2dpRPs9IaE/Kfid p/kmZVxk6dG9uWR9clVHbrgjNiz/3t0yO7L+rcW/Kec7z251Z5fHFlRmBQFk0J12pyBn fWCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781634633; x=1782239433; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iUdu/4xkrp4af+ENG/+dz/iliEwP+6UzwIHbpWo5uXw=; b=lQePEb6eO49oexohFg5YQkwT7AiHHlZrT1+YKzi2Vhf9muMPxQuoXUR/tuptjAhUt0 MJ0YSjl0/QLFUUV/15NlU8+smg7crI49OyNSkADmBosepk9JAmZ0pPmc7oaNbJ4aiZgf /iozilzZHoE1bPKM9yunqFeejmzH4/+KOsZ7l8Cxg8t9d1H/5aBRn7EMApXBY/iA5nEk NwufgGOT2eC4afq8gImGTFO5k5rTxJZj6SLu6yvi1e6zOIojn5bfJXp8VfGLCFcy7U2K OBVWsOoyE5TkQpy5DPI80eZrAzdbS66NFgtH0AnJb9gCVhxe+DEM1NhrTm+aBgyWLi31 6waA== X-Forwarded-Encrypted: i=1; AFNElJ+2722oWeQ3y5lQW1meWSU70qRcEf0D1goOHUFV0pl3YUlf/YNvr9T/HP/ez0U6jiS/xBU6vJ5s3Ptja1o=@vger.kernel.org X-Gm-Message-State: AOJu0YynAQ53Aeecui68jhjtGGoHNYhcIjG26THApz+BFz/9ydhsDRTi mVzJpM48YdkyPpFiyT0pyRZNuMBqa4k+MYhQCagmoamtxn8lXLwycCH6 X-Gm-Gg: AfdE7cnQ9s6X04SGvSCQFCerrQpmHWdLZhhvnVSBT5hwZgPYq7DTkhm/IfQZYoFv7CS Xt3Od/fYb1H73pLrUU/gB1eSmsrB2Mijb9gVXKql/l6K5RvrppxUTWg+F/5exporMkgJbs4M2HP f5Y7BH0LUG8ql4AUOcd/dHYrO1eXRYKLa5DhKiCr2gBoATZIWDkANSGOjpBhrLmkFhFpCno4SUC TqtxP9zQDp6FKP8lM/qnTSg8QOWGx2CU2DhSKIfN038Ex1exeTAcW1Jf/bQk+n9xDls1XbzMpJM dpmFNBAQ9jlkvoaUJlz0XufALjseHtq96PlX2tInta5Sfg1JZCEp8oaAkFr1M8YxscqF8xYE4iU dnL31jBbPeufxhp/oDT2qep6HLPRymq+4lp98eNZ9K0vUrGQYStSI7iL1B+r/Uiixyt7qvWBecN gq7z+sq1M9QIWVXLMVwA== X-Received: by 2002:a17:903:3c4e:b0:2c0:ab92:584c with SMTP id d9443c01a7336-2c6bc249111mr1888095ad.25.1781634633083; Tue, 16 Jun 2026 11:30:33 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c43345e3ffsm141092685ad.71.2026.06.16.11.30.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 11:30:32 -0700 (PDT) From: Sang-Heon Jeon To: Chris Zankel , Max Filippov Cc: Sang-Heon Jeon , linux-kernel@vger.kernel.org Subject: [PATCH 4/5] xtensa: remove unreachable memblock_reserve() return value checks Date: Wed, 17 Jun 2026 03:29:55 +0900 Message-ID: <20260616182959.2429774-5-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260616182959.2429774-1-ekffu200098@gmail.com> References: <20260616182959.2429774-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mem_reserve() wraps memblock_reserve(), and its callers check the return value. xtensa never calls memblock_allow_resize(), so memblock_reserve() either succeeds or panics, never returning an error. Therefore the return value checks are unreachable, so remove them and make mem_reserve() return void. No functional change. Signed-off-by: Sang-Heon Jeon --- arch/xtensa/kernel/setup.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/arch/xtensa/kernel/setup.c b/arch/xtensa/kernel/setup.c index f72e280363be..c7367b81cc36 100644 --- a/arch/xtensa/kernel/setup.c +++ b/arch/xtensa/kernel/setup.c @@ -268,10 +268,10 @@ void __init init_arch(bp_tag_t *bp_start) * Initialize system. Setup memory and reserve regions. */ -static inline int __init_memblock mem_reserve(unsigned long start, - unsigned long end) +static inline void __init_memblock mem_reserve(unsigned long start, + unsigned long end) { - return memblock_reserve(start, end - start); + memblock_reserve(start, end - start); } void __init setup_arch(char **cmdline_p) @@ -290,11 +290,12 @@ void __init setup_arch(char **cmdline_p) /* Reserve some memory regions */ #ifdef CONFIG_BLK_DEV_INITRD - if (initrd_start < initrd_end && - !mem_reserve(__pa(initrd_start), __pa(initrd_end))) + if (initrd_start < initrd_end) { + mem_reserve(__pa(initrd_start), __pa(initrd_end)); initrd_below_start_ok = 1; - else + } else { initrd_start = 0; + } #endif mem_reserve(__pa(_stext), __pa(_end)); -- 2.43.0