From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8F1C47D92F for ; Tue, 16 Jun 2026 18:44:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781635497; cv=none; b=rWsdcQuVu9MhMV98hCsPgthmnlP3BHA9aevGfdU92fZ/uMSDJubFU9vKiWQkl9nUXkhnf2+AmIofSnfV3NjZEKOQK9q7zVKQz7iVDOi32p2IDgVg+D3esu6aUNkFYfD9EksxCUlbyko32yp4BlATZUrFGxLW+RFCMixRlxlbCus= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781635497; c=relaxed/simple; bh=FvoWcbbddD4jgmso8J9hYpa3VkcOXn0vZFfA02SfpCs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SwUcya06JKrLE+64A00TfLpbez7LwDvfcDBxx/B4ANrAuXeH9F8M8LATPMq1D8Z0nVMXLkB7z+H0PT9ntfe/61cENi9R2LjHKvhM55Lmcp1KD4Plj77Mf7SpNVHSkvah/ZHOKtIsC1X4N5oh7rUSjja2OjYFHEZjyq+K1ocH+LI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=axnWD2ar; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="axnWD2ar" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2bf125989f2so36641925ad.3 for ; Tue, 16 Jun 2026 11:44:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781635495; x=1782240295; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mP/ETRxCHugVKBwIg76pmWdXd7L4jCUa7fekho4yCsY=; b=axnWD2arbRHampZuS85ES/ArW+qwS/xATvuukOl0hv4kdDqmKGeXiqYNtoaz/YpbDd FxzqKqntacOzDWxXtJVk1PNLX1LVCYFgP8cOtYTtWgQLENMHjqYEylyAwbWDn8UK+3nY dJZbcJl439eLH7mEU2U8KmAd8h7Iz1xGMIZ23jCKOtryEaTF1HMfk3PCJ5eqCVvBPML2 MWsNYKHn7w/WaXtmtHW0rvujrslenF8C1O+A2rzjTtxcIXDsMSJqkMG5ZE0gKe3ZEDbS iGoYdjJksAJ/9TuqIiXTfCfOz6IaftQvNmuJ5b5oaGph7oFSsEaeQ8F/vAULCalJH9WL L4UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781635495; x=1782240295; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mP/ETRxCHugVKBwIg76pmWdXd7L4jCUa7fekho4yCsY=; b=DudawQyedElELuRbSh29/ctDZ3dGnds3FP/iS3yMkA/ETVSn8Lksun2rZpEqpSf0/q WS8xKFNwJufr5KgThexnljMWUeP0idoat9zF3C0rvSqQlMevQcJwMrA7rEUkcbJz4LFe zGmT9jTyVeAGDbQvlrBZ74ZELlaQ90zAKfMb9obXt9Bcq74WKuwzFIh0oIG5ZwmOLhWa GI0oMvzPXe5dK67tJMCNNtCOTQdMULrB/ohbU90s4cVo2GDXRJdHz/hBD/c3mcGn1Vyw RywbqBGWekNuKIZbX464UccE7giOICMm35oI6AlY0a3LWaKg9nOD9w/pLANrNufkLIc3 +w5A== X-Forwarded-Encrypted: i=1; AFNElJ+6VoO9Afln2a4A9vFPbkUKcYYA4ZsAJYyH9x0oivDCqHO5wPwAutjIZt1z50hNSrBFWvE+M4wm+ddwe3I=@vger.kernel.org X-Gm-Message-State: AOJu0YxcUVOiBRc2WLERrIlD/V+35ZMPMKZxnZKGXNxfw7ATWEI8y+nt nVof4O5o2RClBhc02bpYOlQ/dtdRsmEVI4pnluo8bH5HGE9yVwQH8hdhxN3tEpbY X-Gm-Gg: AfdE7ck6Tf00HTL2Qfj8r+JgfpLa+1i28zlUy/M0f1QoDjejFND3XNmDRgNP02O1SE5 27AslygcES050vmGZgu9hPofWEb+YPvqlejg3vUGIRijzF1QxkUMtLbckBcgW/Ju5WmY9+puItg WmX1X6ARQL1YHwKp8TMmOi34APMiC8+amjMy6daspDK+zA7WyOJDj7qDCAmVpuhOHWeIlFRYXd5 N/7w1GUMBmPZRRUtbLPe1yyW1HtHo0cyB1lkk5S2G9ZdMvVa93NCQQs5CZqEkm5XJD7b6EYrt73 d2hxsTGGMHc67P8Ra2QhuoEYMG+07hAPspKpQ73c+c4Q5QyH13wgoIkMvWsCNnSdqUKMoH6T+XG hoRmalxzwwxnxAec+bcoIY5QxooSfvLLch9OZFQXQMQE0i18HfpBEYeX2w0q8phXEwrwZGk+MIY oxrwL2JYdh/oBB9XtI5CFM7cuC46piHbd5xjdIX4sxFUJembSWIyMzbnTMXRszkqt7CCJG6mbj4 OK/rUrjtwag5D/ig31dP5QUMYfcWQXYgx8e5xRhJOPmFlYbIkjraPZ/yX0uA0rGtYRIRyYwIQ== X-Received: by 2002:a17:902:ce91:b0:2bc:b80f:677e with SMTP id d9443c01a7336-2c6bc23de79mr2256355ad.25.1781635494981; Tue, 16 Jun 2026 11:44:54 -0700 (PDT) Received: from bloom.localdomain (S010680dac2bce256.cg.shawcable.net. [174.0.186.197]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c6b3f65c27sm7128635ad.3.2026.06.16.11.44.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 11:44:54 -0700 (PDT) From: Jack Lee To: dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Jack Lee Subject: [PATCH] Input: xpad - replace symbolic permissions with octal Date: Tue, 16 Jun 2026 11:44:43 -0700 Message-ID: <20260616184443.17342-1-skunkolee@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Symbolic permissions S_IRUGO and S_IWUSR are not preferred. Replace with octal permissions 0444 and 0644 as recommended by checkpatch. Signed-off-by: Jack Lee --- drivers/input/joystick/xpad.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index feb8f368f834..f6e02016a0c0 100644 --- a/drivers/input/joystick/xpad.c +++ b/drivers/input/joystick/xpad.c @@ -74,19 +74,19 @@ #define FLAG_DELAY_INIT BIT(0) static bool dpad_to_buttons; -module_param(dpad_to_buttons, bool, S_IRUGO); +module_param(dpad_to_buttons, bool, 0444); MODULE_PARM_DESC(dpad_to_buttons, "Map D-PAD to buttons rather than axes for unknown pads"); static bool triggers_to_buttons; -module_param(triggers_to_buttons, bool, S_IRUGO); +module_param(triggers_to_buttons, bool, 0444); MODULE_PARM_DESC(triggers_to_buttons, "Map triggers to buttons rather than axes for unknown pads"); static bool sticks_to_null; -module_param(sticks_to_null, bool, S_IRUGO); +module_param(sticks_to_null, bool, 0444); MODULE_PARM_DESC(sticks_to_null, "Do not map sticks at all for unknown pads"); static bool auto_poweroff = true; -module_param(auto_poweroff, bool, S_IWUSR | S_IRUGO); +module_param(auto_poweroff, bool, 0644); MODULE_PARM_DESC(auto_poweroff, "Power off wireless controllers on suspend"); static const struct xpad_device { -- 2.54.0