Re: [PATCH] genirq: Add the entropy pool function to the PPI interrupt handler

[Greg KH <gregkh@linuxfoundation.org>]

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Tue, Jun 16, 2026 at 02:26:18PM +0800, enlin.mu wrote:
> Hi KH
> 
> hardware: raspberrypi 5
> 
> other patch(These two locations impact the entropy pool acceleration.
> comment them out temporarily):
> acer@raspberrypi:linux $ git diff drivers/of/fdt.c
> drivers/char/hw_random/iproc-rng200.c
> diff --git a/drivers/char/hw_random/iproc-rng200.c
> b/drivers/char/hw_random/iproc-rng200.c
> index 33bc28f429f6..af105faa88c6 100644
> --- a/drivers/char/hw_random/iproc-rng200.c
> +++ b/drivers/char/hw_random/iproc-rng200.c
> @@ -296,10 +296,10 @@ static const struct dev_pm_ops iproc_rng200_pm_ops = {
>  };
> 
>  static const struct of_device_id iproc_rng200_of_match[] = {
> -       { .compatible = "brcm,bcm2711-rng200", },
> -       { .compatible = "brcm,bcm7211-rng200", },
> -       { .compatible = "brcm,bcm7278-rng200", },
> -       { .compatible = "brcm,iproc-rng200", },
> +       { .compatible = "brcm,bcm2711-rng2000", },
> +       { .compatible = "brcm,bcm7211-rng2000", },
> +       { .compatible = "brcm,bcm7278-rng2000", },
> +       { .compatible = "brcm,iproc-rng2000", },

What is this change for?


>         {},
>  };
>  MODULE_DEVICE_TABLE(of, iproc_rng200_of_match);
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index 331646d667b9..13308d58785d 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -1100,7 +1100,7 @@ int __init early_init_dt_scan_chosen(char *cmdline)
> 
>         rng_seed = of_get_flat_dt_prop(node, "rng-seed", &l);
>         if (rng_seed && l > 0) {
> -               add_bootloader_randomness(rng_seed, l);
> +               //add_bootloader_randomness(rng_seed, l);

Why did you comment this out?


> 
>                 /* try to clear seed so it won't be found. */
>                 fdt_nop_property(initial_boot_params, node, "rng-seed");
> acer@raspberrypi:linux $
> 
> Before testing:
> acer@raspberrypi:linux $ dmesg | grep rng
> [    3.360898] random: crng init done
> 
> 
> After testing:
> acer@raspberrypi:~ $ dmesg | grep rng
> [    2.808880] random: crng init done

I think people have talked about irq "randomness" lots of time in the
past, you need to provide lots of real documentation about why this time
it is somehow "different".

thanks,

greg k-h