From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D26C71DE4F1 for ; Wed, 17 Jun 2026 23:35:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781739324; cv=none; b=aqaoNyXz3JmU/BxlqAX1gNDFAsQ/OSzdwKjRvPeniLkwwOTyc+X90OaTXPgpko2Bn92kCY6OhkvBzSeLpgWskIIZFoCdFHbF9V8fgT3ZrTS2/btcP/d2Fs0u5k+vjE6vFlbVbzSIhuvE++2XsWAtnZyGsP3K/Ki63JVZLIS5Hso= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781739324; c=relaxed/simple; bh=sxCJ9JaHTFlAf88jTHeT7bHfpfuZdDYM4bC7eUPd658=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=VJpBhG4gXWeluZwTeceW0VTtiXh1nV6L8J+W/yOSaDAKLHJJ8g7zGD84fWvG/clxsOGsrGiwTC9Y/SjN13JFjZLWtujl82bYZ0vouLGYo7uF5K+Q/66MPOfNOv0wVtvDs23tLG3GA6eHB+Ts6vQk8qxJ5WGEth20eKiXYvyqCKM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OlDLAru6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eEFsHLFc; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OlDLAru6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eEFsHLFc" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65HItEQu3593748 for ; Wed, 17 Jun 2026 23:35:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=6WkFCTGJr0q5T3+bKGuph/ E2sDRdxEhdBmqEmxPyINU=; b=OlDLAru6SZveBuA9axIjtY2LenL33ZV6JKxqCo 0PN2QfOqwQQt864ifE28TE8WuzT1nGM0Zge8y0wGLwpe7Tr12QK7aHwDI3exIfLe vupJz4j7yLtK1DiRyRtd0GuFiXyzOCIGY+sccZkDKdu4y1QNgP/i73P3IH2ch3gz snR0XsAIKzxv3ppK+5Or33zUs22yChyldlFPqm57NoUkmi226PSJ6qS3TKzjq2x9 /EW74y+oIglVrg9jdXMEhGDlwlgUEnPjeex8JJsI0LNPhouAMdqK8oyaoqiARr/i i/IESx5v2SKbZOw1L3oiD9ilCtMNQBQ/N05Ij4Vg/ru+hujA== Received: from mail-dl1-f70.google.com (mail-dl1-f70.google.com [74.125.82.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ev19a0xun-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Jun 2026 23:35:20 +0000 (GMT) Received: by mail-dl1-f70.google.com with SMTP id a92af1059eb24-1384427c3efso1492187c88.0 for ; Wed, 17 Jun 2026 16:35:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781739320; x=1782344120; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=6WkFCTGJr0q5T3+bKGuph/E2sDRdxEhdBmqEmxPyINU=; b=eEFsHLFcPefAVFDXODCj7cqaeBm5s6QzvDvhQsFskr9dYWDy3WM8/7iqHl2JWm29l2 gM2gqHo2m9eXD+SOTAGH84tQBxW5y31+F3FMaqJjXl4wk0TDeLyH5uwe80PpJ7RUsGbB Tr+VoCWvTVXDIrhtijzxQzMW2kNVmNWxk6dngZut/VmNL0rutol0CGdyOzBfduxZHV0I CwcJzGkMiR8OgpsnWMTwTJmuGv5z2CisD/fkBxMcv8X0OPyVXvqQwFfj6zQ8e59VDHCQ WmIug/Bo2jUAU64KXnc0In0QuhDI+A7m6Udj/EDCP45M0vrvCT9Z0L9XnQDTm0fSnd5l B/Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781739320; x=1782344120; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6WkFCTGJr0q5T3+bKGuph/E2sDRdxEhdBmqEmxPyINU=; b=SEWLWYMVpbmhcKSrJg0J7EFip5/d6Mf12uZloupG1CAgJrjEasaTsE581fgdplCQ+e ENRldLYXK4IhSf6zSCBbVLrcfUAbJiYZdbdAFfvJsK4HgJ1zVO07FbZnxJgXU64lQ9dc tluh+MOtUOXzQMzcRvzS5wRhVpw1+9TUJU8vYE4jaD7NMUr58aX+s3fNUkI8dDSk0Q0L Q27VLj6AtCtx2KmDyRYpKEvCwwP8sM65IR0MjYKF1P/j6+OKInlrHSeg+e6tUO03FX5T Sr2gN6fx/8UbvMtdoGLbM/BIobX9kw8qFxwRnLarNO+qjQPzPjEpeau8XKQUq2rPGHWS v2RA== X-Forwarded-Encrypted: i=1; AFNElJ+HythCumGuS7UWm2GYJ+JEvH9M3Bykk3CF2SZt4wmJ+diPSZ7v+3h4TlTJ5ESIZLbRsNat4yTBntU4WWU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy88CSzayk/LO3an81dxLaZya+6AL3irTS8IOKGP6qB43I9l4r1 QD2i4qnk7+uvaxPw+hDATiLbWAJn4biFtDkhzPJO3SXhk8dWsksrUdQ+Q3TRpvEkgkgRxmHQKyi pIxwVhKeOiIqih5RcXlDMmQlO0doF71m3AU4q4OEnpMgyZb1sT42eSwmDHu+hGTCT60A= X-Gm-Gg: Acq92OG69tT0g3e3z+MGRn/JayDCXzjh4pbN7F+7iAmzmcZKWg0TtVUvXa7wDhL/dpa wx+PCmndqVVllLIApEmFNttFmv7s8WaF13UvoWj0BInmFZySxb+42+JcPWkBJB2kyjRG9lGrUQ5 7emtZCjTCE49TjYpGpC3b64aCsH4sz5eCM3qAkSj3US1+EOPtyxAo2GDEGHeQN14o0HObu64VcN x6M1JpPy7Xf4FJwEvyMHNX14zD/YED1H853qIIqX7EklN0OhyKrGzi/IZaQSrNCqRiBpnmPeGh4 SFsOtHZgewooVTSr05Xm6Bjkkd3bEQ2/jjcXRJz5Ju92t+XX3yyQVyBV+3k9aRG4NRfHZYLljha /CII3Hhz+dM0aRluezjjZlyWmfs+IlVJ8RIZDFUV5+rXbtlPqXcvI3hXQdwEdlTuLT48KxuFRl8 +F9A== X-Received: by 2002:a05:7023:b06:b0:138:33cc:d87f with SMTP id a92af1059eb24-1398f66af6amr2858152c88.5.1781739319572; Wed, 17 Jun 2026 16:35:19 -0700 (PDT) X-Received: by 2002:a05:7023:b06:b0:138:33cc:d87f with SMTP id a92af1059eb24-1398f66af6amr2858135c88.5.1781739319064; Wed, 17 Jun 2026 16:35:19 -0700 (PDT) Received: from hu-uchalich-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1384b9110d3sm18273923c88.5.2026.06.17.16.35.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 16:35:18 -0700 (PDT) From: Unnathi Chalicheemala Date: Wed, 17 Jun 2026 16:35:00 -0700 Subject: [PATCH v2] firmware: arm_ffa: Fix NULL dereference in ffa_partition_info_get() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260617-ffa_partition_nullptr_fix-v2-1-bc801b4ce34c@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIACMvM2oC/32NQQ6CMBBFr2JmbUlbTElceQ9DSFunMgYotoVoC He3oGs3k7zJ+/8vEDEQRjgfFgg4UyQ/ZJDHA9hWD3dkdMsMkkvFFT8x53Qz6pAoZbMZpq4bU2g cvZhSrqyMkarkBnJ+DJjfe/e1/nKczANt2go3o6WYfHjv47PYvN+OEH92ZsEEQytNha5CUfKLj 7F4Trqzvu+LfKBe1/UD97FqnNsAAAA= X-Change-ID: 20260604-ffa_partition_nullptr_fix-66f37bb2630b To: Sudeep Holla , Jens Wiklander Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@oss.qualcomm.com, Trilok Soni , Satya Durga Srinivasu Prabhala , Unnathi Chalicheemala X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1781739318; l=1895; i=unnathi.chalicheemala@oss.qualcomm.com; s=20240202; h=from:subject:message-id; bh=sxCJ9JaHTFlAf88jTHeT7bHfpfuZdDYM4bC7eUPd658=; b=Wo/uNJjQaEXM7mqbhOxqL7nAfVNSfuVaxC+KNCaSKKVBcN05Atx7t/8GsoFVTvepDq8OM0atQ HNpwpZEnzziAW0OdoNLE6ToQKi6BUslfXVK2hMDJhw+HrSH7MZq1kh5 X-Developer-Key: i=unnathi.chalicheemala@oss.qualcomm.com; a=ed25519; pk=8n+IFmsCDcEIg91sUP/julv9kf7kmyIKT2sR+1yFd4A= X-Authority-Analysis: v=2.4 cv=YbmNIQRf c=1 sm=1 tr=0 ts=6a332f38 cx=c_pps a=SvEPeNj+VMjHSW//kvnxuw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=bC-a23v3AAAA:8 a=EUspDBNiAAAA:8 a=jr3FWET45_D-OIZeFJkA:9 a=QEXdDO2ut3YA:10 a=Kq8ClHjjuc5pcCNDwlU0:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE3MDIyNSBTYWx0ZWRfX63dK79/kDdJN v5jPq4GQX/MIw8AphWRWCTKaJWNhU+NvnsgYSDs1DpMJcasxycr7rePJxS9FP59qDvjY0pB75B8 Q+Aa8GFaKnze9y/p6i3t+GLXTbUe3Jk= X-Proofpoint-GUID: Hx5_oAF_PFmD_LtY-fJLEE-qKWhJjaRp X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE3MDIyNSBTYWx0ZWRfX0SkSl1nuwtiR YcD7LT4dd7JVymiGUnJ2f7wuTFgzYc847WBot6AsT97iIaAV0zdm73jrrVIIbNkCcVa3p4yvYdc gdU5gklXEpOSloigh1Ikrt65xWqhZ2l7l0P13SH4KhnkJL3wTg+9eMJTgegwmLbSsacBEbyxH97 3QrOa4OuZv7YSUK8WWJos8nQt/QKKQST8Ugl/1h1Q0KGKedYd/i3ExuCfa8hhFD/1FtlgZLCjDl 1bJQ/Db5gYBN1Ef1vhsBPaJ4WxxidpO/Jw9XwtNgyTe9zJr1XCrQf4/j2k/2XRR14ndcHVe4nuC STKZjrfAvlNGo7adVqX8OlfYVYH8FKvbk6XupTrghZMH9Ufz29teAuNKdIGKBuoU68Ph5xeDD2x yKK4jeohNDPXVG3XMxV6ypgHkXY/NYPVENqzqoAGimeTGA4ut25wVy2NSIwgej4HiAdrnVoRvAf R9kgpodtv2U/lLaRhsQ== X-Proofpoint-ORIG-GUID: Hx5_oAF_PFmD_LtY-fJLEE-qKWhJjaRp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-17_02,2026-06-17_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 clxscore=1015 impostorscore=0 spamscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606170225 ffa_partition_info_get() passes uuid_str directly to uuid_parse() without a NULL check. When a caller passes NULL, uuid_parse() -> __uuid_parse() -> uuid_is_valid() dereferences the pointer, causing a kernel panic: Unable to handle kernel NULL pointer dereference at virtual address 0000000000000040 pc : uuid_parse+0x40/0xac lr : ffa_partition_info_get+0x1c/0x94 [arm_ffa] Add a NULL guard before uuid_parse() so a NULL argument returns -ENODEV instead of crashing. Callers are expected to always supply a valid partition UUID, so NULL is not a supported input. Fixes: d0c0bce83122 ("firmware: arm_ffa: Setup in-kernel users of FFA partitions") Signed-off-by: Unnathi Chalicheemala --- Changes in v2: - Drop special-casing of NULL/empty string to uuid_null; treat NULL as an error instead - as pointed out by Sudeep in v1. - Simplify to a single NULL guard before uuid_parse() rather than a separate branch - Link to v1: https://patch.msgid.link/20260611-ffa_partition_nullptr_fix-v1-1-ec2b7ef7e130@oss.qualcomm.com --- drivers/firmware/arm_ffa/driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c index b9f17fda7243..4090be782329 100644 --- a/drivers/firmware/arm_ffa/driver.c +++ b/drivers/firmware/arm_ffa/driver.c @@ -1129,7 +1129,7 @@ static int ffa_partition_info_get(const char *uuid_str, uuid_t uuid; struct ffa_partition_info *pbuf; - if (uuid_parse(uuid_str, &uuid)) { + if (!uuid_str || uuid_parse(uuid_str, &uuid)) { pr_err("invalid uuid (%s)\n", uuid_str); return -ENODEV; } --- base-commit: ba3e43a9e601636f5edb54e259a74f96ca3b8fd8 change-id: 20260604-ffa_partition_nullptr_fix-66f37bb2630b Best regards, -- Unnathi Chalicheemala