From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99CBA48165C for ; Wed, 17 Jun 2026 15:50:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781711421; cv=none; b=D48FdmsJH+VOoqAzXj0+Rixsqx2l3/PS0IcrLB5/wdIFi6EMdGBEuO9I1u1RTBe2AaU6IS25e/TV9zwwJVA0CI3UlFbsB2khh6qGA1pvQH0JvvKEO4M6spnNJ1tfNclvysLEit7NpH9TO/KID16pwM2VbeEFWy61lRTM7kjF3zc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781711421; c=relaxed/simple; bh=RtzndF624GK+B1S5N/LG4zxmfgm+M6mFqK4xoHMGFj0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cUjiMgm9w+g1kSG29XAdundM/gBKSRto5F5QMESnABLStHLn0lMUW4t26eQ+nx48E/dpwoTntq9RZnyqMix8X/bZJZN8+UKQcETlGUaKMbe8CMK64SCUq+DaWzjDcbpQsYyW9tKLID4Xys4yWjcfiu0uWfEhJ5QtMjU6uZZGt/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=i+xhhRdA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Kdv4xFJK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="i+xhhRdA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Kdv4xFJK" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65HFfnfG3244836 for ; Wed, 17 Jun 2026 15:50:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= w2vCsXE7toL/jfvcCxsJrt+2J0x/Uao7L2OQT7fWmzQ=; b=i+xhhRdAYPkkQAU9 WG2eCb5VOGbuYaY8USadBosJi2ajcilPeWARonxUWPCJyDmOqt+ktVp/Oz1SmtyK I5j0xwzLA/ZEcp56u0agydX5sD8KAAO1kzo2mojzER/jQ9HsErvCS9EXQCchARVq fZfW7C915E734aD8MplB5bth9BMfHhy9YxhLWNgA1XKQs7LP8poM4ywl3xORYTpr 0FxDEDICkNQPdhdEJjMmi9oud+iCmcHxAqt25+ViggF16AnGtOhkRXZVxaBevzDj vO0zh+QHXLyarTo85HwEHU+ngJmo8xbusnD1nLBMBF5kGLCYy5HlvTGQ4bDcLOeI gdsS7g== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eux2jr57a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Jun 2026 15:50:04 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-6cfd2462acbso6185972137.2 for ; Wed, 17 Jun 2026 08:50:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781711404; x=1782316204; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=w2vCsXE7toL/jfvcCxsJrt+2J0x/Uao7L2OQT7fWmzQ=; b=Kdv4xFJKDurRhl/LaLDPDytbjdavwKW/hmA/8RIGmIocvgueL9s+kQoc4OycUPnETi RKurBRMJZBAC/GKSbu/KV0fsMEFd0mkF/AioS+dcVapBiBb31QvQc3O6CaUWEfnmymeF QMi4WJbtfsqWC08NOQZviz2Ezd9doad7f+mM9LrC0LxkCOhKNsMCxBwA7emFwZCcso8g eFJQIOCjmqVTJvthOHZGJG9Xg2cmf946Jvpj6nhlubjuuw85Z3IyOEbaGCV0wHR34LMo yqyJZUE03Fq/C4u90x4WNGzi7kdIwURVJ4MEVaRmVE6xOmhL8a+AIDD8veNpHuCj4IBr yFCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781711404; x=1782316204; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=w2vCsXE7toL/jfvcCxsJrt+2J0x/Uao7L2OQT7fWmzQ=; b=a187qkhdyzDIO+lfN9wn2saQUC85zfLx4kqw4Z+Ks9tso81gZx4GKKEkfP6lm09N3m NIV8AV6PkaA3bJhe/QXvE+MRbVpU914/YvNn2Xx6227saJKz1wmh92D9G6QT/Y7lpr7O eCl3DEFgOVR6gOouo1Qmly33PCeYOHYaNu91Mb20Og0cPqz5wNNYRKtCqXl05AwY1Mu5 CYYM4SGUj0nC/E+JYBtpTW98Q0Yo3RdNsQqswNSWkByy6vgnUb0+0EkANcHPkrEKSgVF clbFZBnmFK4QbzEviSpHugMagRrYUiL5Hn7ojo+/N1toiQpxxSIHI2LhBJNO4V1y96gx PzIw== X-Forwarded-Encrypted: i=1; AFNElJ9tRbBkow7faatVJRQi90acly821mR3fWlKg5sEPFjtevDcL0Fd0wfvpJb3dxaVNSNV/zxWchbP2B8g9hI=@vger.kernel.org X-Gm-Message-State: AOJu0YzU6j5YvLEnXVx4HmdizT9Z97Or13Z82qas+kibdYaQn/v5lKOB TBrSbvbcMwBmuabOmAmrG65351Fr5iqXlDX+MP9HEp1RsdLABAhmuz1gpVyTNrQQ/EjW3AdG+JN DqQ5KGj/t+VPOn/w7H3FwrDOsdRiWe1dddRIrQ2oHskNcTPK+cAuxTc22cW+iD/6ACcY= X-Gm-Gg: AfdE7cnAhKZs5mLyWLkWPGzwXjYa/29JgPKcIvaSAeDUE/as+2wpNbiXZ6j7HGsztUv K6YYA6SaBz4MGE+eO9B/0NVQl8Z0QKHkt2vF/Za941/7ziu4oBNPN0Wn1iqxmqv2oD+/yxpwhav gvJpur/QtL2CQebDYOEI76cUiBGY/kYAGuA+v4mgYx4XEjJKmgJZi5MKSp52i0qiQp7SIttr7tZ vzI0jB1ZhXi3evYoBhgyRN1rorRRqZqaQAufNi1+V3fCuIeY5EFsKEg04VJj08YPkiNyJN4O3m8 D6X1KR+dq/VNEVo2ywQclZR7rcqOXQqlaiL8l04St/gH+5wb3/1e9Ug0ZINQrgQ3LAy6MZu1qeH gL+y/4bvhRJTvUIRP82wOadsW9qyN1O5fOFVa6CNn X-Received: by 2002:a05:6102:5107:b0:6da:1341:1147 with SMTP id ada2fe7eead31-7245d3134cdmr2866753137.1.1781711403441; Wed, 17 Jun 2026 08:50:03 -0700 (PDT) X-Received: by 2002:a05:6102:5107:b0:6da:1341:1147 with SMTP id ada2fe7eead31-7245d3134cdmr2866724137.1.1781711403050; Wed, 17 Jun 2026 08:50:03 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:c856:25e5:e249:5e0f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4922fa8b423sm168913195e9.11.2026.06.17.08.50.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 08:50:02 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 17 Jun 2026 17:49:34 +0200 Subject: [PATCH v3 5/8] crypto: qce - Use a fallback for AES-CTR with a partial final block Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260617-qce-fix-self-tests-v3-5-ecc2b4dedcfd@oss.qualcomm.com> References: <20260617-qce-fix-self-tests-v3-0-ecc2b4dedcfd@oss.qualcomm.com> In-Reply-To: <20260617-qce-fix-self-tests-v3-0-ecc2b4dedcfd@oss.qualcomm.com> To: Thara Gopinath , Herbert Xu , "David S. Miller" , Stanimir Varbanov , Eneas U de Queiroz , Kuldeep Singh , Eric Biggers Cc: linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, brgl@kernel.org, Bartosz Golaszewski , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1705; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=RtzndF624GK+B1S5N/LG4zxmfgm+M6mFqK4xoHMGFj0=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqMsIaPVBmp005T8Z6Gxz9EUFgfWYYjDjjnKYdd QEoLL7hEcmJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCajLCGgAKCRAFnS7L/zaE w+dHD/4iKa04kAs924QQRpb1Ju6pOTQcRxikg3+yXMkHl/VlM4I+k0OJiAc5LHjHkXKPFLR1fDA K8rBBZGXX9ygIFAdXpT5gZgAtlGKF6xOpL1+VuGX1bSluY9Oyr99LaWemhQR18Wrtv5weV4jkzH ikogG021RyFeVR0ddfvZq7haTKiRVn1gmXizUK1cznSA9qC+CRt2gjn0hNILgiOnsSLFNX0y3a4 1lEzeaZGrlxnQ7KY9XgFG1tMqBbYQqPew+CWvN47XRS9oNh688IqwmVkRTUnYzatxUaRYTBrFSE 9Mt3ankwBv9VvE7ucR3oVMBUaYxmTixRSnglvONpfMThBCDPOlVI0irM0nwrQllrJbJwUJlEx+c pXJDum6E5SB+KCYF1TxHqo4cU+tSG7y2uFgJGHgCY9y2ZcfoYgzuZtdbTxtmmktqEDxZ1YRfuIE lxCZiIWdMph9R0B0RpYxnRyW0+8kC6g/NExx7X8qyhQIgt8RbuAX6T40siHbrEy524M2f7mvKnT wYyxoyaB71HpybLvV28W/IPA/b0UZ+HlthEN/UNr6PafkJb3fqGuy94t4LgVXcy1xQrx9O7D3GY uPfDEbfoEz0eYMzI6KAO288JefLr9K2qcSMgivegaRu/51rrT8jjbBY/rH+gFiho7NM+EUlSB5I hAJw/DpBDbQbsug== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE3MDE1MSBTYWx0ZWRfX9gx6KljrmHeS S/OfOFEnpJpNSM1Kjhp1vUAwkLuyE74BCI9Uw+JOpNjoZ9eYcpcIipLqTXWODaJ9bskxHgmMtQD DcQq0noyK7afGJFO787HQtmqjS21QpsHH2S8Rwm44G9mn3ptU5Y9BxuXA0kIsw7oWjdx/v8GjzE eoFTEcZWwCAB5vrsdtzdIJF5/QIzjwqad2j5UdymfNZy31cwSh81Jdwy/Pm50w3VanNTofXlq97 ITer/peQhbV4vV/GPl4H2fHSWk2SURWFOZKUYxELtRBk2IilPj6INRNWLX74KM5XGfRSOo73CYY pzx327e4AE1OT4ITp5lQiIgQ0PpU62F5rfNaVASUB3gLnbI+TaOuXeak8ifYEiFHjsvhDcQgwIo e+W74IR6Evu5q0kO1Kf/IOk+BdsHnbgAlTthf1qP0bc2r2gvPUVaIxZHr5Bgxc7xDp1vXOyhCjx 3qiwN+1ceFPVZaq0QTQ== X-Authority-Analysis: v=2.4 cv=Fsg1OWrq c=1 sm=1 tr=0 ts=6a32c22c cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=vUpbTSJP45I4i0_vGVUA:9 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-ORIG-GUID: XBcMIh9DXyJR11ta3jbVVzG8M2u7WMBs X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE3MDE1MSBTYWx0ZWRfX2P5hyFTZ8Eff 2nSTGqiXQ174Yu+CenAKSZiA0VH/suB/9nYdsoGF2DoUxJxKYNKzIqn0i0Yvf+fDc2ypYmlF2yZ jiUIgpQTM+CHrDptq5OKys++g6Cqtvo= X-Proofpoint-GUID: XBcMIh9DXyJR11ta3jbVVzG8M2u7WMBs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-17_02,2026-06-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 suspectscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606170151 ctr(aes) is registered with a block size of 1, so the crypto API hands the driver requests whose length is not a multiple of the AES block size. The crypto engine, however, stalls waiting for a full block of input in that case, leaving the operation incomplete and failing the request (and the crypto self-tests) with a hardware operation error. Route AES-CTR requests with a partial final block to the software fallback, which already handles the other cases the engine cannot. Cc: stable@vger.kernel.org Fixes: bb5c863b3d3c ("crypto: qce - fix ctr-aes-qce block, chunk sizes") Signed-off-by: Bartosz Golaszewski --- drivers/crypto/qce/skcipher.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/crypto/qce/skcipher.c b/drivers/crypto/qce/skcipher.c index ace64a651f56ff478bb4966d74c9e762ade37ba3..118a6878a76b1e86534f60e5d2058b99a689302e 100644 --- a/drivers/crypto/qce/skcipher.c +++ b/drivers/crypto/qce/skcipher.c @@ -260,9 +260,12 @@ static int qce_skcipher_crypt(struct skcipher_request *req, int encrypt) * AES-XTS request with len > QCE_SECTOR_SIZE and * is not a multiple of it.(Revisit this condition to check if it is * needed in all versions of CE) + * AES-CTR with a partial final block (the CE stalls waiting for a full + * block of input). */ if (IS_AES(rctx->flags) && ((keylen != AES_KEYSIZE_128 && keylen != AES_KEYSIZE_256) || + (IS_CTR(rctx->flags) && !IS_ALIGNED(req->cryptlen, AES_BLOCK_SIZE)) || (IS_XTS(rctx->flags) && ((req->cryptlen <= aes_sw_max_len) || (req->cryptlen > QCE_SECTOR_SIZE && req->cryptlen % QCE_SECTOR_SIZE))))) { -- 2.47.3