From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 413B717BCA; Wed, 17 Jun 2026 08:32:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781685145; cv=none; b=fpf7a34F9jftJj0yvRBQoLxXbBNyMIj2OTibd2kt7Q0haQLJLSpTyJN4l9xAwiVqtSHcy5kSgbgF69y678KuBu2H9s9aL94QfX7V6AlRh6j9WMhN16Lm3X1/22gvktedzAz/cb+ExIeIKRUudUFEUyjp/qOWTcnDpsuN6OtYA5o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781685145; c=relaxed/simple; bh=Uk/b7YYDhvgsGviOg3h2t2SDHyXuI+Sg+OG/3Q4uIb4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BXmuYiXIsIVOCkijnEkH6kPDW9fv0fsQTzlMtx9ctico5CR9lt4oijoE+V4dX76BLZHa81stSOLzZ5w4lseitPk9ENdFFqVfnSauoV/K+jARB92Uy9poM6iQvG5N6Z67fJ1R8gDvLz3mUTmlYysYubDkhU0cfNzAhs0qO93QljE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iWhi8ln4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iWhi8ln4" Received: by smtp.kernel.org (Postfix) with ESMTPS id DCE74C4AF0E; Wed, 17 Jun 2026 08:32:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1781685144; bh=Uk/b7YYDhvgsGviOg3h2t2SDHyXuI+Sg+OG/3Q4uIb4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=iWhi8ln4YkX3BfbRR4MQrQCIFd9ZmSwuSNISfI9CjoJK0GAPCdgmot+TYgFJ9WakM re/fuOxqKeCkOFbWYTzjZmZFM5tAkNZZ5Rw/x9DiU9CxDuh511YWH/BuePBlfVvWUY vePeUnkCBNj4yqYeTfej5IiOf6UGPteP2RAGfqK7Q4o2UOxyByR1JdTM6ytl3hz4pS UVJ+XBV0xxlq3FBxICqDiCBtxpAFFPxLUFMpE6lR2/voOX+6gKZNDalKsp3OyFzBtv z1kU/b5eH0V6by5b0KVxtnM+WD/ve8yNhqKuUXvTI7GMrzH6Xeaz5hzs1bdYNqYg6k 0w1820nHKsuhg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6BE9CD98E4; Wed, 17 Jun 2026 08:32:24 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Wed, 17 Jun 2026 10:32:19 +0200 Subject: [PATCH v9 1/9] media: qcom: camss: csiphy-3ph: Fix lane mask calculation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260617-qcom-cphy-v9-1-83da8a8e4e44@ixit.cz> References: <20260617-qcom-cphy-v9-0-83da8a8e4e44@ixit.cz> In-Reply-To: <20260617-qcom-cphy-v9-0-83da8a8e4e44@ixit.cz> To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , Luca Weiss , Petr Hodina , "Dr. Git" , Cory Keitz , Loic Poulain , Hans Verkuil , Nihal Kumar Gupta Cc: Frank Li , Konrad Dybcio , Kieran Bingham , Sakari Ailus , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1187; i=david@ixit.cz; h=from:subject:message-id; bh=4gZLnNPEAXXeOriBAOpQ0RLijJCSPBaruO2JK2La25Y=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBqMluVDaYt23kX5sYernqkW2OsBYpSt53wLLfQS FNNVrQ8LuuJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCajJblQAKCRBgAj/E00kg cpeWEACHOPgSurC7v8KGNNYxgItBKG1rKNOXQxucd90zRFVR0vaZwNc+haE3e8IfalVBeGQR2Kn jzcJ/Op5+YbTkug+N+3vX1bCHkhURxFA2MO5rCAYgDR9qQS73NUn3HOJFYew5wzADDOmmRDnQHl SUnhn64zwXaXRSp3D2YRZEi3ALlINLmNzgzR3kxAoNsGeuueVl9CPjqqHqGVZd/PEf/R4r5goBO R1toPw9/f/bvvIOvZW7d1byETo+ckbFAMqG0d71QdSICNmv5E/WIBk3blWzbgtuye3K28KZDjd/ dLEtRacIj/N2QcHFB8g3tVacsaKYKGVKfR6vEuCeOGGK1xzSTbWiU6oUBlTLv5QTSwntc4PWFBe 5KX9vmCjM1hxu4frm0Q3bWzEmrR7V8a5vUh2hYUWJI81uXSY6ef1FMRNULaIZFr+miBP8+TIwAC g79GkR/Cpm73yJprj+QdwLeiInfctf8G5DHJUKnl9C88sPK+U8ddyfVmVQ0Q/W5gD6pvEYBpPUX b77FLtIe5k6cFYKfWKeFok1JyNHR/DYK7/kYETYk+82nFf5L2raUDT9dLqVFAPOBN0f5s4UdSDO OpnfGzlsmWs9OdNZSQA4fm3QfdbE10NGUiLbEsoEoTLBAF0rBCi4+xSqw8RKL2Iony8PNw3TKMt TOx0HDNhjUkdD4w== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg The lane mask must be multiplied by 2, but this was accidentally omitted. Reviewed-by: Vladimir Zapolskiy Suggested-by: Nihal Kumar Gupta Signed-off-by: David Heidelberg --- drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c index dac8d2ecf7995..7c8c0e41bc62f 100644 --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c @@ -1114,17 +1114,17 @@ static void csiphy_gen2_config_lanes(struct csiphy_device *csiphy, static u8 csiphy_get_lane_mask(struct csiphy_lanes_cfg *lane_cfg) { u8 lane_mask; int i; lane_mask = CSIPHY_3PH_CMN_CSI_COMMON_CTRL5_CLK_ENABLE; for (i = 0; i < lane_cfg->num_data; i++) - lane_mask |= 1 << lane_cfg->data[i].pos; + lane_mask |= BIT(lane_cfg->data[i].pos * 2); return lane_mask; } static bool csiphy_is_gen2(u32 version) { bool ret = false; -- 2.53.0