From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBCC03101A2 for ; Wed, 17 Jun 2026 02:19:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781662777; cv=none; b=q8hKkbLmpaDKTQED99KpddX9BwrUpS4ed4PtEr9R6tLxdelbBKVvRZ6tnkcQRvpQ2IDLuHa9I8cVvpFwHPC0BB8k0JEl1VECT6tG/Hlw0G8cW//zTKT8J9SPiWcwFfDkz8YmeJx6jqARdDpDVbsSJPPWOvSx44GeYpv33Xhekt0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781662777; c=relaxed/simple; bh=ct6Fgwve38x10N7LCLc2sJ09iyZssHjLWplvN3j1Cfs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KPpfDNPbGRloYUDnl2PtL1uD0qY676e7jFjOU4z6kO6LUD0061z8tjJPO7kPQYhqG0XhLNYu9p7OJRRd+gYBnYUM2TJMdqAvcG+ItP2ss6v5uRg9nU0AyqgwNtyK3EJL6ygPSrCqQF/aL/mehxWCKZJ0xrpISEzGo1aBgpUMPd0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mQ1/YRmN; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mQ1/YRmN" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-915671abde5so595196985a.3 for ; Tue, 16 Jun 2026 19:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781662775; x=1782267575; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U3LnPj4hsy7t9yGnUJKMptAoaBCn6LSom4+XC5E/nvU=; b=mQ1/YRmNOn0y8llK/LvmC3PZ0vypXewOuB6cAKiKHXtHO2AiyhCydsxUlIYSYtof3W SxItvnIuLTToykSozC8jSs6iAT1e8VmYrEmBMa/pICDe3mju5qN9UG3QNAy2oIurFKz3 CyM4EA9rkWc0CQFtDBz5ZpcyGIB6+G8TZJRRFnMFopN9TggIj1HxAg1m0FJARHliS8Gc L/lBqT4suxODBKN7Q4OJ/Phx+IT+0hOAPeI2QFFxbHEota8qZYEjLqSW0oXrJrF3jmHq 9TB4lxImqi2RNwzGDjVzPu7+G5aw0kip0Ef4SEzQNt8rJx7XlVK+hMN+FYpc3SJEeh8S HeSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781662775; x=1782267575; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=U3LnPj4hsy7t9yGnUJKMptAoaBCn6LSom4+XC5E/nvU=; b=ewq1DfS+I/ujpHSUPRcE5DI4YcZkTuD2s4ix6wPcYCJH8kc+i69LkkFi0iHuTldrvt /+OdGiy3wYU+L5CP9KyFOe8MQKaBdizj8k30bCidi/9zzdL1DR3d3CkKOWldvsWQvicG 5wI0L+r/9mM3CCqIisOkIhcf7bKnhmkpi3gD8KzVmhs98Ubxb/B0HaJVjxkJ/oNOT9o+ 1Eqak0GpclKOYZhGvnGI/hcm9spfy04TbD3cTYIWPRDXIMA02G0HrTwrY0S5q46Lq3VM zDrmus2BWH+j/3uLKAIJ0RkebAomMp9G8bt/dbMwVmCOK+VGB5g86Hpi6UaOSNmpe2ca azkg== X-Forwarded-Encrypted: i=1; AFNElJ9+znnX1ZubG40+ZGjKCv2hyIDIC9UyvdfyVchUKHehR0li9mfvqj/K4Jb/kQ08hiFmQEVCOtQhLLKIORA=@vger.kernel.org X-Gm-Message-State: AOJu0YznOTANpazxCtoC07afCqvz20e5Mn2efJ6nPDdjSsegbd0oLUZa nQd6kYLr1lJJ3FyS1AU+AbR4R6X+mFGAXD6YWbgFChgd+LAFDo9nNPZs X-Gm-Gg: Acq92OHgYVkD0j56AIiYCqktponLmzXkdhlAt1ggJKxBGNW5V8VA3ADAGHbeCsQ/qiQ lOJoYR37CFwZdaus7mrSetWP3DLvPcLz8GIiq46X2U/UfQdsUDVzGy6V7zE5feorfR3JeyTlGJ8 iJJB+LRIMKvCjVNhyyrge0MZUrkLzw9LFw40EQaLZY9D31GSHLKqLjQcc2E5Ya1y3JeSj4BNTW2 J27Q2MRwjzLVCB4l+8XdOkRiU7OHXm9d4KEJXkdahTESC9RH9o1hxyckS5LuA7B28flk62yYZME K7Yfmu2YyqZzkkYaCceMt+b8Bp8LyfItRDAgsqyZIrPGQuQgV3lOfx9z+0p0049KHEglj17FBao iRwaMMj6Z3RSsRZgp/jEyEFTWvyZP+82HGPaf4as5CvXz9eK8EVPcQHkhXM5TEtdx8hw8HmKXol USyS+AZEZMvHyK9ut+/qacZbcgu+pfZlzUtQuoN9LM+m3o0/IhOl+rHbVV+41Odov8Q6QeS8i5x gbBWB81nPFypODEab2OysVAZCmTs1Bp X-Received: by 2002:a05:620a:7084:b0:915:eec4:1ec5 with SMTP id af79cd13be357-91d8e49c839mr409744485a.51.1781662774717; Tue, 16 Jun 2026 19:19:34 -0700 (PDT) Received: from server0.tail6e7dd.ts.net (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9161a006e35sm1657646285a.28.2026.06.16.19.19.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 19:19:34 -0700 (PDT) From: Michael Bommarito To: Hans Verkuil , Mauro Carvalho Chehab , Sakari Ailus , Nicolas Dufresne Cc: Laurent Pinchart , Benjamin Gaignard , Detlev Casanova , Ezequiel Garcia , Yunfei Dong , Jonas Karlman , Heiko Stuebner , Kees Cook , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 5/9] media: verisilicon: hantro: bound G2 HEVC tile loop to the buffer capacity Date: Tue, 16 Jun 2026 22:19:02 -0400 Message-ID: <20260617021906.2746743-6-michael.bommarito@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260617021906.2746743-1-michael.bommarito@gmail.com> References: <20260617021906.2746743-1-michael.bommarito@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit prepare_tile_info_buffer() writes one entry per tile into the tile_sizes DMA buffer, sized for a grid equal to the PPS uAPI array capacity. Use the bounded v4l2_hevc_pps_num_tile_columns() / v4l2_hevc_pps_num_tile_rows() helpers so the loops stay inside the buffer. Fixes: cb5dd5a0fa51 ("media: hantro: Introduce G2/HEVC decoder") Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Michael Bommarito --- drivers/media/platform/verisilicon/hantro_g2_hevc_dec.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/verisilicon/hantro_g2_hevc_dec.c b/drivers/media/platform/verisilicon/hantro_g2_hevc_dec.c index e8c2e83379def..e7a7c7a42467a 100644 --- a/drivers/media/platform/verisilicon/hantro_g2_hevc_dec.c +++ b/drivers/media/platform/verisilicon/hantro_g2_hevc_dec.c @@ -5,6 +5,8 @@ * Copyright (C) 2020 Safran Passenger Innovations LLC */ +#include + #include "hantro_hw.h" #include "hantro_g2_regs.h" @@ -15,8 +17,8 @@ static void prepare_tile_info_buffer(struct hantro_ctx *ctx) const struct v4l2_ctrl_hevc_pps *pps = ctrls->pps; const struct v4l2_ctrl_hevc_sps *sps = ctrls->sps; u16 *p = (u16 *)((u8 *)ctx->hevc_dec.tile_sizes.cpu); - unsigned int num_tile_rows = pps->num_tile_rows_minus1 + 1; - unsigned int num_tile_cols = pps->num_tile_columns_minus1 + 1; + unsigned int num_tile_rows = v4l2_hevc_pps_num_tile_rows(pps); + unsigned int num_tile_cols = v4l2_hevc_pps_num_tile_columns(pps); unsigned int pic_width_in_ctbs, pic_height_in_ctbs; unsigned int max_log2_ctb_size, ctb_size; bool tiles_enabled, uniform_spacing; -- 2.53.0