From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012062.outbound.protection.outlook.com [40.107.209.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E5E93AFD01; Wed, 17 Jun 2026 06:32:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.62 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781677983; cv=fail; b=dat+xOTN8HNthVBYSD9WtfuYuHPzkOWBFdTARerCHWLpYnilhgLgnThk1ZKvhg7Qwq6ECvZwUJEhZ8CyCJd4lzaDWCv9AaNNN5yOuElYcGFsqS9CKTu4drSBAs1NB/F9RryEmCrfWIuhvcu+sB/+Nr0BlqtGwFmcvWWyix92vac= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781677983; c=relaxed/simple; bh=YMnBS71PHgVNei00I9EVtd/pf8IgiQ+q6nuoxoj96yA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=j8IwRzTxPoh0n0Xe39XjZQi6NDP/XqHzA+Dij9lY2RT2q08nork33OB8rkVsX82WWssCvN1s7xiqSqNtEgwGhPVoEoMUhU08h20ed10g7ib27sYYF+CUoR6RnBfULZC13japlwruMFzvh13SYHz2iX8uvAQzCBJvQZzGDAvuyTY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=IqHFIXjx; arc=fail smtp.client-ip=40.107.209.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="IqHFIXjx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lSDklQayoHgL3wyYUonV1wV4xhJEbGHpVJYPO0IGBUZURBJf8T233+q87TOCjpERb+uC+L+DvmbYop4Fe1dIbES4TOF3xdRkAY8yqsWIWG+82EhdEu90HP99yuy1roKxg3IxRceSyOYu506X/OwRT5xT7jYplZrOAXXhgGMdKi5UsLjcR+p45GiowsBGTC0IntHOb3lKMAaUPqDeT+Cfr33WTfovUTirVV4JH8e6+6o5b88SyUoDOjNMooGt9be6N8F+ld49i4DHxozNU35QuitqEw13lwVYYN25j+ce8cxJGGAunMEkIy6E7efRJabkT/MqI2nZyL8LxgkHfJK6Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UGGBPPRhY1snyy4yZVxdwlR8KQg5bbtxtEJBU6q8v6s=; b=XCqUVwMrgdqVYodzOBYfd2E04GBeUlBomnzjuiH6dNYq5NWwNDxS4wrwpncIoe3NPyp9SbdhAFHIQO3pKuZdZfQSseuZr2HjuGME/1V34yvMhuHERLpmiUnudxkyc8M5QgIgcXJ6MVGTIhsv2mFifZ0gFiWErHYrJ1nQUQImjre38OHIo2zBUv9LHDZiDBWgAyYqze52IBR6LL84xLSDIMLpcoC+SfrzmYUEjt4DB/V7KqSCjZ7Qkh+oAf1fTlidROgb9/iS+r9DL3wjo4CASgl2/8JwvggpYYSkhc4rL1XK8nV3yVBx6dpqRK+1m2idOD3lGaV0V+ltwKzu64kpDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UGGBPPRhY1snyy4yZVxdwlR8KQg5bbtxtEJBU6q8v6s=; b=IqHFIXjxuRIdUXgN3NICwXQdJgPwRkQt08+ORg2Losox8VVv7TydtgKbDZNw+sxvRt0y9JMLOplf7uOuowTiTaTPvFXfKUV2BAJA+hsfPR2hWL+gBK8EMBXCUQXq4JxSUZX9FoOWmbtQN4GJti0/lnjPxD/alQA7GjyyTtXb59kSVgePQvW0OEtMUdQ/IPz/w+Of2zn/VNUpuzOXFIQtcEHgzxfXUfvwlR2sgIXuQZqxtrFwJB29XMgGqetTKr8GcaC/aGB/+9V6YmnrzmRPApoIe820/yANuy2r6z3d9YL8hkZ6SnSbp0b60n8gxmEVH4MzSAOJX+VaC+uWdD4xmQ== Received: from CY8PR10CA0028.namprd10.prod.outlook.com (2603:10b6:930:4b::18) by MN2PR12MB4063.namprd12.prod.outlook.com (2603:10b6:208:1dc::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.113.18; Wed, 17 Jun 2026 06:32:51 +0000 Received: from CY4PEPF0000E9D2.namprd03.prod.outlook.com (2603:10b6:930:4b:cafe::5d) by CY8PR10CA0028.outlook.office365.com (2603:10b6:930:4b::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.139.11 via Frontend Transport; Wed, 17 Jun 2026 06:32:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000E9D2.mail.protection.outlook.com (10.167.241.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.8 via Frontend Transport; Wed, 17 Jun 2026 06:32:50 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 16 Jun 2026 23:32:34 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 16 Jun 2026 23:32:33 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Tue, 16 Jun 2026 23:32:28 -0700 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Tariq Toukan , "Mark Bloch" , Leon Romanovsky , Shay Drory , Or Har-Toov , Edward Srouji , Simon Horman , Maher Sanalla , Patrisious Haddad , Parav Pandit , Gerd Bayer , Kees Cook , Moshe Shemesh , Rongwei Liu , Jacob Keller , , , , Gal Pressman Subject: [PATCH net 2/3] net/mlx5: LAG, MPESW, Fix missing complete() on devcom error Date: Wed, 17 Jun 2026 09:32:03 +0300 Message-ID: <20260617063204.547427-3-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260617063204.547427-1-tariqt@nvidia.com> References: <20260617063204.547427-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D2:EE_|MN2PR12MB4063:EE_ X-MS-Office365-Filtering-Correlation-Id: 9096805f-e3be-4eef-f166-08decc3a4132 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|7416014|376014|23010399003|82310400026|1800799024|11063799006|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: MD7sPBxFl4SI2yy7xhzi8DglSCTUy0WGF7FFjVqanF4qjPSOhRqqURuQXF7XctDZonAW/ADQ/xS3gtDrOgz8wyrzxYO7vU2d6pIjmzsuqfa/0CBRTlrvZOSR0Y89zpeZzTzflWIPaWoyqHvmr02zlq0dQvNrRSH80W94MPhejI/gs+LFsF68EZLJXuZXmfvbs9mRuoJ+oC1XiFXc/nKk2bdDxBIR6v7OG5T+putjyUeoFxF/XftGECHixpGiWbxZYu3et27RiN7Sqzw3Lc1vTnsHtXZ+UCYFEQ5FFRO0KXoAZQYe8/GqWkEgyiLb6JthtE5qU/hahlVicIhIFG1WxG/XQFVDHbj8DNdU/eXrPsYQfM1HwLYEYS24c0W+UWSVbUzUQaOOUFJLWLpjj/gmJXXD4GKudPx3DHNzHpekW0FHYi7L5+QtcqiowOKB760Ow/HqgjoUzrhyw82ASDTzzX02gRCiyS09W3rBseQ/8I8OymbArOrj0M8XXpokmE+9nqEzimOxgcU1/RoZppCLl3QFIYfzAIQCzYz2801lUqWYwlWuuFGrEI9wNjZ60yXWrsJOGrdsAMaFZ6L5pnrjPrJdYrx46a5st0kxlKr7b/OYTZIXgavtj4y/sYfPW4QrLhEUxZamXhCo6hP48feVj1qRPXhwyYC+5dumsOABg1BV6ylQpnevxDLXY3d7mUwjAfwBnsAslj/YsNQgO6uoX+Ws2vZ+D8Xr6X8OaOzxJmw= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(36860700016)(7416014)(376014)(23010399003)(82310400026)(1800799024)(11063799006)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: QLmUCYDeoxZxSFoOw/nrLJLFccH2yhIk7FNoUPM2NDnwfGRDiDIgc+wWsyiKV6r7Tk2871kHTrKXTBKpBEAlP7X+pw6syTfPy+ubEUXfq3lWcpjEBgIC/2PeOuLX6RgByMG2/UF822rTu0FqcEZ4ElxJ7fYup3gDfCDQstH+CykSn1F7EQzFenPMSLjqrVkCRLKv0WZZ+iUMD3mMUOmEqy0vIqYeTfV9OIePrBs4IsND33mKF3eT48inNEMQNaur3jSuG7jTbLtknVSp8g87aw/n9DcR/tz1vnlmgKm9OygG05U9wIgNxcLd2KhDoA0BUBxVFotDCigycjO9Jgg1miKM1nnLJAJxxm2hEFUMiH9bMaIQ2qYSPFlKFUu7xB7q3nD+G4v/lbtBiytE1VePm1vP2D9sH91B2Zuu7M3zSX4bMpq8WCZHQUzFciVPVJUf X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2026 06:32:50.5540 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9096805f-e3be-4eef-f166-08decc3a4132 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D2.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4063 From: Shay Drory mlx5_mpesw_work() returned without calling complete() when mlx5_lag_get_devcom_comp() returned NULL. A caller that queued the work and waited on mpesww->comp would block indefinitely. Funnel the early-return path through a new "complete" label so the waiter is always woken. Fixes: b430c1b4f63b ("net/mlx5: Replace global mlx5_intf_lock with HCA devcom component lock") Signed-off-by: Shay Drory Reviewed-by: Mark Bloch Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/lag/mpesw.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/mpesw.c b/drivers/net/ethernet/mellanox/mlx5/core/lag/mpesw.c index 5eea12a6887a..db506ab4fa96 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/mpesw.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/mpesw.c @@ -140,8 +140,10 @@ static void mlx5_mpesw_work(struct work_struct *work) struct mlx5_lag *ldev = mpesww->lag; devcom = mlx5_lag_get_devcom_comp(ldev); - if (!devcom) - return; + if (!devcom) { + mpesww->result = -ENODEV; + goto complete; + } mlx5_devcom_comp_lock(devcom); mutex_lock(&ldev->lock); @@ -157,6 +159,7 @@ static void mlx5_mpesw_work(struct work_struct *work) unlock: mutex_unlock(&ldev->lock); mlx5_devcom_comp_unlock(devcom); +complete: complete(&mpesww->comp); } -- 2.44.0