From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8DEF3CF1FA for ; Wed, 17 Jun 2026 08:00:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781683259; cv=none; b=OJt/eHg2IbS6+gIRd/rBnzp4O5/asSpWM09lK0HJtkwAUCWp/2xbq7VjEVLyK09qZVcZLgP0ZLCzrpwu4+DHZdBPv1qpVqqYxRojiurjK85It20qqo54wK5ejtCdWTjjTHOT2vLeSg6+mMct/0kHY5AsIcO8Qego+g4iqH9MEZQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781683259; c=relaxed/simple; bh=EErEa+xTvRrMlTfCICTBeucwWtahnLN9Dg/ExT+D1y8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ShxOd/JLodNz0HcxtbnhnfdT0if3MGf2sAHhFmHBq2jPfvDE/qdkIOEddZtibkCPmOW9W+xrCY8sLCYLtw4HUBjlYaNKXg5rVgfyV9eBAAQ4ccF2O5QjtQV7zeDXdI0APf7RQezpvJxfmknx26ABKb4nKnvHSucX8G5MaxHro7s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UQK9yjFt; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UQK9yjFt" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-bf046d4da1fso516389766b.3 for ; Wed, 17 Jun 2026 01:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781683251; x=1782288051; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0zcYkBqsgtm7crDvyj+FVJGVI8rwwbt6ayEuo6Ql52s=; b=UQK9yjFt9W/l/gnodv7PROtIDTvHGJKgOXovy2Cy15yiDA6YO2lmeVtIL5lGz2h26j YkGPTwFA9NeYqU5TWWS/8iTmZ4WbCSWWTeEvYBAYRG2OPh7yuvtEJ7A7vLobt+LoDttI 6MQbCmriupTGKgkRvOkvCz2DF0K/SKHRCmaL1WjkKUj1kklGXeS6SQUys5S0/ZUS0Nou kbFpIHQsdMiV6qfUitY9/cBvIVLVRKnNWLr6mCjYa4sTDcjT7f8Rk8G+zhb1P0YlqbSD peIct/+llBU1722YeW+RecV7siZ25vV0kaV3nRWXrg8NQGC7wom+cow1IYLOhAPNNQ9V frLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781683251; x=1782288051; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0zcYkBqsgtm7crDvyj+FVJGVI8rwwbt6ayEuo6Ql52s=; b=MP6+SH3MMPg8YdcmnRWGfUWkQZeXLYpBnibPzk/PUhAALS694ZYxr9mN/O4yeV5Uz0 6ibvxWRSc0Lln7jJM5Xb+6hKDE7mY2YBhu4RCDaawKFHKwVt4kptNalY1H4kh1ri5J4s eZZcJziMgLkNZlJ7QRqRtE9DatABHudw3wsj1uDNCP7CGDwyHNHKzS1m68TIP1dZXdBR qMffTtyAYTAQdkdsRLwIZfzmcG8GDq4fVAfMTIkNjsY6QZq4z1IpD9YfrWA+0UhHUtrJ GuUcDoaubxcVtdGaKabB2Q2Efdf9L1LMINTich+Ufj6alFYTjNE0jtBoc8TJQO34Dmo2 vzcA== X-Forwarded-Encrypted: i=1; AFNElJ90PdhEqRtG77gdDshWV2WDl0md8fnSvH3Msj82EMzC0PBwKhdGp+ZG89/Bmf5MvfYWYMuBNLPvCRCCYRw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9CH4ZzRG7Vjw0VDUn21bhfTILE7GKevW6BkhnVf/GXZUMHxVS qsSdCrIMkzaU28vWzTjvXkMyaD9AONWR88IIfqaCRKWKPtnDzXHtJPhy X-Gm-Gg: Acq92OGj4RlTo9MlK3LB9LpaoShJNHYBwunw86hi7ElT6eqApfNM5ddr17NAep5rrSA 5SumP4aCn+iGzVvo6cBQH0I+kDhr+r9aWTruNQ9XSvB4rkv9FSv2wGERCaIZcESTSqSeaWjIELT OC7USHRT7zphAO2BAmWwmIah1swD9+WCrT57l+lIeJZPvB03/oVFrWGcDycEtJtr5gsgil37NDu tIrHiKJLPhbUOy0F3zmRykLWCpb0OUrQttCIkcGcJvHPi7tYWG8n4Ivpv9vXABe0ZrQ2/2J4Y6g r31v5du3Cv7XvNsqSko1KuP02X7u4fAO7XnIRmrekVDg3/X+fNOyJ9Kr4ASimVvHUrycwt9iB6h tYfXL0bdjlja3svrP+Ea3zoy6KBJYWqlpCF/oaaD6zQ+73O6w0jFAAJqfze7gVeYxelXtHDWJna Js5w== X-Received: by 2002:a17:906:9fca:b0:c03:b8c6:cc27 with SMTP id a640c23a62f3a-c05a6bded8bmr163827566b.24.1781683249238; Wed, 17 Jun 2026 01:00:49 -0700 (PDT) Received: from xeon ([188.163.112.61]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb058fa59sm755339766b.0.2026.06.17.01.00.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 01:00:48 -0700 (PDT) From: Svyatoslav Ryhel To: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Helge Deller , Svyatoslav Ryhel Cc: Johan Hovold , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: [PATCH v5 05/14] iio: light: lm3533-als: Remove redundant pdata helpers Date: Wed, 17 Jun 2026 11:00:22 +0300 Message-ID: <20260617080031.99156-6-clamor95@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260617080031.99156-1-clamor95@gmail.com> References: <20260617080031.99156-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The lm3533_als_set_input_mode() and lm3533_als_set_resistor() functions are used only in lm3533_als_setup(). Incorporate their code into lm3533_als_setup() directly to simplify driver readability. Signed-off-by: Svyatoslav Ryhel --- drivers/iio/light/lm3533-als.c | 56 ++++++++++------------------------ 1 file changed, 16 insertions(+), 40 deletions(-) diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c index a9af8e2b965f..69bac1b202f1 100644 --- a/drivers/iio/light/lm3533-als.c +++ b/drivers/iio/light/lm3533-als.c @@ -708,55 +708,31 @@ static const struct attribute_group lm3533_als_attribute_group = { .attrs = lm3533_als_attributes }; -static int lm3533_als_set_input_mode(struct lm3533_als *als, bool pwm_mode) +static int lm3533_als_setup(struct lm3533_als *als, + const struct lm3533_als_platform_data *pdata) { + struct device *dev = &als->pdev->dev; int ret; ret = regmap_assign_bits(als->regmap, LM3533_REG_ALS_CONF, - LM3533_ALS_INPUT_MODE_MASK, pwm_mode); - if (ret) { - dev_err(&als->pdev->dev, "failed to set input mode %d\n", - pwm_mode); - return ret; - } - - return 0; -} + LM3533_ALS_INPUT_MODE_MASK, pdata->pwm_mode); + if (ret) + return dev_err_probe(dev, ret, "failed to set input mode %d\n", + pdata->pwm_mode); -static int lm3533_als_set_resistor(struct lm3533_als *als, u8 val) -{ - int ret; + /* Bail out when in PWM-mode */ + if (pdata->pwm_mode) + return 0; - if (val < LM3533_ALS_RESISTOR_MIN || val > LM3533_ALS_RESISTOR_MAX) { - dev_err(&als->pdev->dev, "invalid resistor value\n"); - return -EINVAL; - } + if (pdata->r_select < LM3533_ALS_RESISTOR_MIN || + pdata->r_select > LM3533_ALS_RESISTOR_MAX) + return dev_err_probe(dev, -EINVAL, + "invalid resistor value\n"); ret = regmap_write(als->regmap, LM3533_REG_ALS_RESISTOR_SELECT, - val); - if (ret) { - dev_err(&als->pdev->dev, "failed to set resistor\n"); - return ret; - } - - return 0; -} - -static int lm3533_als_setup(struct lm3533_als *als, - const struct lm3533_als_platform_data *pdata) -{ - int ret; - - ret = lm3533_als_set_input_mode(als, pdata->pwm_mode); + pdata->r_select); if (ret) - return ret; - - /* ALS input is always high impedance in PWM-mode. */ - if (!pdata->pwm_mode) { - ret = lm3533_als_set_resistor(als, pdata->r_select); - if (ret) - return ret; - } + return dev_err_probe(dev, ret, "failed to set resistor\n"); return 0; } -- 2.53.0